| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Don't assign the attributes if the list is empty
|
|\
| |
| | |
Dup validation fix backport for 1 9 3
|
| |
| |
| |
| |
| |
| | |
At the end of initialize_dup was added the call to super if it exists,
so it also works with 1.8.7 where initialize_dup doesn't exist.
This issu was introduced with the pull request #6324
|
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
activerecord/test/cases/adapters/mysql/mysql_adapter_test.rb
activerecord/test/cases/adapters/mysql2/schema_test.rb
|
| |
| |
| |
| |
| |
| | |
Conflicts:
activerecord/test/cases/adapters/mysql/mysql_adapter_test.rb
|
| |
| |
| |
| |
| |
| | |
Fix: 'rake rails:templates:copy' doesn't work
Conflicts:
railties/test/application/rake_test.rb
|
| |
| |
| |
| | |
Address ORA-00911 errors because of the heading underscore.
|
| |
| |
| |
| |
| |
| | |
Fix that #exists? can blow up with ThrowResult exception
Conflicts:
activerecord/lib/active_record/relation/finder_methods.rb
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
This behavior was added in dd286a4c735dac1db8c9262581c7f29c44d1f695
Closes #1139.
Fixes #2553, #1141, #1623 and #2062.
|
| |
| |
| |
| |
| |
| |
| | |
others happy that do not work without a column alias.
Conflicts:
activerecord/lib/active_record/relation/finder_methods.rb
|
|\ \
| | |
| | |
| | |
| | | |
c42engineering/buffered_logger_level_while_creation
BufferedLogger level while creation
|
| | | |
|
| | |
| | |
| | |
| | | |
Fix #6635. We should call Scoping methods, before calling Array methods.
|
|\ \ \
| | | |
| | | | |
Bugfix: Namespace collision with test-unit-activesupport 1.0.0
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
ActiveRecord#attributes optimization: minimize objects created
|
| |/ / |
|
|\ \ \
| |/ /
|/| | |
Duplicate test removed
|
|/ / |
|
| |
| |
| |
| | |
(closes #6672)
|
|\ \
| | |
| | | |
Fix issue 6673
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
if we are passing -T which is skip_test_unit
See issue #6673 for more details.
I saw that we are not creating dummy app even if
we do skip_test_unit.
Fixes #6673
|
|\ \
| |/
|/| |
Removed protected as we already doing it above.
|
|/ |
|
|
|
|
|
|
| |
Apparently asset_environment should not be invoked if it's not needed.
This fixes broken build by getting back to the code more similar to the
version changed here: 5b0a891
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After the fix done in 39f9f02a, there are cases that will not work
correctly. If you have file with "2 extensions", like foo.min.js and you
reference the file without extension, like:
javascript_include_tag "foo.min"
it will fail because sprockets finds foo.min.js with foo.min argument.
This commit fixes this case and will get the right file even when
referrencing it without extension.
(closes #6598)
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit b98d1e21635d8776de8893cc09bd86c71f6c78f0.
Closes #6609
Conflicts:
activerecord/lib/active_record/associations/has_and_belongs_to_many_association.rb
|
|\
| |
| | |
Fix human attribute_name to handle deeply nested attributes
|
|/
|
|
|
| |
This is a back-port of b0e2fc84 to Rails 3.2.
See #5843 and #3859 also.
|
|
|
|
|
|
|
|
|
| |
dangerous especially with Rack::Cache), it should only be loaded when the flash method is called"
This reverts commits e3069c64b2c5ddc7a5789b55b8efd4902d9e9729 and 2b2983d76fd11efc219273036a612f47cfaa5bfa.
Reason: This add a non-backward compatible change in the way that flash
works now (swept in every request).
|
|
|
|
|
| |
This test is needed to avoid regressions in the way that flash works
now (swept in every request).
|
|\
| |
| | |
Deprecate `:confirm` in favor of `:data => { :confirm => 'Text' }` option
|
|/
|
|
|
|
|
|
|
|
|
|
| |
This deprecation applies to:
`button_to`
`button_tag`
`image_submit_tag`
`link_to`
`submit_tag`
As :confirm is an UI specific option is better to use the data attributes,
teaching users about unobtrusive JavaScript and how Rails works with it.
|
|\
| |
| | |
[3-2-stable back ported] Fix #6591 Rails 3.2.5 Regression: incorrect _changed? for datetimes
|
| | |
|
|/ |
|
|\
| |
| |
| |
| | |
yahonda/skip_test_remove_column_with_array_as_an_argument_is_deprecated
Skip test_remove_column_with_array_as_an_argument_is_deprecated with Oracle
|
| |
| |
| |
| |
| |
| |
| | |
adapter.
Because Oracle adapter supports only remove_column :table_name, :column_name syntax
and it has never supported remove_column :table_name, [:column_name].
|
| |
| |
| |
| |
| | |
Similarly to 6525002, this allows to use routes helpers for mounted
helpers, but this time in ActionView::TestCase
|
|\ \
| | |
| | | |
Correct the use of to_model in polymorphic routing
|
| |/ |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In integration tests, you might want to use helpers from engines that
you mounted in your application. It's not hard to add it by yourself,
but it's unneeded boilerplate. mounted_helpers are now included by
default. That means that given engine mounted like:
mount Foo::Engine => "/foo", :as => "foo"
you will be able to use paths from this engine in tests this way:
foo.root_path #=> "/foo"
(closes #6573)
|
|\ \
| |/
|/| |
Backporting #6586 patch to 3-2-stable
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A series of commits relating to preloading and scopes caused a regression.
Cloning the relation calls initialize_copy which resets a number of instance
variables to nil. Without this the scope thinks that it is already loaded
when it is called again.
Reverts the following commits:
13f1401a6cf0266a3b0a91b173f976db2d4e50f3
8491740ca5361ba9df20e1c8b906c709f5bfbc12
dffbb521a0d00c8673a3ad6e0e8ff526f32daf4e
Fixes #6575, #6576 & #6577
|
|\
| |
| |
| |
| |
| |
| |
| | |
* 3-2-rel:
bumping to 3.2.4
adding security notifications to CHANGELOGs
updating changelogs
Merge pull request #6558 from parndt/fix_regression
|