aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #11451 from ↵Yves Senn2013-07-153-0/+18
| | | | | | | | jetthoughts/11450_do_not_resave_destroyed_association Do not re-save destroyed association on saving parent object Conflicts: activerecord/lib/active_record/autosave_association.rb
* Preparing for 3.2.14.rc1 releaseRafael Mendonça França2013-07-1216-24/+26
|
* Add missing require so that DateTime has the right superclassAndrew White2013-07-101-0/+1
| | | | | | | | | | If the DateTime core extensions were loaded before the Date core extensions then you would get a superclass mismatch as DateTime hasn't been defined yet so it gets set to Object by the acts_like core extension. Fixes #11206 (cherry picked from commit 78f7d5b652000dbb1a11d34fe370c3fa82de840c)
* Return local time for backwards compatibilityAndrew White2013-07-093-10/+27
|
* Retain offset and fraction when using Time.at_with_coercionAndrew White2013-07-093-3/+51
| | | | | | | | | | | | | | | | The standard Ruby behavior for Time.at is to return the same type of time when passing an instance of Time as a single argument. Since the an ActiveSupport::TimeWithZone instance may be a different timezone than the system timezone and DateTime just understands offsets the best we can do is to return an instance of Time with the correct offset. It also maintains the correct fractional second value as well. Fixes #11350. Backports: 484253515c0e05760541dc48946361185c9e6904 1b3873730b96035a238dbff7627bd5942e6dc4e7
* Do not shallow the original exception in exec_cacheRafael Mendonça França2013-07-092-1/+11
| | | | | | | when result_error_field is not defined on result raise the original exception. Fixes #11260
* Remove git dependecyRafael Mendonça França2013-07-081-1/+1
|
* Add license to the gemspecRafael Mendonça França2013-07-088-0/+19
|
* New changelog entries always on the top [ci skip]Rafael Mendonça França2013-07-061-4/+5
|
* Remove warning of assigned but unused variableRafael Mendonça França2013-07-061-1/+1
|
* Skip connection url test when the machine is using socket configuration.Rafael Mendonça França2013-07-061-0/+3
| | | | The connection url parssing don't accept the socket option
* Add missing requireSantiago Pastorino2013-07-021-0/+1
|
* Merge pull request #8881 from carsonreinke/3-2-stableRafael Mendonça França2013-07-013-2/+23
|\ | | | | 3-2-stable ActiveSupport::TaggedLogging logging progname issue
| * Incorrectly providing program name the same as log message even when block ↵Carson Reinke2013-07-013-2/+23
|/ | | | is not provided.
* unify duplicate CHANGELOG entryYves Senn2013-06-271-6/+2
|
* Merge pull request #9173 from senny/backport_perftest_fixYves Senn2013-06-278-8/+23
|\ | | | | Backport rails/rails-perftest#2 to fix rake test:benchmark
| * clear ARGV to prevent mintest autorun errors:Yves Senn2013-06-273-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Minitest expects the first argument in `ARGV` to be the path to a test file. Because `rails benchmarker` and `rails profiler` define an on-the-fly test-case, using the first `ARGV` to pass the code to execute this results in: ``` /Users/senny/.rbenv/versions/1.9.3-p374/lib/ruby/1.9.1/test/unit.rb:167:in `block in non_options': file not found: 1000.times{"a string"} (ArgumentError) from /Users/senny/.rbenv/versions/1.9.3-p374/lib/ruby/1.9.1/test/unit.rb:146:in `map!' from /Users/senny/.rbenv/versions/1.9.3-p374/lib/ruby/1.9.1/test/unit.rb:146:in `non_options' from /Users/senny/.rbenv/versions/1.9.3-p374/lib/ruby/1.9.1/test/unit.rb:207:in `non_options' from /Users/senny/.rbenv/versions/1.9.3-p374/lib/ruby/1.9.1/test/unit.rb:52:in `process_args' from /Users/senny/.rbenv/versions/1.9.3-p374/lib/ruby/1.9.1/minitest/unit.rb:891:in `_run' from /Users/senny/.rbenv/versions/1.9.3-p374/lib/ruby/1.9.1/minitest/unit.rb:884:in `run' from /Users/senny/.rbenv/versions/1.9.3-p374/lib/ruby/1.9.1/test/unit.rb:21:in `run' from /Users/senny/.rbenv/versions/1.9.3-p374/lib/ruby/1.9.1/test/unit.rb:326:in `block (2 levels) in autorun' from /Users/senny/.rbenv/versions/1.9.3-p374/lib/ruby/1.9.1/test/unit.rb:27:in `run_once' from /Users/senny/.rbenv/versions/1.9.3-p374/lib/ruby/1.9.1/test/unit.rb:325:in `block in autorun' ``` clearing ARGV after defining the test-case solves this issue.
| * Backport rails/rails-perftest#2 to fix rake test:benchmarkYves Senn2013-06-277-8/+15
|/
* Merge pull request #11019 from tkhr/test_case_for_issue_10393Yves Senn2013-06-253-1/+29
|\ | | | | Add test case for issue #10393 and fix warning message
| * Allow global override of default STI inheritance columnchapmajs2013-06-263-1/+29
| | | | | | | | | | | | This change fixes a bug by which 3.2-STABLE users can't globally override the default STI inheritance column with `ActiveRecord::Base.inheritance_column = 'some_column'`. 3.2-STABLE users are forced to use a deprecated method or monkey patch it otherwise. Test case written by tkhr <takehiro0740@gmail.com>.
* | build fix, fall back to old hash syntaxYves Senn2013-06-261-3/+3
|/
* Merge pull request #9893 from ↵Yves Senn2013-06-251-0/+13
|\ | | | | | | | | JonRowe/add_test_to_assert_association_doesnt_overwrite Add a test to assert autosaving associations doesn't overwrite id accessor methods
| * test case to assert that associations do not overwrite after create, fixes #9310Jon Rowe2013-03-241-0/+13
| |
* | Move changelog entry to the top [ci skip]Carlos Antonio da Silva2013-06-251-5/+6
| |
* | Merge pull request #10373 from janko-m/fix-store-accessorCarlos Antonio da Silva2013-06-253-1/+13
|\ \ | | | | | | | | | Fix a bug in ActiveRecord::Store accessors
| * | Fix ActiveRecord::Store not tracking changesJanko Marohnić2013-04-293-1/+13
| | |
* | | Revert "Revert "Merge pull request #10901 from ↵Yves Senn2013-06-253-1/+43
| | | | | | | | | | | | | | | | | | | | | | | | armstrjare/fix_query_null_foreign_key_on_new_record_collection_ids_reader"" This reverts commit 5009b078875e596a2fba7827336f7548aa6e35ac. Also updated the CHANGELOG and adjusted the test-case to match the one on master.
* | | Use old style hash syntax for 3-2-stableAndrew White2013-06-251-2/+2
| | |
* | | Fix shorthand routes where controller and action are in the scopeAndrew White2013-06-253-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Merge `:action` from routing scope and assign endpoint if both `:controller` and `:action` are present. The endpoint assignment only occurs if there is no `:to` present in the options hash so should only affect routes using the shorthand syntax (i.e. endpoint is inferred from the the path). Fixes #9856 Backport of 37b4276
* | | Add CHANGELOG entry for #10971Rafael Mendonça França2013-06-241-0/+14
| | | | | | | | | | | | [ci skip]
* | | Merge pull request #10971 from dtaniwaki/escape_link_to_unlessRafael Mendonça França2013-06-242-1/+6
| | | | | | | | | | | | Always escape the result of link_to_unless method
* | | Fix textile markupRafael Mendonça França2013-06-241-1/+1
| | | | | | | | | | | | | | | Closes #11076 [ci skip]
* | | Revert "Merge pull request #10901 from ↵Yves Senn2013-06-223-34/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | armstrjare/fix_query_null_foreign_key_on_new_record_collection_ids_reader" This reverts commit 6675d713186c270de1c4684bc1e56742ea2e19e1, reversing changes made to 919d1a19d5e7871d50c1531351fc3f736bad5d07. I missed to check the target branch and wrongly merged it into 3-2-stable directly.
* | | Merge pull request #10901 from ↵Yves Senn2013-06-223-1/+34
|\ \ \ | | | | | | | | | | | | | | | | armstrjare/fix_query_null_foreign_key_on_new_record_collection_ids_reader Fixes CollectionAssociation#ids_reader returning incorrect ids for new records
| * | | Fixes CollectionAssociation#ids_reader returning incorrect ids for new recordsJared Armstrong2013-06-213-1/+34
| | | |
* | | | Merge pull request #11033 from robin850/patch-1Xavier Noria2013-06-201-5/+5
|\ \ \ \ | | | | | | | | | | Update the feedback instructions
| * | | | Update the feedback instructions [ci skip]Robin Dupret2013-06-201-5/+5
|/ / / / | | | | | | | | | | | | | | | | | | | | Since docrails as moved from lifo/docrails to rails/docrails we have to ask for commit rights or submit patches directly to the rails repository
* | | | Merge pull request #10883 from ifeelgoods/3-2-stableYves Senn2013-06-191-2/+2
|\ \ \ \ | | | | | | | | | | The default cache store is :file_store in caching_with_rails.textile
| * | | | indicate the default Rails cache storeMatthieu Paret2013-06-191-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | memory_store is the default cache store implementation if you call ActiveSupport::Cache.lookup_store without arguments.
* | | | | Compare host scheme using case-insensitive regexpRafael Mendonça França2013-06-163-11/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: image_tag("HTTP://google.com") # => "<img alt=\"Google\" src=\"/assets/HTTP://google.com\" />" image_tag("http://google.com") # => "<img alt=\"Google\" src=\"http://google.com\" />" After: image_tag("HTTP://google.com") # => "<img alt=\"Google\" src=\"HTTP://google.com\" />" image_tag("http://google.com") # => "<img alt=\"Google\" src=\"http://google.com\" />" Backport of #10969
* | | | | nokogiri >= 1.6 doesn't work with ruby 1.8Rafael Mendonça França2013-06-151-1/+1
| | | | |
* | | | | Merge pull request #10925 from senny/10917_test_to_prevent_regressionYves Senn2013-06-153-3/+35
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | regression test + mysql2 adapter raises correct error if conn is closed. Conflicts: activerecord/CHANGELOG.md
* | | | Override Time.at to work with Time-like valuesAndrew White2013-06-083-0/+38
|/ / / | | | | | | | | | | | | | | | | | | Time.at allows passing a single Time argument which is then converted to an integer. The conversion code since 1.9.3r429 explicitly checks for an instance of Time so we need to override it to allow DateTime and ActiveSupport::TimeWithZone values.
* | | adding a test for #10830Aaron Patterson2013-06-051-0/+46
| | |
* | | Restore rescue block for when IM is enabledAndrew White2013-05-241-19/+22
| | |
* | | Merge pull request #10745 from arunagw/build_fix_ruby187Andrew White2013-05-244-7/+7
|\ \ \ | | | | | | | | Build fix ruby187
| * | | It's scoped in 3-2-stable!Arun Agrawal2013-05-241-1/+1
| | | | | | | | | | | | scope => scoped
| * | | Using 1.8.7 syntax for 3-2-stableArun Agrawal2013-05-243-6/+6
|/ / /
* | | Merge pull request #10713 from senny/10693_fix_primary_key_option_on_has_manyRafael Mendonça França2013-05-234-2/+15
| | | | | | | | | | | | | | | | | | | | | Fix the `:primary_key` option for `has_many` associations. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/associations/has_many_association.rb
* | | Merge pull request #10681 from jholton/3-2-stable-fix_association_auto_saveRafael Mendonça França2013-05-223-31/+48
|\ \ \ | | | | | | | | autosave_association issue that occurs when table has unique index (3.2.x backport)