Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Arel::Sql::Engine.new does not do anything anymore | Aaron Patterson | 2010-09-30 | 2 | -2/+2 | |
| | ||||||
* | type_name should check for blank because people may have messed up databases | Aaron Patterson | 2010-09-30 | 2 | -1/+15 | |
| | ||||||
* | build_where should be private | Aaron Patterson | 2010-09-30 | 1 | -2/+2 | |
| | ||||||
* | type_name is never a blank string, so use faster .nil? call | Aaron Patterson | 2010-09-30 | 1 | -1/+1 | |
| | ||||||
* | AssociationCollection#include? working properly for objects added with build ↵ | Marcelo Giorgi | 2010-09-30 | 4 | -0/+39 | |
| | | | | method [#3472 state:resolved] | |||||
* | speeding up object instantiation by eliminating instance_eval | Aaron Patterson | 2010-09-30 | 1 | -7/+21 | |
| | ||||||
* | changing map and include to find | Aaron Patterson | 2010-09-30 | 1 | -1/+1 | |
| | ||||||
* | [#5441 state:resolved] refactoring code to determine aggregate column | Aaron Patterson | 2010-09-30 | 1 | -11/+14 | |
| | ||||||
* | group clause must be more specific | Aaron Patterson | 2010-09-30 | 1 | -1/+1 | |
| | ||||||
* | Tests proving #5441 | oleg dashevskii | 2010-09-30 | 1 | -1/+11 | |
| | ||||||
* | Fix 'rake db:create' is ignore encoding when using postgres [#5717 ↵ | yalab | 2010-09-30 | 1 | -1/+1 | |
| | | | | | | state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | no need to check for nil | Neeraj Singh | 2010-09-30 | 1 | -1/+1 | |
| | ||||||
* | assert on empty array is always true. fixing test. | Neeraj Singh | 2010-09-30 | 1 | -1/+1 | |
| | ||||||
* | Revert "removing crazy finalizer code until there is proof that we need it" | José Valim | 2010-09-30 | 1 | -0/+11 | |
| | | | | This reverts commit a40e3c1a9604ab3737ad2465c8f6a6db0fe0cc78. | |||||
* | Add more information to comments. | José Valim | 2010-09-30 | 1 | -3/+5 | |
| | ||||||
* | Merge remote branch 'drogus/engines' | José Valim | 2010-09-30 | 11 | -47/+289 | |
|\ | ||||||
| * | Try to guess application's directory while trying to run the server, but ↵ | Piotr Sarnacki | 2010-09-30 | 1 | -0/+5 | |
| | | | | | | | | only if config.ru is not present in current dir | |||||
| * | Moved Rails::RoutesReloader to Rails::Application::RoutesReloader | Piotr Sarnacki | 2010-09-30 | 3 | -56/+57 | |
| | | ||||||
| * | Allow running generators for Engine with usage of other application. | Piotr Sarnacki | 2010-09-30 | 1 | -1/+11 | |
| | | | | | | | | | | | | | | | | After that commit, developers can set ENGINE_PATH in ENGINE/scripts/rails file and load application's ./script/rails (most of the time it will be dummy application used for testing). When running ./script/rails g it will use application to boot up, but then it will use Engine's root and configuration for generators. | |||||
| * | Added config.app_generators to allow configuring application's generators ↵ | Piotr Sarnacki | 2010-09-30 | 5 | -5/+58 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from railties. With config.generators becomes a way to configure generators for current instance only. For example: module Blog class Engine < Rails::Engine config.generators do |g| g.orm :active_record end config.app_generators do |g| g.test_framework :rspec end end end such definition sets :active_record as orm for engine and :rspec as test_framework for application. The values set with app_generators can be overwritten in application using config.generators as you would normally do: module MyApp class Application < Rails::Application config.generators do |g| g.test_framework :test_unit end end end | |||||
| * | Move routes_reloader to a class: RoutesReloader | Piotr Sarnacki | 2010-09-30 | 3 | -23/+57 | |
| | | ||||||
| * | Properly reload routes defined in class definition | Piotr Sarnacki | 2010-09-30 | 4 | -6/+63 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sometimes it's easier to define routes inside Engine or Application class definition (e.g. one file applications). The problem with such case is that if there is a plugin that has config/routes.rb file, it will trigger routes reload on application. Since routes definition for application is not in config/routes.rb file routes_reloader will fail to reload application's routes properly. With this commit you can pass routes definition as a block to routes method, which will allow to properly reload it: class MyApp::Application < Rails::Application routes do resources :users end end | |||||
| * | Allow mounting engines at '/' | Piotr Sarnacki | 2010-09-30 | 2 | -17/+78 | |
| | | | | | | | | | | Without that commit script_name always become '/', which results in paths like //posts/1 instead of /posts/1 | |||||
| * | Do not overwrite _railtie method on namespace while creating isolated engine ↵ | Piotr Sarnacki | 2010-09-30 | 2 | -12/+33 | |
|/ | | | | | | | | | or application. In order to run Engine as standalone application, you will need Rails::Application instance in the same namespace that engine one. It's very important to leave _railtie bound to whatever used "namespace" method first. | |||||
* | Use .find here as it is simpler and faster. | José Valim | 2010-09-30 | 1 | -1/+1 | |
| | ||||||
* | avoid creating a block if possible | Aaron Patterson | 2010-09-29 | 1 | -2/+2 | |
| | ||||||
* | fixing regexp warnings | Aaron Patterson | 2010-09-29 | 1 | -1/+1 | |
| | ||||||
* | tag value can be false, so nil? check is necessary | Aaron Patterson | 2010-09-29 | 1 | -1/+1 | |
| | ||||||
* | double negative is not good | Neeraj Singh | 2010-09-30 | 1 | -1/+1 | |
| | ||||||
* | another case of extra nil? check | Neeraj Singh | 2010-09-30 | 1 | -1/+1 | |
| | ||||||
* | no need to check for nil? | Neeraj Singh | 2010-09-30 | 1 | -2/+2 | |
| | ||||||
* | no need to check for nil? | Neeraj Singh | 2010-09-30 | 1 | -1/+1 | |
| | ||||||
* | no need of nil check | Neeraj Singh | 2010-09-30 | 1 | -1/+1 | |
| | ||||||
* | no need of nil check | Neeraj Singh | 2010-09-29 | 1 | -1/+1 | |
| | ||||||
* | removing crazy finalizer code until there is proof that we need it | Aaron Patterson | 2010-09-29 | 1 | -9/+0 | |
| | ||||||
* | removing useless code | Aaron Patterson | 2010-09-29 | 1 | -1/+0 | |
| | ||||||
* | dry up method checking in the request object | Aaron Patterson | 2010-09-29 | 1 | -10/+9 | |
| | ||||||
* | reduce function calls on Array | Aaron Patterson | 2010-09-29 | 1 | -3/+2 | |
| | ||||||
* | removing more lolinject | Aaron Patterson | 2010-09-29 | 1 | -8/+7 | |
| | ||||||
* | removing lollerject | Aaron Patterson | 2010-09-29 | 1 | -1/+1 | |
| | ||||||
* | self is implied, so remove self | Aaron Patterson | 2010-09-29 | 1 | -1/+1 | |
| | ||||||
* | dry up method missing | Aaron Patterson | 2010-09-29 | 1 | -5/+2 | |
| | ||||||
* | oops, missed a uniq | Aaron Patterson | 2010-09-29 | 1 | -1/+1 | |
| | ||||||
* | dry up action_methods | Aaron Patterson | 2010-09-29 | 1 | -4/+4 | |
| | ||||||
* | fixing space error | Aaron Patterson | 2010-09-29 | 1 | -1/+1 | |
| | ||||||
* | Use detect instead select to avoid "sh: [mysqldump]: command not found". | Emilio Tagua | 2010-09-29 | 1 | -1/+1 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-29 | 6 | -9/+17 | |
|\ | ||||||
| * | We can't assign @view_context_class here, define super() in test instead if ↵ | Emilio Tagua | 2010-09-29 | 2 | -1/+2 | |
| | | | | | | | | we want to avoid warnings. | |||||
| * | _ is not a valid scheme name character, \w includes it and also is redundant ↵ | Emilio Tagua | 2010-09-29 | 2 | -1/+8 | |
| | | | | | | | | | | | | with \d. 'The scheme name consists of a letter followed by any combination of letters, digits, and the plus ("+"), period ("."), or hyphen ("-") characters; and is terminated by a colon (":").' | |||||
| * | Remove redundant conditional. | Emilio Tagua | 2010-09-29 | 1 | -5/+1 | |
| | |