aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'master' of git@github.com:rails/railsrick2008-05-312-15/+24
|\
| * Fixed Dependencies so load errors are not masked behind a 'Expected x.rb to ↵Tom Ward2008-05-312-15/+24
| | | | | | | | | | | | define X' message when mechanism is not set to :load [#87 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com>
* | Merge branch 'master' of git@github.com:technoweenie/railsrick2008-05-310-0/+0
|\ \
| * | belongs_to polymorphic association assignments update the foreign_id and ↵Tim Harper2008-05-312-5/+30
| |/ | | | | | | | | | | | | | | | | foreign_type fields regardless of whether the record being assigned is new or not. fixes the following scenarios: * I have validates_inclusion_of on the type field for a polymorphic belongs_to association. I assign a new record to the model's polymorphic relationship of the proper type. validation fails because the type field has not been updated. * I replace the value for a ppolymorphic association to a new record of another class. The type field still says its the previous class, and the id field points to the previous record as well.
* / belongs_to polymorphic association assignments update the foreign_id and ↵Tim Harper2008-05-312-5/+30
|/ | | | | | | | | | | foreign_type fields regardless of whether the record being assigned is new or not. fixes the following scenarios: * I have validates_inclusion_of on the type field for a polymorphic belongs_to association. I assign a new record to the model's polymorphic relationship of the proper type. validation fails because the type field has not been updated. * I replace the value for a ppolymorphic association to a new record of another class. The type field still says its the previous class, and the id field points to the previous record as well. [#191 state:closed]
* Fix default nil tests for MySQL 5.0.51 [#192 state:resolved]Ryan Bates2008-05-311-1/+1
| | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Ensure query assertion counts are the same when partial updates are enabledJeremy Kemper2008-05-302-0/+3
|
* Enable partial updates by defaultJeremy Kemper2008-05-301-1/+1
|
* Require ruby-prof 0.6.1 or later. Use resume/pause to omit extraneous ↵Jeremy Kemper2008-05-301-8/+17
| | | | machinery from profile.
* git ignore rubinius .rbc filesJeremy Kemper2008-05-301-0/+1
|
* Ensure script/plugin installs ssh/git plugins. [#277 state:resolved]Tekin Suleyman2008-05-291-1/+1
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ensure :select passed in options overrides the one from the scope. [#239 ↵Andrew White2008-05-292-1/+17
| | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Add ActionMailer#reply_to. [#245 state:resolved]Adam2008-05-293-8/+48
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ensure AssociationCollection#count works with empty condition. [#271 ↵Pratik Naik2008-05-292-1/+5
| | | | state:resolved] [Jan De Poorter]
* Ensure correct db time is reported in production logs.Pratik Naik2008-05-281-9/+5
|
* Ensure named_scope#empty? uses count query. [#262 state:resolved]Ryan Bates2008-05-282-1/+13
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Remove superfluous tests directiveJeremy Kemper2008-05-261-2/+0
|
* Don't require AV::TestCases to have a helper class. Only include the helper ↵Jeremy Kemper2008-05-261-10/+4
| | | | class in setup if it hasn't been already.
* Fix tests for postgres 8.3.xTarmo Tänav2008-05-262-5/+5
| | | | | | | | | Made test_with_limiting_with_custom_select not dependent on database default order. Fixed tests with non-US monetary locale. The monetary type is fixed precision so it should not expect the database to return a float. Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* TimeZone#to_s shows offset as GMT instead of UTC, because GMT will be more ↵gbuesing2008-05-253-2/+4
| | | | familiar to end users (see time zone selects used by Windows OS, google.com and yahoo.com.) Reverts [8370]
* Merge docrails.Pratik Naik2008-05-2585-778/+886
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix faulty tests introduced in 8d0b4fa39Michael Koziarski2008-05-243-4/+5
|
* Create through associations can now work with blocks.Ryan Bates2008-05-242-8/+17
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#248 state:resolved]
* add failing test case for block-setting of attributes via associationTrevor Turk2008-05-241-0/+9
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Added :select option to has_one and belongs_to, remove unused :order option ↵josevalim2008-05-247-13/+30
| | | | | | | on belongs_to. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#241 state:resolved]
* Mention partial updates in environment.rb to make it easier for people to ↵Michael Koziarski2008-05-231-0/+3
| | | | opt-in if they know it's safe
* Return Partial Updates to be purely opt in to prevent users from ↵Michael Koziarski2008-05-231-3/+0
| | | | inadvertently corrupting data.
* Fix auto_link helper for already linked urls. [#72 state:resolved]Kevin Glowacz2008-05-222-2/+3
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix failing tests on mysql 4.1 & ruby 1.8.4. [#237 state:resolved]Frederick Cheung2008-05-221-2/+2
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Show rails version when the server starts. [#235 state:resolved]Lawrence Pit2008-05-224-4/+4
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Add Rails.version. [#236 state:resolved]Ryan Bates2008-05-222-2/+6
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Parentheses should be acceptable characters for auto_link_urls. [#234 ↵Adam2008-05-222-1/+2
| | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix mysql 4.1 incompatibility in the active record schema tests.Frederick Cheung2008-05-221-32/+41
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#233 state:resolved ]
* ActiveRecord::Base#reload should clear dirty attributes. [#231 state:resolved]Ryan Bates2008-05-212-0/+16
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Improve check_box_checked? to use include? for Array values. [#193 ↵Erkki Eilonen2008-05-212-0/+13
| | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Verbose ActiveRecord::AssociationTypeMismatch exception message. [#189 ↵Pratik Naik2008-05-211-1/+2
| | | | state:resolved]
* Ensure nil to '' doesn't get recorded by dirty for nullable integer columns. ↵Pratik Naik2008-05-202-8/+26
| | | | [#150 state:resolved] [Jason Dew, Pratik]
* Add first/last methods to associations/named_scope. [#226 state:resolved]Ryan Bates2008-05-208-4/+149
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix Dependencies watch_frames collection. [#24 state:resolved]Tom Ward2008-05-202-1/+7
| | | | | | | | | | Previously, the code collecting watch_frames could fail leaving watch_frames defined but nil. The cleanup code checks watch_frames is defined, but not that it holds a value, raising an undefined method on NilClass error rather than the original cause. This can make debugging the underlying cause a total pain. Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ensure add_column gives valid error for sqlite. [Gunnar Wolf, Pratik] [#197 ↵Pratik Naik2008-05-202-0/+30
| | | | | | | | state:resolved] SQLite#add_column executes "VACUUM", which fails if inside a live transaction. This patch ensures a valid exception is raised if add_column is executed within a live transaction for sqlite adapter.
* Don't rely on association proxying object_id. [#225 state:resolved]Jeremy Kemper2008-05-191-2/+2
|
* - Updated tzinfo to use Rational() instead of Rational.new! due to "private ↵Nate Wiger2008-05-193-60/+60
| | | | | | method new!" in Ruby 1.9 - Added ^object_id$ as ignore pattern to fixing "redefining object_id" issue in Ruby 1.9 Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Bundle tmail 1.2.3Jeremy Kemper2008-05-1928-13/+38
|
* Ruby 1.9 compat: ensure binary encoding for post body parsingJeremy Kemper2008-05-196-17/+40
|
* Ruby 1.9 compat: qualify module name within module_evaled blockJeremy Kemper2008-05-191-1/+1
|
* Workaround missing Test::Unit::TestCase::PASSTHROUGH_EXCEPTIONS in Ruby < ↵Jeremy Kemper2008-05-191-2/+10
| | | | 1.8.6. [#224 state:resolved]
* Test for assert_response for failure response without an exception. [#141 ↵Chris Hapgood2008-05-191-0/+14
| | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Add fragment_exist? and exist? methods to cache stores. [#203 state:resolved]José Valim2008-05-196-26/+59
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ensure observe_field encodes value parameter. [#216 state:resolved]Frederick Cheung2008-05-192-3/+3
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Adding documentation for time zone featuresgbuesing2008-05-184-9/+72
|