aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Test return value of ActiveSupport::Dependencies::Loadable#loadSam Umbach2011-12-031-0/+16
|
* Test return value of ActiveSupport::Dependencies::Loadable#requireSam Umbach2011-12-031-0/+47
| | | | | - Add tests to protect from regressions in require's return value behavior - See a10606c490471d8e1483acb3b31d7f2d51e9ebbe (require needs to return true or false) for the original bug fix
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-12-025-11/+14
|\
| * Added doc about pluck for active_support core extArun Agrawal2011-12-021-0/+10
| |
| * [Docs] Information about ActionDispatch::DebugExceptions in rake taskArun Agrawal2011-12-021-0/+1
| |
| * Adding information about ActionDispatch::DebugExceptionsArun Agrawal2011-12-021-1/+1
| |
| * [docs] removed last-modifed line from examplesRichard Hulse2011-12-021-8/+0
| | | | | | | | | | | | | | This is no longer best-practice. ref: http://stackoverflow.com/questions/8344186/rails-3-1-on-apache-pagespeed-says-specify-cache-validator-when-using-asset-p/8348385#8348385
| * fixed finger-dyslexia in active_support core extensions guideTim Sjoberg2011-12-011-1/+1
| |
| * typo in the performance testing rails guideLeandro Santos2011-11-301-1/+1
| |
* | rephrase doc on explain thresholdVijay Dev2011-12-021-1/+1
| |
* | Merge pull request #3832 from arunagw/indentationXavier Noria2011-12-021-1/+1
|\ \ | | | | | | indentation fix warning
| * | indentation fix warningArun Agrawal2011-12-021-1/+1
|/ /
* | revises some details in the previous explain patchXavier Noria2011-12-023-4/+4
| |
* | Revert "Roflscaling!" (for now)Jon Leighton2011-12-022-8/+11
| | | | | | | | | | | | | | | | This reverts commit f6b5046305d43c5f64bcb6fed0e44f7bca99a603. Fear not, the roflscale will return when I have a bit more time and figure out a better way to do it. (In particular, a way that doesn't break the build.)
* | implements automatic EXPLAIN logging for slow queriesXavier Noria2011-12-0218-96/+354
| |
* | Added Enumerable#pluck to wrap the common pattern of collect(&:method) *DHH*David Heinemeier Hansson2011-12-023-3/+19
| |
* | Try to play nice with plugins doing monkey patches.José Valim2011-12-021-0/+5
| |
* | Fewer string allocations in attribute methodJon Leighton2011-12-011-4/+4
| |
* | Roflscaling!Jon Leighton2011-12-012-11/+8
| | | | | | | | | | Don't prefix the name with attribute_. Avoids a string allocation on read_attribute, which is a bit faster.
* | Create method with known identifier then alias into place.Jon Leighton2011-12-012-25/+23
| | | | | | | | | | | | | | | | This means we never have to rely on define_method (which is slower and uses more memory), even when we have attributes containing characters that are not allowed in standard method names. (I am mainly changing this because the duplication annoys me, though.)
* | Remove some unnecessary code etcJon Leighton2011-12-012-26/+11
| |
* | Add test for read_attribute(:id) with non-standard PK.Jon Leighton2011-12-013-4/+23
| | | | | | | | | | | | | | | | Also make it actually work. It slows down all read_attribute accesses to map 'id' to whatever the PK actually is, inside read_attribute. So instead make sure the necessary methods are defined and that they redirect wherever they need to go.
* | Remove the need for type_cast_attribute.Jon Leighton2011-12-015-43/+52
| | | | | | | | This is good because it reduces duplication.
* | Fix up test altering global state that was causing me griefJon Leighton2011-12-011-2/+4
| |
* | Get rid of the underscore versions of attribute methods!Jon Leighton2011-12-016-6/+40
| | | | | | | | This makes me happy!
* | Don't rely on underscore-prefixed attribute methods.Jon Leighton2011-12-013-48/+80
| | | | | | | | | | | | Define singleton methods on the attributes module instead. This reduces method pollution on the actual model classes. It also seems to make something faster, I am unsure why! O_o
* | Remove unnecessary *argsJon Leighton2011-12-011-2/+2
| |
* | Merge branch 'exceptions' with the following features:José Valim2011-12-0116-254/+406
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | * A Railtie API for registering new exceptions and their respective status code (check Active Record railtie for an example) * Extraction of ShowExceptions middleware logging and debugging features into a middleware called DebugExceptions Conflicts: actionpack/CHANGELOG.md
| * | Remove unnecessary test setup.José Valim2011-12-011-6/+1
| | |
| * | Split and improve show and debug exceptions middlewares.José Valim2011-12-014-89/+145
| | |
| * | Split ShowExceptions responsibilities in two middlewares.José Valim2011-12-0110-95/+130
| | |
| * | Add a deprecation to old show exceptions API (even though it was not public).José Valim2011-12-011-0/+14
| | |
| * | Add an ExceptionWrapper that wraps an exception and provide convenience helpers.José Valim2011-12-015-77/+104
| | |
| * | Allow rescue responses to be configured through a railtie.José Valim2011-12-016-30/+55
| | |
* | | Revert "Added ActiveRecord::Base#last_modified to work with the new ↵David Heinemeier Hansson2011-12-014-12/+4
| | | | | | | | | | | | | | | | | | | | | | | | fresh_when/stale? conditional get methods from Action Pack" Needless indirection with no added value. This reverts commit 535853e83b9092078035a5abb2aa242fba815c05.
* | | Added ActiveRecord::Base#last_modified to work with the new ↵David Heinemeier Hansson2011-12-014-4/+12
| | | | | | | | | | | | fresh_when/stale? conditional get methods from Action Pack
* | | Allow fresh_when/stale? to take a record instead of an options hash [DHH]David Heinemeier Hansson2011-12-013-4/+97
|/ /
* | Update CHANGELOG.José Valim2011-12-011-1/+3
| |
* | Merge pull request #3660 from jdelStrother/asset_protocolJosé Valim2011-12-012-2/+22
|\ \ | | | | | | default_asset_host_protocol should not default to :relative
| * | Leave default_asset_host_protocol unsetJonathan del Strother2011-12-012-2/+22
|/ / | | | | When default_asset_host_protocol is left as nil, it will use absolute protocols when a request is present, and relative protocols otherwise (eg in asset generation)
* | Merge pull request #3823 from avakhov/av-length-validation-exception-msg-fixJosé Valim2011-11-301-1/+1
|\ \ | | | | | | Fix argument error message for length validation
| * | Fix argument error message for length validationAlexey Vakhov2011-12-011-1/+1
|/ /
* | Add hackery to make Syck use encode_with/init_with. Fixes 1.8 after recent ↵Jon Leighton2011-12-012-0/+25
| | | | | | | | changes to attribute serialization.
* | don't alter global state in testJon Leighton2011-11-301-2/+3
| |
* | If the table behind has no primary key, do not ask again and just return nil.Julius de Bruijn2011-11-302-1/+7
| |
* | consistencyJon Leighton2011-11-303-16/+16
| |
* | Don't check column type, you might implement a custom coder that serializes ↵Jon Leighton2011-11-301-1/+1
| | | | | | | | to a different type
* | omg computer science!Jon Leighton2011-11-304-29/+47
| | | | | | | | | | | | | | Implement a mini state machine for serialized attributes. This means we do not have to deserialize the values upon initialization, which means that if we never actually access the attribute, we never have to deserialize it.
* | Fix typoJon Leighton2011-11-301-2/+2
| |
* | Don't need second paramJon Leighton2011-11-302-4/+4
| |