aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add gem 'arel' from git commented out as an example of how to Bundle egde ↵Santiago Pastorino2010-09-291-0/+1
| | | | | | Rails with Arel edge [#5723 state:committed]
* removing more useless code! yay!Aaron Patterson2010-09-281-6/+2
|
* SqlLiteral is a string, so we can dry up these conditionalsAaron Patterson2010-09-281-4/+3
|
* shorten up or sql literal creation statementsAaron Patterson2010-09-281-4/+2
|
* we only care about arrays and stringsAaron Patterson2010-09-281-1/+1
|
* dry up calls to arel.join()Aaron Patterson2010-09-281-5/+4
|
* removing unused lasgnsAaron Patterson2010-09-281-4/+4
|
* refactoring to remove crazy logicAaron Patterson2010-09-282-9/+6
|
* where_values_hash always returns a hashAaron Patterson2010-09-281-1/+1
|
* performance improvement based on discussion at ↵Neeraj Singh2010-09-281-9/+3
| | | | | | http://github.com/rails/rails/commit/fbd1d306b95cc2efb6422e12d26d5818a3a42343 Credit goes to all the participants in the discussion
* Revert "porting 515917f5d8678af6c57842ca5dfd7c18e67ff1fe to master"Aaron Patterson2010-09-281-6/+0
| | | | This reverts commit bee447a5b9fe1d683c6cc69aefb7fc22c2a9d9af.
* Revert "porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks ↵Aaron Patterson2010-09-281-1/+1
| | | | | | Marcelo Giorgi" This reverts commit 9eca11a4a564f44675cca951216e917b8f610eab.
* removing a conditional that is not usedAaron Patterson2010-09-281-2/+0
|
* fisting the postgresql testsAaron Patterson2010-09-281-1/+2
|
* Set attributes properly for model built from association with conditions ↵Marcelo Giorgi2010-09-288-10/+61
| | | | | | [#5562 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* convert inject to map + joinAaron Patterson2010-09-281-5/+5
|
* each works well tooAaron Patterson2010-09-281-1/+1
|
* no need for splat and flattenAaron Patterson2010-09-281-1/+1
|
* avoid calling to_sql when we canAaron Patterson2010-09-282-4/+4
|
* removing an inject + merge in favor of Hash#[]Aaron Patterson2010-09-281-1/+1
|
* fixing indentation warningAaron Patterson2010-09-281-1/+1
|
* Test add_index and remove_index with a symbol name #4891Étienne Barrié2010-09-282-4/+10
|
* porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks Marcelo ↵Aaron Patterson2010-09-281-1/+1
| | | | Giorgi
* porting 515917f5d8678af6c57842ca5dfd7c18e67ff1fe to masterAaron Patterson2010-09-281-0/+6
|
* Move uri parser to AS as URI.parser method to reuse it in AP and ARes.Emilio Tagua2010-09-288-43/+25
|
* use new skool Ruby instead of Ruby Classic™Aaron Patterson2010-09-271-5/+3
|
* be kind to the garbage collector: only instantiate objects when absolutely ↵Aaron Patterson2010-09-271-14/+17
| | | | necessary
* adding test cases for the dynamic finder matcher match methodAaron Patterson2010-09-271-0/+49
|
* constructor should not do so much work; avoid allocating object if possibleAaron Patterson2010-09-271-10/+5
|
* @klass also uses DynamicFinderMatch, so no need for it on the relationAaron Patterson2010-09-272-9/+5
|
* no need for a case / when statementAaron Patterson2010-09-271-11/+7
|
* do not need intermediate variable, avoid lasgnAaron Patterson2010-09-271-2/+3
|
* DRY up our regular expressionAaron Patterson2010-09-271-3/+3
|
* reduce method calls in the dynamic finder matcherAaron Patterson2010-09-271-4/+4
|
* Fix tests on 1.9.2.José Valim2010-09-282-5/+1
|
* revises RDoc of Hash#to_param to be more precise about orderingXavier Noria2010-09-281-2/+2
|
* let Hash#to_param and Hash#to_query sort againXavier Noria2010-09-282-5/+10
| | | | | This was a regression introduced in 5c858220085dc4ddc1bec496747059dfbe32f1da. We bring sorting back because people rely on it, eg for constructing consistent cache keys.
* make sure we use the engine assigned to the table when quotingAaron Patterson2010-09-272-1/+19
|
* Test for after_create callback order in ActiveSupport [#5703 state:resolved]Neeraj Singh2010-09-271-0/+23
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* after_create in ActiveModel should in the order specifiedNeeraj Singh2010-09-272-1/+31
| | | | | | [#5650 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* renderer calls object.to_json when rendering :json => object [#5655 ↵Diego Carrion2010-09-272-1/+14
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix for #5579 involved the code change for both has_one and has_many ↵Neeraj Singh2010-09-271-1/+9
| | | | | | | | relationships. The path included test only for has_one. This patch adds test for has_many relationship. [#5706 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix for nested_attributes with has_many association fails when a single ↵Neeraj Singh2010-09-272-1/+14
| | | | | | | | record is being updated. [#5705 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix broken module namespacing in ActiveResource with Ruby 1.9 [#5699 ↵Matthijs Langenberg2010-09-274-5/+22
| | | | | | | | | | | | | | | | | | | | | | | state:resolved] Following namespace use case was broken with Ruby 1.9: class Author < ActiveRecord::Base ... end module Api class Book < ActiveResouce::Base end end Let's say XML contains <book><author><name>John</name></author>.... Api::Book.first.author.class.to_s #=> Ruby 1.8.7: "Api::Book::Author" (namespaced, correct), Ruby 1.9: "Author" (toplevel, broken) Signed-off-by: José Valim <jose.valim@gmail.com>
* Properly initialize variables inside the initialize method.José Valim2010-09-271-3/+8
|
* Define @_routes inside method, makes more sense and will be initialized when ↵Emilio Tagua2010-09-272-2/+1
| | | | | | called anywhere. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Remove more warnings shadowing outer local variable.Emilio Tagua2010-09-275-17/+17
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Remove warning "URI.unescape is obsolete" from actionpack.Emilio Tagua2010-09-276-13/+16
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Merge remote branch 'gramos/ares-missing-prefix-value'José Valim2010-09-275-1/+41
|\
| * - added mock to test ActiveResource::MissingPrefixParam in finder_testGaston Ramos2010-09-271-0/+1
| |