aboutsummaryrefslogtreecommitdiffstats
path: root/test
diff options
context:
space:
mode:
Diffstat (limited to 'test')
-rw-r--r--test/attributes/test_attribute.rb30
-rw-r--r--test/collectors/test_bind_collector.rb2
-rw-r--r--test/nodes/test_infix_operation.rb2
-rw-r--r--test/nodes/test_window.rb12
-rw-r--r--test/test_insert_manager.rb11
-rw-r--r--test/test_select_manager.rb160
-rw-r--r--test/visitors/test_dot.rb8
-rw-r--r--test/visitors/test_to_sql.rb5
8 files changed, 154 insertions, 76 deletions
diff --git a/test/attributes/test_attribute.rb b/test/attributes/test_attribute.rb
index e53b32d0ac..dd2d9d343e 100644
--- a/test/attributes/test_attribute.rb
+++ b/test/attributes/test_attribute.rb
@@ -66,7 +66,7 @@ module Arel
relation[:id].gt(10).must_be_kind_of Nodes::GreaterThan
end
- it 'should generate >= in sql' do
+ it 'should generate > in sql' do
relation = Table.new(:users)
mgr = relation.project relation[:id]
mgr.where relation[:id].gt(10)
@@ -74,6 +74,17 @@ module Arel
SELECT "users"."id" FROM "users" WHERE "users"."id" > 10
}
end
+
+ it 'should handle comparing with a subquery' do
+ users = Table.new(:users)
+
+ avg = users.project(users[:karma].average)
+ mgr = users.project(Arel.star).where(users[:karma].gt(avg))
+
+ mgr.to_sql.must_be_like %{
+ SELECT * FROM "users" WHERE "users"."karma" > (SELECT AVG("users"."karma") FROM "users")
+ }
+ end
end
describe '#gt_any' do
@@ -258,12 +269,11 @@ module Arel
relation[:id].average.must_be_kind_of Nodes::Avg
end
- # FIXME: backwards compat. Is this really necessary?
- it 'should set the alias to "avg_id"' do
+ it 'should generate the proper SQL' do
relation = Table.new(:users)
mgr = relation.project relation[:id].average
mgr.to_sql.must_be_like %{
- SELECT AVG("users"."id") AS avg_id
+ SELECT AVG("users"."id")
FROM "users"
}
end
@@ -275,12 +285,11 @@ module Arel
relation[:id].maximum.must_be_kind_of Nodes::Max
end
- # FIXME: backwards compat. Is this really necessary?
- it 'should set the alias to "max_id"' do
+ it 'should generate the proper SQL' do
relation = Table.new(:users)
mgr = relation.project relation[:id].maximum
mgr.to_sql.must_be_like %{
- SELECT MAX("users"."id") AS max_id
+ SELECT MAX("users"."id")
FROM "users"
}
end
@@ -299,12 +308,11 @@ module Arel
relation[:id].sum.must_be_kind_of Nodes::Sum
end
- # FIXME: backwards compat. Is this really necessary?
- it 'should set the alias to "sum_id"' do
+ it 'should generate the proper SQL' do
relation = Table.new(:users)
mgr = relation.project relation[:id].sum
mgr.to_sql.must_be_like %{
- SELECT SUM("users"."id") AS sum_id
+ SELECT SUM("users"."id")
FROM "users"
}
end
@@ -550,8 +558,6 @@ module Arel
end
describe '#not_in' do
- it 'can be constructed with a list' do
- end
it 'should return a NotIn node' do
attribute = Attribute.new nil, nil
diff --git a/test/collectors/test_bind_collector.rb b/test/collectors/test_bind_collector.rb
index 036d8f05fe..60532f061c 100644
--- a/test/collectors/test_bind_collector.rb
+++ b/test/collectors/test_bind_collector.rb
@@ -49,7 +49,7 @@ module Arel
offsets = values.map.with_index { |v,i|
[v,i]
- }.find_all { |(v,i)| Nodes::BindParam === v }.map(&:last)
+ }.find_all { |(v,_)| Nodes::BindParam === v }.map(&:last)
list = collector.substitute_binds ["hello", "world"]
assert_equal "hello", list[offsets[0]]
diff --git a/test/nodes/test_infix_operation.rb b/test/nodes/test_infix_operation.rb
index bec226e395..40616024e5 100644
--- a/test/nodes/test_infix_operation.rb
+++ b/test/nodes/test_infix_operation.rb
@@ -18,7 +18,7 @@ module Arel
assert_equal 'zomg', aliaz.right
end
- def test_opertaion_ordering
+ def test_operation_ordering
operation = InfixOperation.new :+, 1, 2
ordering = operation.desc
assert_kind_of Descending, ordering
diff --git a/test/nodes/test_window.rb b/test/nodes/test_window.rb
index f09d16e441..9ec42be59f 100644
--- a/test/nodes/test_window.rb
+++ b/test/nodes/test_window.rb
@@ -7,9 +7,11 @@ module Arel
it 'is equal with equal ivars' do
window1 = Window.new
window1.orders = [1, 2]
+ window1.partitions = [1]
window1.frame 3
window2 = Window.new
window2.orders = [1, 2]
+ window2.partitions = [1]
window2.frame 3
array = [window1, window2]
assert_equal 1, array.uniq.size
@@ -18,9 +20,11 @@ module Arel
it 'is not equal with different ivars' do
window1 = Window.new
window1.orders = [1, 2]
+ window1.partitions = [1]
window1.frame 3
window2 = Window.new
window2.orders = [1, 2]
+ window1.partitions = [1]
window2.frame 4
array = [window1, window2]
assert_equal 2, array.uniq.size
@@ -33,9 +37,11 @@ module Arel
it 'is equal with equal ivars' do
window1 = NamedWindow.new 'foo'
window1.orders = [1, 2]
+ window1.partitions = [1]
window1.frame 3
window2 = NamedWindow.new 'foo'
window2.orders = [1, 2]
+ window2.partitions = [1]
window2.frame 3
array = [window1, window2]
assert_equal 1, array.uniq.size
@@ -44,9 +50,11 @@ module Arel
it 'is not equal with different ivars' do
window1 = NamedWindow.new 'foo'
window1.orders = [1, 2]
+ window1.partitions = [1]
window1.frame 3
window2 = NamedWindow.new 'bar'
window2.orders = [1, 2]
+ window2.partitions = [1]
window2.frame 3
array = [window1, window2]
assert_equal 2, array.uniq.size
@@ -68,6 +76,4 @@ module Arel
end
end
end
-end
-
-
+end \ No newline at end of file
diff --git a/test/test_insert_manager.rb b/test/test_insert_manager.rb
index 4e82ca34c0..9cfd01262b 100644
--- a/test/test_insert_manager.rb
+++ b/test/test_insert_manager.rb
@@ -78,14 +78,19 @@ module Arel
}
end
- it 'takes an empty list' do
+ it 'noop for empty list' do
+ table = Table.new(:users)
manager = Arel::InsertManager.new Table.engine
+ manager.insert [[table[:id], 1]]
manager.insert []
+ manager.to_sql.must_be_like %{
+ INSERT INTO "users" ("id") VALUES (1)
+ }
end
end
describe 'into' do
- it 'takes an engine' do
+ it 'takes a Table and chains' do
manager = Arel::InsertManager.new Table.engine
manager.into(Table.new(:users)).must_equal manager
end
@@ -126,7 +131,7 @@ module Arel
end
describe "combo" do
- it "puts shit together" do
+ it "combines columns and values list in order" do
table = Table.new :users
manager = Arel::InsertManager.new Table.engine
manager.into table
diff --git a/test/test_select_manager.rb b/test/test_select_manager.rb
index 09608ea71e..3380bbec6f 100644
--- a/test/test_select_manager.rb
+++ b/test/test_select_manager.rb
@@ -140,7 +140,7 @@ module Arel
mgr.to_sql.must_be_like %{ SELECT FROM "users" INNER JOIN "users" "users_2" ON omg }
end
- it 'converts to sqlliterals' do
+ it 'converts to sqlliterals with multiple items' do
table = Table.new :users
right = table.alias
mgr = table.from table
@@ -152,7 +152,7 @@ module Arel
describe 'clone' do
it 'creates new cores' do
- table = Table.new :users, :engine => Table.engine, :as => 'foo'
+ table = Table.new :users, :as => 'foo'
mgr = table.from table
m2 = mgr.clone
m2.project "foo"
@@ -160,7 +160,7 @@ module Arel
end
it 'makes updates to the correct copy' do
- table = Table.new :users, :engine => Table.engine, :as => 'foo'
+ table = Table.new :users, :as => 'foo'
mgr = table.from table
m2 = mgr.clone
m3 = m2.clone
@@ -172,7 +172,7 @@ module Arel
describe 'initialize' do
it 'uses alias in sql' do
- table = Table.new :users, :engine => Table.engine, :as => 'foo'
+ table = Table.new :users, :as => 'foo'
mgr = table.from table
mgr.skip 10
mgr.to_sql.must_be_like %{ SELECT FROM "users" "foo" OFFSET 10 }
@@ -330,6 +330,20 @@ module Arel
end
describe 'with' do
+ it 'should support basic WITH' do
+ users = Table.new(:users)
+ users_top = Table.new(:users_top)
+ comments = Table.new(:comments)
+
+ top = users.project(users[:id]).where(users[:karma].gt(100))
+ users_as = Arel::Nodes::As.new(users_top, top)
+ select_manager = comments.project(Arel.star).with(users_as)
+ .where(comments[:author_id].in(users_top.project(users_top[:id])))
+
+ select_manager.to_sql.must_be_like %{
+ WITH "users_top" AS (SELECT "users"."id" FROM "users" WHERE "users"."karma" > 100) SELECT * FROM "comments" WHERE "comments"."author_id" IN (SELECT "users_top"."id" FROM "users_top")
+ }
+ end
it "should support WITH RECURSIVE" do
comments = Table.new(:comments)
@@ -368,8 +382,7 @@ module Arel
it 'should return the ast' do
table = Table.new :users
mgr = table.from table
- ast = mgr.ast
- assert ast
+ assert mgr.ast
end
it 'should allow orders to work when the ast is grepped' do
@@ -518,7 +531,7 @@ module Arel
assert_equal 'bar', join.right
end
- it 'should create join nodes with a klass' do
+ it 'should create join nodes with a full outer join klass' do
relation = Arel::SelectManager.new Table.engine
join = relation.create_join 'foo', 'bar', Arel::Nodes::FullOuterJoin
assert_kind_of Arel::Nodes::FullOuterJoin, join
@@ -526,7 +539,7 @@ module Arel
assert_equal 'bar', join.right
end
- it 'should create join nodes with a klass' do
+ it 'should create join nodes with a outer join klass' do
relation = Arel::SelectManager.new Table.engine
join = relation.create_join 'foo', 'bar', Arel::Nodes::OuterJoin
assert_kind_of Arel::Nodes::OuterJoin, join
@@ -534,7 +547,7 @@ module Arel
assert_equal 'bar', join.right
end
- it 'should create join nodes with a klass' do
+ it 'should create join nodes with a right outer join klass' do
relation = Arel::SelectManager.new Table.engine
join = relation.create_join 'foo', 'bar', Arel::Nodes::RightOuterJoin
assert_kind_of Arel::Nodes::RightOuterJoin, join
@@ -602,7 +615,8 @@ module Arel
end
describe 'joins' do
- it 'returns join sql' do
+
+ it 'returns inner join sql' do
table = Table.new :users
aliaz = table.alias
manager = Arel::SelectManager.new Table.engine
@@ -637,6 +651,22 @@ module Arel
}
end
+ it "joins itself" do
+ left = Table.new :users
+ right = left.alias
+ predicate = left[:id].eq(right[:id])
+
+ mgr = left.join(right)
+ mgr.project Nodes::SqlLiteral.new('*')
+ mgr.on(predicate).must_equal mgr
+
+ mgr.to_sql.must_be_like %{
+ SELECT * FROM "users"
+ INNER JOIN "users" "users_2"
+ ON "users"."id" = "users_2"."id"
+ }
+ end
+
it 'returns string join sql' do
manager = Arel::SelectManager.new Table.engine
manager.from Nodes::StringJoin.new(Nodes.build_quoted('hello'))
@@ -702,6 +732,47 @@ module Arel
}
end
+ it 'takes an order with multiple columns' do
+ table = Table.new :users
+ manager = Arel::SelectManager.new Table.engine
+ manager.from table
+ manager.window('a_window').order(table['foo'].asc, table['bar'].desc)
+ manager.to_sql.must_be_like %{
+ SELECT FROM "users" WINDOW "a_window" AS (ORDER BY "users"."foo" ASC, "users"."bar" DESC)
+ }
+ end
+
+ it 'takes a partition' do
+ table = Table.new :users
+ manager = Arel::SelectManager.new Table.engine
+ manager.from table
+ manager.window('a_window').partition(table['bar'])
+ manager.to_sql.must_be_like %{
+ SELECT FROM "users" WINDOW "a_window" AS (PARTITION BY "users"."bar")
+ }
+ end
+
+ it 'takes a partition and an order' do
+ table = Table.new :users
+ manager = Arel::SelectManager.new Table.engine
+ manager.from table
+ manager.window('a_window').partition(table['foo']).order(table['foo'].asc)
+ manager.to_sql.must_be_like %{
+ SELECT FROM "users" WINDOW "a_window" AS (PARTITION BY "users"."foo"
+ ORDER BY "users"."foo" ASC)
+ }
+ end
+
+ it 'takes a partition with multiple columns' do
+ table = Table.new :users
+ manager = Arel::SelectManager.new Table.engine
+ manager.from table
+ manager.window('a_window').partition(table['bar'], table['baz'])
+ manager.to_sql.must_be_like %{
+ SELECT FROM "users" WINDOW "a_window" AS (PARTITION BY "users"."bar", "users"."baz")
+ }
+ end
+
it 'takes a rows frame, unbounded preceding' do
table = Table.new :users
manager = Arel::SelectManager.new Table.engine
@@ -878,6 +949,27 @@ module Arel
end
describe 'update' do
+
+ it 'creates an update statement' do
+ table = Table.new :users
+ manager = Arel::SelectManager.new Table.engine
+ manager.from table
+ stmt = manager.compile_update({table[:id] => 1}, Arel::Attributes::Attribute.new(table, 'id'))
+
+ stmt.to_sql.must_be_like %{
+ UPDATE "users" SET "id" = 1
+ }
+ end
+
+ it 'takes a string' do
+ table = Table.new :users
+ manager = Arel::SelectManager.new Table.engine
+ manager.from table
+ stmt = manager.compile_update(Nodes::SqlLiteral.new('foo = bar'), Arel::Attributes::Attribute.new(table, 'id'))
+
+ stmt.to_sql.must_be_like %{ UPDATE "users" SET foo = bar }
+ end
+
it 'copies limits' do
table = Table.new :users
manager = Arel::SelectManager.new Table.engine
@@ -906,15 +998,6 @@ module Arel
}
end
- it 'takes a string' do
- table = Table.new :users
- manager = Arel::SelectManager.new Table.engine
- manager.from table
- stmt = manager.compile_update(Nodes::SqlLiteral.new('foo = bar'), Arel::Attributes::Attribute.new(table, 'id'))
-
- stmt.to_sql.must_be_like %{ UPDATE "users" SET foo = bar }
- end
-
it 'copies where clauses' do
table = Table.new :users
manager = Arel::SelectManager.new Table.engine
@@ -940,19 +1023,15 @@ module Arel
}
end
- it 'executes an update statement' do
- table = Table.new :users
- manager = Arel::SelectManager.new Table.engine
- manager.from table
- stmt = manager.compile_update({table[:id] => 1}, Arel::Attributes::Attribute.new(table, 'id'))
-
- stmt.to_sql.must_be_like %{
- UPDATE "users" SET "id" = 1
- }
- end
end
describe 'project' do
+ it "takes sql literals" do
+ manager = Arel::SelectManager.new Table.engine
+ manager.project Nodes::SqlLiteral.new '*'
+ manager.to_sql.must_be_like %{ SELECT * }
+ end
+
it 'takes multiple args' do
manager = Arel::SelectManager.new Table.engine
manager.project Nodes::SqlLiteral.new('foo'),
@@ -966,11 +1045,6 @@ module Arel
manager.to_sql.must_be_like %{ SELECT * }
end
- it "takes sql literals" do
- manager = Arel::SelectManager.new Table.engine
- manager.project Nodes::SqlLiteral.new '*'
- manager.to_sql.must_be_like %{ SELECT * }
- end
end
describe 'projections' do
@@ -1042,24 +1116,6 @@ module Arel
end
end
- describe "join" do
- it "joins itself" do
- left = Table.new :users
- right = left.alias
- predicate = left[:id].eq(right[:id])
-
- mgr = left.join(right)
- mgr.project Nodes::SqlLiteral.new('*')
- mgr.on(predicate).must_equal mgr
-
- mgr.to_sql.must_be_like %{
- SELECT * FROM "users"
- INNER JOIN "users" "users_2"
- ON "users"."id" = "users_2"."id"
- }
- end
- end
-
describe 'from' do
it "makes sql" do
table = Table.new :users
diff --git a/test/visitors/test_dot.rb b/test/visitors/test_dot.rb
index ee7fc7886c..7763350f5c 100644
--- a/test/visitors/test_dot.rb
+++ b/test/visitors/test_dot.rb
@@ -17,13 +17,13 @@ module Arel
].each do |klass|
define_method("test_#{klass.name.gsub('::', '_')}") do
op = klass.new(:a, "z")
- @visitor.accept op
+ @visitor.accept op, Collectors::PlainString.new
end
end
def test_named_function
func = Nodes::NamedFunction.new 'omg', 'omg'
- @visitor.accept func
+ @visitor.accept func, Collectors::PlainString.new
end
# unary ops
@@ -41,7 +41,7 @@ module Arel
].each do |klass|
define_method("test_#{klass.name.gsub('::', '_')}") do
op = klass.new(:a)
- @visitor.accept op
+ @visitor.accept op, Collectors::PlainString.new
end
end
@@ -68,7 +68,7 @@ module Arel
].each do |klass|
define_method("test_#{klass.name.gsub('::', '_')}") do
binary = klass.new(:a, :b)
- @visitor.accept binary
+ @visitor.accept binary, Collectors::PlainString.new
end
end
end
diff --git a/test/visitors/test_to_sql.rb b/test/visitors/test_to_sql.rb
index 738bbe9626..c03d89cfef 100644
--- a/test/visitors/test_to_sql.rb
+++ b/test/visitors/test_to_sql.rb
@@ -254,6 +254,11 @@ module Arel
compile(Nodes.build_quoted(nil)).must_be_like "NULL"
end
+ it "unsupported input should not raise ArgumentError" do
+ error = assert_raises(RuntimeError) { compile(nil) }
+ assert_match(/\Aunsupported/, error.message)
+ end
+
it "should visit_Arel_SelectManager, which is a subquery" do
mgr = Table.new(:foo).project(:bar)
compile(mgr).must_be_like '(SELECT bar FROM "foo")'
generated by cgit v1.2.3 (git 2.25.1) at 2024-08-19 14:38:45 +0000