1 files changed, 67 insertions, 39 deletions
diff --git a/railties/test/application/rake_test.rb b/railties/test/application/rake_test.rb
index e8c8de9f73..0da0928b48 100644
--- a/railties/test/application/rake_test.rb
+++ b/railties/test/application/rake_test.rb
@@ -1,4 +1,3 @@
-# coding:utf-8
 require "isolation/abstract_unit"
 require "active_support/core_ext/string/strip"
 
@@ -36,7 +35,7 @@ module ApplicationTests
         Rails.application.initialize!
       RUBY
 
-      assert_match("SuperMiddleware", Dir.chdir(app_path){ `rake middleware` })
+      assert_match("SuperMiddleware", Dir.chdir(app_path){ `bin/rake middleware` })
     end
 
     def test_initializers_are_executed_in_rake_tasks
@@ -51,7 +50,7 @@ module ApplicationTests
         end
       RUBY
 
-      output = Dir.chdir(app_path){ `rake do_nothing` }
+      output = Dir.chdir(app_path){ `bin/rake do_nothing` }
       assert_match "Doing something...", output
     end
 
@@ -72,7 +71,7 @@ module ApplicationTests
         end
       RUBY
 
-      output = Dir.chdir(app_path) { `rake do_nothing` }
+      output = Dir.chdir(app_path) { `bin/rake do_nothing` }
       assert_match 'Hello world', output
     end
 
@@ -93,14 +92,14 @@ module ApplicationTests
       RUBY
 
       Dir.chdir(app_path) do
-        assert system('rake do_nothing RAILS_ENV=production'),
+        assert system('bin/rake do_nothing RAILS_ENV=production'),
                'should not be pre-required for rake even eager_load=true'
       end
     end
 
     def test_code_statistics_sanity
-      assert_match "Code LOC: 5     Test LOC: 0     Code to Test Ratio: 1:0.0",
-        Dir.chdir(app_path){ `rake stats` }
+      assert_match "Code LOC: 7     Test LOC: 0     Code to Test Ratio: 1:0.0",
+        Dir.chdir(app_path){ `bin/rake stats` }
     end
 
     def test_rake_routes_calls_the_route_inspector
@@ -110,7 +109,7 @@ module ApplicationTests
         end
       RUBY
 
-      output = Dir.chdir(app_path){ `rake routes` }
+      output = Dir.chdir(app_path){ `bin/rake routes` }
       assert_equal "Prefix Verb URI Pattern     Controller#Action\n  cart GET  /cart(.:format) cart#show\n", output
     end
 
@@ -123,7 +122,7 @@ module ApplicationTests
       RUBY
 
       ENV['CONTROLLER'] = 'cart'
-      output = Dir.chdir(app_path){ `rake routes` }
+      output = Dir.chdir(app_path){ `bin/rake routes` }
       assert_equal "Prefix Verb URI Pattern     Controller#Action\n  cart GET  /cart(.:format) cart#show\n", output
     end
 
@@ -133,7 +132,7 @@ module ApplicationTests
         end
       RUBY
 
-      assert_equal <<-MESSAGE.strip_heredoc, Dir.chdir(app_path){ `rake routes` }
+      assert_equal <<-MESSAGE.strip_heredoc, Dir.chdir(app_path){ `bin/rake routes` }
         You don't have any routes defined!
 
         Please add some routes in config/routes.rb.
@@ -151,21 +150,21 @@ module ApplicationTests
         end
       RUBY
 
-      output = Dir.chdir(app_path){ `rake log_something RAILS_ENV=production && cat log/production.log` }
+      output = Dir.chdir(app_path){ `bin/rake log_something RAILS_ENV=production && cat log/production.log` }
       assert_match "Sample log message", output
     end
 
     def test_loading_specific_fixtures
       Dir.chdir(app_path) do
-        `rails generate model user username:string password:string;
-         rails generate model product name:string;
-         rake db:migrate`
+        `bin/rails generate model user username:string password:string;
+         bin/rails generate model product name:string;
+         bin/rake db:migrate`
       end
 
       require "#{rails_root}/config/environment"
 
       # loading a specific fixture
-      errormsg = Dir.chdir(app_path) { `rake db:fixtures:load FIXTURES=products` }
+      errormsg = Dir.chdir(app_path) { `bin/rake db:fixtures:load FIXTURES=products` }
       assert $?.success?, errormsg
 
       assert_equal 2, ::AppTemplate::Application::Product.count
@@ -174,42 +173,64 @@ module ApplicationTests
 
     def test_loading_only_yml_fixtures
       Dir.chdir(app_path) do
-        `rake db:migrate`
+        `bin/rake db:migrate`
       end
 
       app_file "test/fixtures/products.csv", ""
 
       require "#{rails_root}/config/environment"
-      errormsg = Dir.chdir(app_path) { `rake db:fixtures:load` }
+      errormsg = Dir.chdir(app_path) { `bin/rake db:fixtures:load` }
       assert $?.success?, errormsg
     end
 
     def test_scaffold_tests_pass_by_default
       output = Dir.chdir(app_path) do
-        `rails generate scaffold user username:string password:string;
-         bundle exec rake db:migrate test`
+        `bin/rails generate scaffold user username:string password:string;
+         bin/rake db:migrate test`
       end
 
-      assert_match(/7 runs, 13 assertions, 0 failures, 0 errors/, output)
+      assert_match(/7 runs, 12 assertions, 0 failures, 0 errors/, output)
       assert_no_match(/Errors running/, output)
     end
 
-    def test_scaffold_with_references_columns_tests_pass_by_default
+    def test_api_scaffold_tests_pass_by_default
+      add_to_config <<-RUBY
+        config.api_only = true
+      RUBY
+
+      app_file "app/controllers/application_controller.rb", <<-RUBY
+        class ApplicationController < ActionController::API
+        end
+      RUBY
+
       output = Dir.chdir(app_path) do
-        `rails generate scaffold LineItems product:references cart:belongs_to;
-         bundle exec rake db:migrate test`
+        `bin/rails generate scaffold user username:string password:string;
+         bin/rake db:migrate test`
       end
 
-      assert_match(/7 runs, 13 assertions, 0 failures, 0 errors/, output)
+      assert_match(/5 runs, 7 assertions, 0 failures, 0 errors/, output)
+      assert_no_match(/Errors running/, output)
+    end
+
+    def test_scaffold_with_references_columns_tests_pass_when_belongs_to_is_optional
+      app_file "config/initializers/active_record_belongs_to_required_by_default.rb",
+        "Rails.application.config.active_record.belongs_to_required_by_default = false"
+
+      output = Dir.chdir(app_path) do
+        `bin/rails generate scaffold LineItems product:references cart:belongs_to;
+         bin/rake db:migrate test`
+      end
+
+      assert_match(/7 runs, 12 assertions, 0 failures, 0 errors/, output)
       assert_no_match(/Errors running/, output)
     end
 
     def test_db_test_clone_when_using_sql_format
       add_to_config "config.active_record.schema_format = :sql"
       output = Dir.chdir(app_path) do
-        `rails generate scaffold user username:string;
-         bundle exec rake db:migrate;
-         bundle exec rake db:test:clone 2>&1 --trace`
+        `bin/rails generate scaffold user username:string;
+         bin/rake db:migrate;
+         bin/rake db:test:clone 2>&1 --trace`
       end
       assert_match(/Execute db:test:clone_structure/, output)
     end
@@ -217,9 +238,9 @@ module ApplicationTests
     def test_db_test_prepare_when_using_sql_format
       add_to_config "config.active_record.schema_format = :sql"
       output = Dir.chdir(app_path) do
-        `rails generate scaffold user username:string;
-         bundle exec rake db:migrate;
-         bundle exec rake db:test:prepare 2>&1 --trace`
+        `bin/rails generate scaffold user username:string;
+         bin/rake db:migrate;
+         bin/rake db:test:prepare 2>&1 --trace`
       end
       assert_match(/Execute db:test:load_structure/, output)
     end
@@ -227,7 +248,7 @@ module ApplicationTests
     def test_rake_dump_structure_should_respect_db_structure_env_variable
       Dir.chdir(app_path) do
         # ensure we have a schema_migrations table to dump
-        `bundle exec rake db:migrate db:structure:dump DB_STRUCTURE=db/my_structure.sql`
+        `bin/rake db:migrate db:structure:dump SCHEMA=db/my_structure.sql`
       end
       assert File.exist?(File.join(app_path, 'db', 'my_structure.sql'))
     end
@@ -236,8 +257,8 @@ module ApplicationTests
       add_to_config "config.active_record.schema_format = :sql"
 
       output = Dir.chdir(app_path) do
-        `rails g model post title:string;
-         bundle exec rake db:migrate:redo 2>&1 --trace;`
+        `bin/rails g model post title:string;
+         bin/rake db:migrate:redo 2>&1 --trace;`
       end
 
       # expect only Invoke db:structure:dump (first_time)
@@ -246,23 +267,23 @@ module ApplicationTests
 
     def test_rake_dump_schema_cache
       Dir.chdir(app_path) do
-        `rails generate model post title:string;
-         rails generate model product name:string;
-         bundle exec rake db:migrate db:schema:cache:dump`
+        `bin/rails generate model post title:string;
+         bin/rails generate model product name:string;
+         bin/rake db:migrate db:schema:cache:dump`
       end
       assert File.exist?(File.join(app_path, 'db', 'schema_cache.dump'))
     end
 
     def test_rake_clear_schema_cache
       Dir.chdir(app_path) do
-        `bundle exec rake db:schema:cache:dump db:schema:cache:clear`
+        `bin/rake db:schema:cache:dump db:schema:cache:clear`
       end
       assert !File.exist?(File.join(app_path, 'db', 'schema_cache.dump'))
     end
 
     def test_copy_templates
       Dir.chdir(app_path) do
-        `bundle exec rake rails:templates:copy`
+        `bin/rake rails:templates:copy`
         %w(controller mailer scaffold).each do |dir|
           assert File.exist?(File.join(app_path, 'lib', 'templates', 'erb', dir))
         end
@@ -277,10 +298,17 @@ module ApplicationTests
       app_file "template.rb", ""
 
       output = Dir.chdir(app_path) do
-        `bundle exec rake rails:template LOCATION=template.rb`
+        `bin/rake rails:template LOCATION=template.rb`
       end
 
       assert_match(/Hello, World!/, output)
     end
+
+    def test_tmp_clear_should_work_if_folder_missing
+      FileUtils.remove_dir("#{app_path}/tmp")
+      errormsg = Dir.chdir(app_path) { `bin/rake tmp:clear` }
+      assert_predicate $?, :success?
+      assert_empty errormsg
+    end
   end
 end