diff options
Diffstat (limited to 'activerecord/test/cases/arel/nodes')
32 files changed, 333 insertions, 307 deletions
diff --git a/activerecord/test/cases/arel/nodes/and_test.rb b/activerecord/test/cases/arel/nodes/and_test.rb index de63e0bb31..eff54abd91 100644 --- a/activerecord/test/cases/arel/nodes/and_test.rb +++ b/activerecord/test/cases/arel/nodes/and_test.rb @@ -1,21 +1,21 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes - describe 'And' do - describe 'equality' do - it 'is equal with equal ivars' do - array = [And.new(['foo', 'bar']), And.new(['foo', 'bar'])] + describe "And" do + describe "equality" do + it "is equal with equal ivars" do + array = [And.new(["foo", "bar"]), And.new(["foo", "bar"])] assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do - array = [And.new(['foo', 'bar']), And.new(['foo', 'baz'])] + it "is not equal with different ivars" do + array = [And.new(["foo", "bar"]), And.new(["foo", "baz"])] assert_equal 2, array.uniq.size end end end end end - diff --git a/activerecord/test/cases/arel/nodes/as_test.rb b/activerecord/test/cases/arel/nodes/as_test.rb index 09c8aa8d62..1169ea11c9 100644 --- a/activerecord/test/cases/arel/nodes/as_test.rb +++ b/activerecord/test/cases/arel/nodes/as_test.rb @@ -1,32 +1,33 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes - describe 'As' do - describe '#as' do - it 'makes an AS node' do + describe "As" do + describe "#as" do + it "makes an AS node" do attr = Table.new(:users)[:id] - as = attr.as(Arel.sql('foo')) + as = attr.as(Arel.sql("foo")) assert_equal attr, as.left - assert_equal 'foo', as.right + assert_equal "foo", as.right end - it 'converts right to SqlLiteral if a string' do + it "converts right to SqlLiteral if a string" do attr = Table.new(:users)[:id] - as = attr.as('foo') + as = attr.as("foo") assert_kind_of Arel::Nodes::SqlLiteral, as.right end end - describe 'equality' do - it 'is equal with equal ivars' do - array = [As.new('foo', 'bar'), As.new('foo', 'bar')] + describe "equality" do + it "is equal with equal ivars" do + array = [As.new("foo", "bar"), As.new("foo", "bar")] assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do - array = [As.new('foo', 'bar'), As.new('foo', 'baz')] + it "is not equal with different ivars" do + array = [As.new("foo", "bar"), As.new("foo", "baz")] assert_equal 2, array.uniq.size end end diff --git a/activerecord/test/cases/arel/nodes/ascending_test.rb b/activerecord/test/cases/arel/nodes/ascending_test.rb index 5c73e69fa5..1efb16222a 100644 --- a/activerecord/test/cases/arel/nodes/ascending_test.rb +++ b/activerecord/test/cases/arel/nodes/ascending_test.rb @@ -1,43 +1,44 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes class TestAscending < Arel::Test def test_construct - ascending = Ascending.new 'zomg' - assert_equal 'zomg', ascending.expr + ascending = Ascending.new "zomg" + assert_equal "zomg", ascending.expr end def test_reverse - ascending = Ascending.new 'zomg' + ascending = Ascending.new "zomg" descending = ascending.reverse assert_kind_of Descending, descending assert_equal ascending.expr, descending.expr end def test_direction - ascending = Ascending.new 'zomg' + ascending = Ascending.new "zomg" assert_equal :asc, ascending.direction end def test_ascending? - ascending = Ascending.new 'zomg' + ascending = Ascending.new "zomg" assert ascending.ascending? end def test_descending? - ascending = Ascending.new 'zomg' + ascending = Ascending.new "zomg" assert !ascending.descending? end def test_equality_with_same_ivars - array = [Ascending.new('zomg'), Ascending.new('zomg')] + array = [Ascending.new("zomg"), Ascending.new("zomg")] assert_equal 1, array.uniq.size end def test_inequality_with_different_ivars - array = [Ascending.new('zomg'), Ascending.new('zomg!')] + array = [Ascending.new("zomg"), Ascending.new("zomg!")] assert_equal 2, array.uniq.size end end diff --git a/activerecord/test/cases/arel/nodes/bin_test.rb b/activerecord/test/cases/arel/nodes/bin_test.rb index 923a296adf..ee2ec3cf2f 100644 --- a/activerecord/test/cases/arel/nodes/bin_test.rb +++ b/activerecord/test/cases/arel/nodes/bin_test.rb @@ -1,32 +1,33 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes class TestBin < Arel::Test def test_new - assert Arel::Nodes::Bin.new('zomg') + assert Arel::Nodes::Bin.new("zomg") end def test_default_to_sql viz = Arel::Visitors::ToSql.new Table.engine.connection_pool - node = Arel::Nodes::Bin.new(Arel.sql('zomg')) - assert_equal 'zomg', viz.accept(node, Collectors::SQLString.new).value + node = Arel::Nodes::Bin.new(Arel.sql("zomg")) + assert_equal "zomg", viz.accept(node, Collectors::SQLString.new).value end def test_mysql_to_sql viz = Arel::Visitors::MySQL.new Table.engine.connection_pool - node = Arel::Nodes::Bin.new(Arel.sql('zomg')) - assert_equal 'BINARY zomg', viz.accept(node, Collectors::SQLString.new).value + node = Arel::Nodes::Bin.new(Arel.sql("zomg")) + assert_equal "BINARY zomg", viz.accept(node, Collectors::SQLString.new).value end def test_equality_with_same_ivars - array = [Bin.new('zomg'), Bin.new('zomg')] + array = [Bin.new("zomg"), Bin.new("zomg")] assert_equal 1, array.uniq.size end def test_inequality_with_different_ivars - array = [Bin.new('zomg'), Bin.new('zomg!')] + array = [Bin.new("zomg"), Bin.new("zomg!")] assert_equal 2, array.uniq.size end end diff --git a/activerecord/test/cases/arel/nodes/binary_test.rb b/activerecord/test/cases/arel/nodes/binary_test.rb index 0bea35f7dd..9bc55a155b 100644 --- a/activerecord/test/cases/arel/nodes/binary_test.rb +++ b/activerecord/test/cases/arel/nodes/binary_test.rb @@ -1,22 +1,23 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes - describe 'Binary' do - describe '#hash' do - it 'generates a hash based on its value' do - eq = Equality.new('foo', 'bar') - eq2 = Equality.new('foo', 'bar') - eq3 = Equality.new('bar', 'baz') + describe "Binary" do + describe "#hash" do + it "generates a hash based on its value" do + eq = Equality.new("foo", "bar") + eq2 = Equality.new("foo", "bar") + eq3 = Equality.new("bar", "baz") assert_equal eq.hash, eq2.hash refute_equal eq.hash, eq3.hash end - it 'generates a hash specific to its class' do - eq = Equality.new('foo', 'bar') - neq = NotEqual.new('foo', 'bar') + it "generates a hash specific to its class" do + eq = Equality.new("foo", "bar") + neq = NotEqual.new("foo", "bar") refute_equal eq.hash, neq.hash end diff --git a/activerecord/test/cases/arel/nodes/bind_param_test.rb b/activerecord/test/cases/arel/nodes/bind_param_test.rb index 665581edce..37a362ece4 100644 --- a/activerecord/test/cases/arel/nodes/bind_param_test.rb +++ b/activerecord/test/cases/arel/nodes/bind_param_test.rb @@ -1,19 +1,20 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes - describe 'BindParam' do - it 'is equal to other bind params with the same value' do + describe "BindParam" do + it "is equal to other bind params with the same value" do BindParam.new(1).must_equal(BindParam.new(1)) BindParam.new("foo").must_equal(BindParam.new("foo")) end - it 'is not equal to other nodes' do + it "is not equal to other nodes" do BindParam.new(nil).wont_equal(Node.new) end - it 'is not equal to bind params with different values' do + it "is not equal to bind params with different values" do BindParam.new(1).wont_equal(BindParam.new(2)) end end diff --git a/activerecord/test/cases/arel/nodes/case_test.rb b/activerecord/test/cases/arel/nodes/case_test.rb index 70364fe6ab..2c087e624e 100644 --- a/activerecord/test/cases/arel/nodes/case_test.rb +++ b/activerecord/test/cases/arel/nodes/case_test.rb @@ -1,26 +1,27 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes - describe 'Case' do - describe '#initialize' do - it 'sets case expression from first argument' do - node = Case.new 'foo' + describe "Case" do + describe "#initialize" do + it "sets case expression from first argument" do + node = Case.new "foo" - assert_equal 'foo', node.case + assert_equal "foo", node.case end - it 'sets default case from second argument' do - node = Case.new nil, 'bar' + it "sets default case from second argument" do + node = Case.new nil, "bar" - assert_equal 'bar', node.default + assert_equal "bar", node.default end end - describe '#clone' do - it 'clones case, conditions and default' do - foo = Nodes.build_quoted 'foo' + describe "#clone" do + it "clones case, conditions and default" do + foo = Nodes.build_quoted "foo" node = Case.new node.case = foo @@ -40,9 +41,9 @@ module Arel end end - describe 'equality' do - it 'is equal with equal ivars' do - foo = Nodes.build_quoted 'foo' + describe "equality" do + it "is equal with equal ivars" do + foo = Nodes.build_quoted "foo" one = Nodes.build_quoted 1 zero = Nodes.build_quoted 0 @@ -59,9 +60,9 @@ module Arel assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do - foo = Nodes.build_quoted 'foo' - bar = Nodes.build_quoted 'bar' + it "is not equal with different ivars" do + foo = Nodes.build_quoted "foo" + bar = Nodes.build_quoted "bar" one = Nodes.build_quoted 1 zero = Nodes.build_quoted 0 diff --git a/activerecord/test/cases/arel/nodes/casted_test.rb b/activerecord/test/cases/arel/nodes/casted_test.rb index a6e2dd2294..e27f58a4e2 100644 --- a/activerecord/test/cases/arel/nodes/casted_test.rb +++ b/activerecord/test/cases/arel/nodes/casted_test.rb @@ -1,11 +1,12 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes describe Casted do - describe '#hash' do - it 'is equal when eql? returns true' do + describe "#hash" do + it "is equal when eql? returns true" do one = Casted.new 1, 2 also_one = Casted.new 1, 2 diff --git a/activerecord/test/cases/arel/nodes/count_test.rb b/activerecord/test/cases/arel/nodes/count_test.rb index 28d8481993..3107659e77 100644 --- a/activerecord/test/cases/arel/nodes/count_test.rb +++ b/activerecord/test/cases/arel/nodes/count_test.rb @@ -1,11 +1,12 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" class Arel::Nodes::CountTest < Arel::Spec describe "as" do - it 'should alias the count' do + it "should alias the count" do table = Arel::Table.new :users - table[:id].count.as('foo').to_sql.must_be_like %{ + table[:id].count.as("foo").to_sql.must_be_like %{ COUNT("users"."id") AS foo } end @@ -20,20 +21,20 @@ class Arel::Nodes::CountTest < Arel::Spec end end - describe 'equality' do - it 'is equal with equal ivars' do - array = [Arel::Nodes::Count.new('foo'), Arel::Nodes::Count.new('foo')] + describe "equality" do + it "is equal with equal ivars" do + array = [Arel::Nodes::Count.new("foo"), Arel::Nodes::Count.new("foo")] assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do - array = [Arel::Nodes::Count.new('foo'), Arel::Nodes::Count.new('foo!')] + it "is not equal with different ivars" do + array = [Arel::Nodes::Count.new("foo"), Arel::Nodes::Count.new("foo!")] assert_equal 2, array.uniq.size end end - describe 'math' do - it 'allows mathematical functions' do + describe "math" do + it "allows mathematical functions" do table = Arel::Table.new :users (table[:id].count + 1).to_sql.must_be_like %{ (COUNT("users"."id") + 1) diff --git a/activerecord/test/cases/arel/nodes/delete_statement_test.rb b/activerecord/test/cases/arel/nodes/delete_statement_test.rb index ada8964646..3f078063a4 100644 --- a/activerecord/test/cases/arel/nodes/delete_statement_test.rb +++ b/activerecord/test/cases/arel/nodes/delete_statement_test.rb @@ -1,5 +1,6 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" describe Arel::Nodes::DeleteStatement do describe "#clone" do @@ -13,8 +14,8 @@ describe Arel::Nodes::DeleteStatement do end end - describe 'equality' do - it 'is equal with equal ivars' do + describe "equality" do + it "is equal with equal ivars" do statement1 = Arel::Nodes::DeleteStatement.new statement1.wheres = %w[a b c] statement2 = Arel::Nodes::DeleteStatement.new @@ -23,7 +24,7 @@ describe Arel::Nodes::DeleteStatement do assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do + it "is not equal with different ivars" do statement1 = Arel::Nodes::DeleteStatement.new statement1.wheres = %w[a b c] statement2 = Arel::Nodes::DeleteStatement.new diff --git a/activerecord/test/cases/arel/nodes/descending_test.rb b/activerecord/test/cases/arel/nodes/descending_test.rb index 5fe0ba62b0..45e22de17b 100644 --- a/activerecord/test/cases/arel/nodes/descending_test.rb +++ b/activerecord/test/cases/arel/nodes/descending_test.rb @@ -1,43 +1,44 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes class TestDescending < Arel::Test def test_construct - descending = Descending.new 'zomg' - assert_equal 'zomg', descending.expr + descending = Descending.new "zomg" + assert_equal "zomg", descending.expr end def test_reverse - descending = Descending.new 'zomg' + descending = Descending.new "zomg" ascending = descending.reverse assert_kind_of Ascending, ascending assert_equal descending.expr, ascending.expr end def test_direction - descending = Descending.new 'zomg' + descending = Descending.new "zomg" assert_equal :desc, descending.direction end def test_ascending? - descending = Descending.new 'zomg' + descending = Descending.new "zomg" assert !descending.ascending? end def test_descending? - descending = Descending.new 'zomg' + descending = Descending.new "zomg" assert descending.descending? end def test_equality_with_same_ivars - array = [Descending.new('zomg'), Descending.new('zomg')] + array = [Descending.new("zomg"), Descending.new("zomg")] assert_equal 1, array.uniq.size end def test_inequality_with_different_ivars - array = [Descending.new('zomg'), Descending.new('zomg!')] + array = [Descending.new("zomg"), Descending.new("zomg!")] assert_equal 2, array.uniq.size end end diff --git a/activerecord/test/cases/arel/nodes/distinct_test.rb b/activerecord/test/cases/arel/nodes/distinct_test.rb index 465700118e..de5f0ee588 100644 --- a/activerecord/test/cases/arel/nodes/distinct_test.rb +++ b/activerecord/test/cases/arel/nodes/distinct_test.rb @@ -1,16 +1,17 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes - describe 'Distinct' do - describe 'equality' do - it 'is equal to other distinct nodes' do + describe "Distinct" do + describe "equality" do + it "is equal to other distinct nodes" do array = [Distinct.new, Distinct.new] assert_equal 1, array.uniq.size end - it 'is not equal with other nodes' do + it "is not equal with other nodes" do array = [Distinct.new, Node.new] assert_equal 2, array.uniq.size end @@ -18,4 +19,3 @@ module Arel end end end - diff --git a/activerecord/test/cases/arel/nodes/equality_test.rb b/activerecord/test/cases/arel/nodes/equality_test.rb index 28a74de321..e173720e86 100644 --- a/activerecord/test/cases/arel/nodes/equality_test.rb +++ b/activerecord/test/cases/arel/nodes/equality_test.rb @@ -1,37 +1,38 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes - describe 'equality' do + describe "equality" do # FIXME: backwards compat - describe 'backwards compat' do - describe 'operator' do - it 'returns :==' do + describe "backwards compat" do + describe "operator" do + it "returns :==" do attr = Table.new(:users)[:id] - left = attr.eq(10) + left = attr.eq(10) left.operator.must_equal :== end end - describe 'operand1' do + describe "operand1" do it "should equal left" do attr = Table.new(:users)[:id] - left = attr.eq(10) + left = attr.eq(10) left.left.must_equal left.operand1 end end - describe 'operand2' do + describe "operand2" do it "should equal right" do attr = Table.new(:users)[:id] - left = attr.eq(10) + left = attr.eq(10) left.right.must_equal left.operand2 end end - describe 'to_sql' do - it 'takes an engine' do + describe "to_sql" do + it "takes an engine" do engine = FakeRecord::Base.new engine.connection.extend Module.new { attr_accessor :quote_count @@ -49,8 +50,8 @@ module Arel end end - describe 'or' do - it 'makes an OR node' do + describe "or" do + it "makes an OR node" do attr = Table.new(:users)[:id] left = attr.eq(10) right = attr.eq(11) @@ -60,8 +61,8 @@ module Arel end end - describe 'and' do - it 'makes and AND node' do + describe "and" do + it "makes and AND node" do attr = Table.new(:users)[:id] left = attr.eq(10) right = attr.eq(11) @@ -71,13 +72,13 @@ module Arel end end - it 'is equal with equal ivars' do - array = [Equality.new('foo', 'bar'), Equality.new('foo', 'bar')] + it "is equal with equal ivars" do + array = [Equality.new("foo", "bar"), Equality.new("foo", "bar")] assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do - array = [Equality.new('foo', 'bar'), Equality.new('foo', 'baz')] + it "is not equal with different ivars" do + array = [Equality.new("foo", "bar"), Equality.new("foo", "baz")] assert_equal 2, array.uniq.size end end diff --git a/activerecord/test/cases/arel/nodes/extract_test.rb b/activerecord/test/cases/arel/nodes/extract_test.rb index f6dc1626a4..8fc1e04d67 100644 --- a/activerecord/test/cases/arel/nodes/extract_test.rb +++ b/activerecord/test/cases/arel/nodes/extract_test.rb @@ -1,41 +1,42 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" class Arel::Nodes::ExtractTest < Arel::Spec it "should extract field" do table = Arel::Table.new :users - table[:timestamp].extract('date').to_sql.must_be_like %{ + table[:timestamp].extract("date").to_sql.must_be_like %{ EXTRACT(DATE FROM "users"."timestamp") } end describe "as" do - it 'should alias the extract' do + it "should alias the extract" do table = Arel::Table.new :users - table[:timestamp].extract('date').as('foo').to_sql.must_be_like %{ + table[:timestamp].extract("date").as("foo").to_sql.must_be_like %{ EXTRACT(DATE FROM "users"."timestamp") AS foo } end - it 'should not mutate the extract' do + it "should not mutate the extract" do table = Arel::Table.new :users - extract = table[:timestamp].extract('date') + extract = table[:timestamp].extract("date") before = extract.dup - extract.as('foo') + extract.as("foo") assert_equal extract, before end end - describe 'equality' do - it 'is equal with equal ivars' do + describe "equality" do + it "is equal with equal ivars" do table = Arel::Table.new :users - array = [table[:attr].extract('foo'), table[:attr].extract('foo')] + array = [table[:attr].extract("foo"), table[:attr].extract("foo")] assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do + it "is not equal with different ivars" do table = Arel::Table.new :users - array = [table[:attr].extract('foo'), table[:attr].extract('bar')] + array = [table[:attr].extract("foo"), table[:attr].extract("bar")] assert_equal 2, array.uniq.size end end diff --git a/activerecord/test/cases/arel/nodes/false_test.rb b/activerecord/test/cases/arel/nodes/false_test.rb index 8b91dc227c..4ecf8e332e 100644 --- a/activerecord/test/cases/arel/nodes/false_test.rb +++ b/activerecord/test/cases/arel/nodes/false_test.rb @@ -1,16 +1,17 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes - describe 'False' do - describe 'equality' do - it 'is equal to other false nodes' do + describe "False" do + describe "equality" do + it "is equal to other false nodes" do array = [False.new, False.new] assert_equal 1, array.uniq.size end - it 'is not equal with other nodes' do + it "is not equal with other nodes" do array = [False.new, Node.new] assert_equal 2, array.uniq.size end @@ -18,4 +19,3 @@ module Arel end end end - diff --git a/activerecord/test/cases/arel/nodes/grouping_test.rb b/activerecord/test/cases/arel/nodes/grouping_test.rb index 7ad1584f0f..03d5c142d5 100644 --- a/activerecord/test/cases/arel/nodes/grouping_test.rb +++ b/activerecord/test/cases/arel/nodes/grouping_test.rb @@ -1,26 +1,26 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes class GroupingTest < Arel::Spec - it 'should create Equality nodes' do - grouping = Grouping.new(Nodes.build_quoted('foo')) - grouping.eq('foo').to_sql.must_be_like %q{('foo') = 'foo'} + it "should create Equality nodes" do + grouping = Grouping.new(Nodes.build_quoted("foo")) + grouping.eq("foo").to_sql.must_be_like "('foo') = 'foo'" end - describe 'equality' do - it 'is equal with equal ivars' do - array = [Grouping.new('foo'), Grouping.new('foo')] + describe "equality" do + it "is equal with equal ivars" do + array = [Grouping.new("foo"), Grouping.new("foo")] assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do - array = [Grouping.new('foo'), Grouping.new('bar')] + it "is not equal with different ivars" do + array = [Grouping.new("foo"), Grouping.new("bar")] assert_equal 2, array.uniq.size end end end end end - diff --git a/activerecord/test/cases/arel/nodes/infix_operation_test.rb b/activerecord/test/cases/arel/nodes/infix_operation_test.rb index 28a4710dc0..dcf2200c12 100644 --- a/activerecord/test/cases/arel/nodes/infix_operation_test.rb +++ b/activerecord/test/cases/arel/nodes/infix_operation_test.rb @@ -1,5 +1,6 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes @@ -13,10 +14,10 @@ module Arel def test_operation_alias operation = InfixOperation.new :+, 1, 2 - aliaz = operation.as('zomg') + aliaz = operation.as("zomg") assert_kind_of As, aliaz assert_equal operation, aliaz.left - assert_equal 'zomg', aliaz.right + assert_equal "zomg", aliaz.right end def test_operation_ordering diff --git a/activerecord/test/cases/arel/nodes/insert_statement_test.rb b/activerecord/test/cases/arel/nodes/insert_statement_test.rb index 87f9d83a32..252a0d0d0b 100644 --- a/activerecord/test/cases/arel/nodes/insert_statement_test.rb +++ b/activerecord/test/cases/arel/nodes/insert_statement_test.rb @@ -1,5 +1,6 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" describe Arel::Nodes::InsertStatement do describe "#clone" do @@ -17,8 +18,8 @@ describe Arel::Nodes::InsertStatement do end end - describe 'equality' do - it 'is equal with equal ivars' do + describe "equality" do + it "is equal with equal ivars" do statement1 = Arel::Nodes::InsertStatement.new statement1.columns = %w[a b c] statement1.values = %w[x y z] @@ -29,7 +30,7 @@ describe Arel::Nodes::InsertStatement do assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do + it "is not equal with different ivars" do statement1 = Arel::Nodes::InsertStatement.new statement1.columns = %w[a b c] statement1.values = %w[x y z] diff --git a/activerecord/test/cases/arel/nodes/named_function_test.rb b/activerecord/test/cases/arel/nodes/named_function_test.rb index 30f6dac595..dbd7ae43be 100644 --- a/activerecord/test/cases/arel/nodes/named_function_test.rb +++ b/activerecord/test/cases/arel/nodes/named_function_test.rb @@ -1,44 +1,45 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes class TestNamedFunction < Arel::Test def test_construct - function = NamedFunction.new 'omg', 'zomg' - assert_equal 'omg', function.name - assert_equal 'zomg', function.expressions + function = NamedFunction.new "omg", "zomg" + assert_equal "omg", function.name + assert_equal "zomg", function.expressions end def test_function_alias - function = NamedFunction.new 'omg', 'zomg' - function = function.as('wth') - assert_equal 'omg', function.name - assert_equal 'zomg', function.expressions + function = NamedFunction.new "omg", "zomg" + function = function.as("wth") + assert_equal "omg", function.name + assert_equal "zomg", function.expressions assert_kind_of SqlLiteral, function.alias - assert_equal 'wth', function.alias + assert_equal "wth", function.alias end def test_construct_with_alias - function = NamedFunction.new 'omg', 'zomg', 'wth' - assert_equal 'omg', function.name - assert_equal 'zomg', function.expressions + function = NamedFunction.new "omg", "zomg", "wth" + assert_equal "omg", function.name + assert_equal "zomg", function.expressions assert_kind_of SqlLiteral, function.alias - assert_equal 'wth', function.alias + assert_equal "wth", function.alias end def test_equality_with_same_ivars array = [ - NamedFunction.new('omg', 'zomg', 'wth'), - NamedFunction.new('omg', 'zomg', 'wth') + NamedFunction.new("omg", "zomg", "wth"), + NamedFunction.new("omg", "zomg", "wth") ] assert_equal 1, array.uniq.size end def test_inequality_with_different_ivars array = [ - NamedFunction.new('omg', 'zomg', 'wth'), - NamedFunction.new('zomg', 'zomg', 'wth') + NamedFunction.new("omg", "zomg", "wth"), + NamedFunction.new("zomg", "zomg", "wth") ] assert_equal 2, array.uniq.size end diff --git a/activerecord/test/cases/arel/nodes/node_test.rb b/activerecord/test/cases/arel/nodes/node_test.rb index c1d3a01d1c..f4f07ef2c5 100644 --- a/activerecord/test/cases/arel/nodes/node_test.rb +++ b/activerecord/test/cases/arel/nodes/node_test.rb @@ -1,5 +1,6 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel class TestNode < Arel::Test diff --git a/activerecord/test/cases/arel/nodes/not_test.rb b/activerecord/test/cases/arel/nodes/not_test.rb index 15f94a6f10..481e678700 100644 --- a/activerecord/test/cases/arel/nodes/not_test.rb +++ b/activerecord/test/cases/arel/nodes/not_test.rb @@ -1,11 +1,12 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes - describe 'not' do - describe '#not' do - it 'makes a NOT node' do + describe "not" do + describe "#not" do + it "makes a NOT node" do attr = Table.new(:users)[:id] expr = attr.eq(10) node = expr.not @@ -14,14 +15,14 @@ module Arel end end - describe 'equality' do - it 'is equal with equal ivars' do - array = [Not.new('foo'), Not.new('foo')] + describe "equality" do + it "is equal with equal ivars" do + array = [Not.new("foo"), Not.new("foo")] assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do - array = [Not.new('foo'), Not.new('baz')] + it "is not equal with different ivars" do + array = [Not.new("foo"), Not.new("baz")] assert_equal 2, array.uniq.size end end diff --git a/activerecord/test/cases/arel/nodes/or_test.rb b/activerecord/test/cases/arel/nodes/or_test.rb index 4f8d56d165..93f826740d 100644 --- a/activerecord/test/cases/arel/nodes/or_test.rb +++ b/activerecord/test/cases/arel/nodes/or_test.rb @@ -1,11 +1,12 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes - describe 'or' do - describe '#or' do - it 'makes an OR node' do + describe "or" do + describe "#or" do + it "makes an OR node" do attr = Table.new(:users)[:id] left = attr.eq(10) right = attr.eq(11) @@ -19,14 +20,14 @@ module Arel end end - describe 'equality' do - it 'is equal with equal ivars' do - array = [Or.new('foo', 'bar'), Or.new('foo', 'bar')] + describe "equality" do + it "is equal with equal ivars" do + array = [Or.new("foo", "bar"), Or.new("foo", "bar")] assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do - array = [Or.new('foo', 'bar'), Or.new('foo', 'baz')] + it "is not equal with different ivars" do + array = [Or.new("foo", "bar"), Or.new("foo", "baz")] assert_equal 2, array.uniq.size end end diff --git a/activerecord/test/cases/arel/nodes/over_test.rb b/activerecord/test/cases/arel/nodes/over_test.rb index c9804c395f..981ec2e34b 100644 --- a/activerecord/test/cases/arel/nodes/over_test.rb +++ b/activerecord/test/cases/arel/nodes/over_test.rb @@ -1,36 +1,37 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" class Arel::Nodes::OverTest < Arel::Spec - describe 'as' do - it 'should alias the expression' do + describe "as" do + it "should alias the expression" do table = Arel::Table.new :users - table[:id].count.over.as('foo').to_sql.must_be_like %{ + table[:id].count.over.as("foo").to_sql.must_be_like %{ COUNT("users"."id") OVER () AS foo } end end - describe 'with literal' do - it 'should reference the window definition by name' do + describe "with literal" do + it "should reference the window definition by name" do table = Arel::Table.new :users - table[:id].count.over('foo').to_sql.must_be_like %{ + table[:id].count.over("foo").to_sql.must_be_like %{ COUNT("users"."id") OVER "foo" } end end - describe 'with SQL literal' do - it 'should reference the window definition by name' do + describe "with SQL literal" do + it "should reference the window definition by name" do table = Arel::Table.new :users - table[:id].count.over(Arel.sql('foo')).to_sql.must_be_like %{ + table[:id].count.over(Arel.sql("foo")).to_sql.must_be_like %{ COUNT("users"."id") OVER foo } end end - describe 'with no expression' do - it 'should use empty definition' do + describe "with no expression" do + it "should use empty definition" do table = Arel::Table.new :users table[:id].count.over.to_sql.must_be_like %{ COUNT("users"."id") OVER () @@ -38,29 +39,29 @@ class Arel::Nodes::OverTest < Arel::Spec end end - describe 'with expression' do - it 'should use definition in sub-expression' do + describe "with expression" do + it "should use definition in sub-expression" do table = Arel::Table.new :users - window = Arel::Nodes::Window.new.order(table['foo']) + window = Arel::Nodes::Window.new.order(table["foo"]) table[:id].count.over(window).to_sql.must_be_like %{ COUNT("users"."id") OVER (ORDER BY \"users\".\"foo\") } end end - describe 'equality' do - it 'is equal with equal ivars' do + describe "equality" do + it "is equal with equal ivars" do array = [ - Arel::Nodes::Over.new('foo', 'bar'), - Arel::Nodes::Over.new('foo', 'bar') + Arel::Nodes::Over.new("foo", "bar"), + Arel::Nodes::Over.new("foo", "bar") ] assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do + it "is not equal with different ivars" do array = [ - Arel::Nodes::Over.new('foo', 'bar'), - Arel::Nodes::Over.new('foo', 'baz') + Arel::Nodes::Over.new("foo", "bar"), + Arel::Nodes::Over.new("foo", "baz") ] assert_equal 2, array.uniq.size end diff --git a/activerecord/test/cases/arel/nodes/select_core_test.rb b/activerecord/test/cases/arel/nodes/select_core_test.rb index bbb06666b6..1cdc7a2360 100644 --- a/activerecord/test/cases/arel/nodes/select_core_test.rb +++ b/activerecord/test/cases/arel/nodes/select_core_test.rb @@ -1,5 +1,6 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes @@ -25,7 +26,7 @@ module Arel core = Arel::Nodes::SelectCore.new core.set_quantifier = Arel::Nodes::Distinct.new viz = Arel::Visitors::ToSql.new Table.engine.connection_pool - assert_match 'DISTINCT', viz.accept(core, Collectors::SQLString.new).value + assert_match "DISTINCT", viz.accept(core, Collectors::SQLString.new).value end def test_equality_with_same_ivars diff --git a/activerecord/test/cases/arel/nodes/select_statement_test.rb b/activerecord/test/cases/arel/nodes/select_statement_test.rb index 5e313e03fa..a91605de3e 100644 --- a/activerecord/test/cases/arel/nodes/select_statement_test.rb +++ b/activerecord/test/cases/arel/nodes/select_statement_test.rb @@ -1,5 +1,6 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" describe Arel::Nodes::SelectStatement do describe "#clone" do @@ -12,37 +13,37 @@ describe Arel::Nodes::SelectStatement do end end - describe 'equality' do - it 'is equal with equal ivars' do + describe "equality" do + it "is equal with equal ivars" do statement1 = Arel::Nodes::SelectStatement.new %w[a b c] statement1.offset = 1 statement1.limit = 2 statement1.lock = false statement1.orders = %w[x y z] - statement1.with = 'zomg' + statement1.with = "zomg" statement2 = Arel::Nodes::SelectStatement.new %w[a b c] statement2.offset = 1 statement2.limit = 2 statement2.lock = false statement2.orders = %w[x y z] - statement2.with = 'zomg' + statement2.with = "zomg" array = [statement1, statement2] assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do + it "is not equal with different ivars" do statement1 = Arel::Nodes::SelectStatement.new %w[a b c] statement1.offset = 1 statement1.limit = 2 statement1.lock = false statement1.orders = %w[x y z] - statement1.with = 'zomg' + statement1.with = "zomg" statement2 = Arel::Nodes::SelectStatement.new %w[a b c] statement2.offset = 1 statement2.limit = 2 statement2.lock = false statement2.orders = %w[x y z] - statement2.with = 'wth' + statement2.with = "wth" array = [statement1, statement2] assert_equal 2, array.uniq.size end diff --git a/activerecord/test/cases/arel/nodes/sql_literal_test.rb b/activerecord/test/cases/arel/nodes/sql_literal_test.rb index 0c4f23be78..3b95fed1f4 100644 --- a/activerecord/test/cases/arel/nodes/sql_literal_test.rb +++ b/activerecord/test/cases/arel/nodes/sql_literal_test.rb @@ -1,6 +1,7 @@ # frozen_string_literal: true -require_relative '../helper' -require 'yaml' + +require_relative "../helper" +require "yaml" module Arel module Nodes @@ -9,64 +10,64 @@ module Arel @visitor = Visitors::ToSql.new Table.engine.connection end - def compile node + def compile(node) @visitor.accept(node, Collectors::SQLString.new).value end - describe 'sql' do - it 'makes a sql literal node' do - sql = Arel.sql 'foo' + describe "sql" do + it "makes a sql literal node" do + sql = Arel.sql "foo" sql.must_be_kind_of Arel::Nodes::SqlLiteral end end - describe 'count' do - it 'makes a count node' do - node = SqlLiteral.new('*').count + describe "count" do + it "makes a count node" do + node = SqlLiteral.new("*").count compile(node).must_be_like %{ COUNT(*) } end - it 'makes a distinct node' do - node = SqlLiteral.new('*').count true + it "makes a distinct node" do + node = SqlLiteral.new("*").count true compile(node).must_be_like %{ COUNT(DISTINCT *) } end end - describe 'equality' do - it 'makes an equality node' do - node = SqlLiteral.new('foo').eq(1) + describe "equality" do + it "makes an equality node" do + node = SqlLiteral.new("foo").eq(1) compile(node).must_be_like %{ foo = 1 } end - it 'is equal with equal contents' do - array = [SqlLiteral.new('foo'), SqlLiteral.new('foo')] + it "is equal with equal contents" do + array = [SqlLiteral.new("foo"), SqlLiteral.new("foo")] assert_equal 1, array.uniq.size end - it 'is not equal with different contents' do - array = [SqlLiteral.new('foo'), SqlLiteral.new('bar')] + it "is not equal with different contents" do + array = [SqlLiteral.new("foo"), SqlLiteral.new("bar")] assert_equal 2, array.uniq.size end end describe 'grouped "or" equality' do - it 'makes a grouping node with an or node' do - node = SqlLiteral.new('foo').eq_any([1,2]) + it "makes a grouping node with an or node" do + node = SqlLiteral.new("foo").eq_any([1, 2]) compile(node).must_be_like %{ (foo = 1 OR foo = 2) } end end describe 'grouped "and" equality' do - it 'makes a grouping node with an and node' do - node = SqlLiteral.new('foo').eq_all([1,2]) + it "makes a grouping node with an and node" do + node = SqlLiteral.new("foo").eq_all([1, 2]) compile(node).must_be_like %{ (foo = 1 AND foo = 2) } end end - describe 'serialization' do - it 'serializes into YAML' do - yaml_literal = SqlLiteral.new('foo').to_yaml - assert_equal('foo', YAML.load(yaml_literal)) + describe "serialization" do + it "serializes into YAML" do + yaml_literal = SqlLiteral.new("foo").to_yaml + assert_equal("foo", YAML.load(yaml_literal)) end end end diff --git a/activerecord/test/cases/arel/nodes/sum_test.rb b/activerecord/test/cases/arel/nodes/sum_test.rb index 46c908d872..5015964951 100644 --- a/activerecord/test/cases/arel/nodes/sum_test.rb +++ b/activerecord/test/cases/arel/nodes/sum_test.rb @@ -1,30 +1,31 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" class Arel::Nodes::SumTest < Arel::Spec describe "as" do - it 'should alias the sum' do + it "should alias the sum" do table = Arel::Table.new :users - table[:id].sum.as('foo').to_sql.must_be_like %{ + table[:id].sum.as("foo").to_sql.must_be_like %{ SUM("users"."id") AS foo } end end - describe 'equality' do - it 'is equal with equal ivars' do - array = [Arel::Nodes::Sum.new('foo'), Arel::Nodes::Sum.new('foo')] + describe "equality" do + it "is equal with equal ivars" do + array = [Arel::Nodes::Sum.new("foo"), Arel::Nodes::Sum.new("foo")] assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do - array = [Arel::Nodes::Sum.new('foo'), Arel::Nodes::Sum.new('foo!')] + it "is not equal with different ivars" do + array = [Arel::Nodes::Sum.new("foo"), Arel::Nodes::Sum.new("foo!")] assert_equal 2, array.uniq.size end end - - describe 'order' do - it 'should order the sum' do + + describe "order" do + it "should order the sum" do table = Arel::Table.new :users table[:id].sum.desc.to_sql.must_be_like %{ SUM("users"."id") DESC diff --git a/activerecord/test/cases/arel/nodes/table_alias_test.rb b/activerecord/test/cases/arel/nodes/table_alias_test.rb index b1b49919d5..c661b6771e 100644 --- a/activerecord/test/cases/arel/nodes/table_alias_test.rb +++ b/activerecord/test/cases/arel/nodes/table_alias_test.rb @@ -1,11 +1,12 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes - describe 'table alias' do - describe 'equality' do - it 'is equal with equal ivars' do + describe "table alias" do + describe "equality" do + it "is equal with equal ivars" do relation1 = Table.new(:users) node1 = TableAlias.new relation1, :foo relation2 = Table.new(:users) @@ -14,7 +15,7 @@ module Arel assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do + it "is not equal with different ivars" do relation1 = Table.new(:users) node1 = TableAlias.new relation1, :foo relation2 = Table.new(:users) diff --git a/activerecord/test/cases/arel/nodes/true_test.rb b/activerecord/test/cases/arel/nodes/true_test.rb index 198e7b1aa4..1e85fe7d48 100644 --- a/activerecord/test/cases/arel/nodes/true_test.rb +++ b/activerecord/test/cases/arel/nodes/true_test.rb @@ -1,16 +1,17 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes - describe 'True' do - describe 'equality' do - it 'is equal to other true nodes' do + describe "True" do + describe "equality" do + it "is equal to other true nodes" do array = [True.new, True.new] assert_equal 1, array.uniq.size end - it 'is not equal with other nodes' do + it "is not equal with other nodes" do array = [True.new, Node.new] assert_equal 2, array.uniq.size end @@ -18,5 +19,3 @@ module Arel end end end - - diff --git a/activerecord/test/cases/arel/nodes/unary_operation_test.rb b/activerecord/test/cases/arel/nodes/unary_operation_test.rb index e76b59c8e1..f0dd0c625c 100644 --- a/activerecord/test/cases/arel/nodes/unary_operation_test.rb +++ b/activerecord/test/cases/arel/nodes/unary_operation_test.rb @@ -1,5 +1,6 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes @@ -12,10 +13,10 @@ module Arel def test_operation_alias operation = UnaryOperation.new :-, 1 - aliaz = operation.as('zomg') + aliaz = operation.as("zomg") assert_kind_of As, aliaz assert_equal operation, aliaz.left - assert_equal 'zomg', aliaz.right + assert_equal "zomg", aliaz.right end def test_operation_ordering diff --git a/activerecord/test/cases/arel/nodes/update_statement_test.rb b/activerecord/test/cases/arel/nodes/update_statement_test.rb index 3a635f75d6..a83ce32f68 100644 --- a/activerecord/test/cases/arel/nodes/update_statement_test.rb +++ b/activerecord/test/cases/arel/nodes/update_statement_test.rb @@ -1,5 +1,6 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" describe Arel::Nodes::UpdateStatement do describe "#clone" do @@ -17,41 +18,41 @@ describe Arel::Nodes::UpdateStatement do end end - describe 'equality' do - it 'is equal with equal ivars' do + describe "equality" do + it "is equal with equal ivars" do statement1 = Arel::Nodes::UpdateStatement.new - statement1.relation = 'zomg' + statement1.relation = "zomg" statement1.wheres = 2 statement1.values = false statement1.orders = %w[x y z] statement1.limit = 42 - statement1.key = 'zomg' + statement1.key = "zomg" statement2 = Arel::Nodes::UpdateStatement.new - statement2.relation = 'zomg' + statement2.relation = "zomg" statement2.wheres = 2 statement2.values = false statement2.orders = %w[x y z] statement2.limit = 42 - statement2.key = 'zomg' + statement2.key = "zomg" array = [statement1, statement2] assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do + it "is not equal with different ivars" do statement1 = Arel::Nodes::UpdateStatement.new - statement1.relation = 'zomg' + statement1.relation = "zomg" statement1.wheres = 2 statement1.values = false statement1.orders = %w[x y z] statement1.limit = 42 - statement1.key = 'zomg' + statement1.key = "zomg" statement2 = Arel::Nodes::UpdateStatement.new - statement2.relation = 'zomg' + statement2.relation = "zomg" statement2.wheres = 2 statement2.values = false statement2.orders = %w[x y z] statement2.limit = 42 - statement2.key = 'wth' + statement2.key = "wth" array = [statement1, statement2] assert_equal 2, array.uniq.size end diff --git a/activerecord/test/cases/arel/nodes/window_test.rb b/activerecord/test/cases/arel/nodes/window_test.rb index 81ecd5ced8..729b0556a4 100644 --- a/activerecord/test/cases/arel/nodes/window_test.rb +++ b/activerecord/test/cases/arel/nodes/window_test.rb @@ -1,11 +1,12 @@ # frozen_string_literal: true -require_relative '../helper' + +require_relative "../helper" module Arel module Nodes - describe 'Window' do - describe 'equality' do - it 'is equal with equal ivars' do + describe "Window" do + describe "equality" do + it "is equal with equal ivars" do window1 = Window.new window1.orders = [1, 2] window1.partitions = [1] @@ -18,7 +19,7 @@ module Arel assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do + it "is not equal with different ivars" do window1 = Window.new window1.orders = [1, 2] window1.partitions = [1] @@ -33,14 +34,14 @@ module Arel end end - describe 'NamedWindow' do - describe 'equality' do - it 'is equal with equal ivars' do - window1 = NamedWindow.new 'foo' + describe "NamedWindow" do + describe "equality" do + it "is equal with equal ivars" do + window1 = NamedWindow.new "foo" window1.orders = [1, 2] window1.partitions = [1] window1.frame 3 - window2 = NamedWindow.new 'foo' + window2 = NamedWindow.new "foo" window2.orders = [1, 2] window2.partitions = [1] window2.frame 3 @@ -48,12 +49,12 @@ module Arel assert_equal 1, array.uniq.size end - it 'is not equal with different ivars' do - window1 = NamedWindow.new 'foo' + it "is not equal with different ivars" do + window1 = NamedWindow.new "foo" window1.orders = [1, 2] window1.partitions = [1] window1.frame 3 - window2 = NamedWindow.new 'bar' + window2 = NamedWindow.new "bar" window2.orders = [1, 2] window2.partitions = [1] window2.frame 3 @@ -63,14 +64,14 @@ module Arel end end - describe 'CurrentRow' do - describe 'equality' do - it 'is equal to other current row nodes' do + describe "CurrentRow" do + describe "equality" do + it "is equal to other current row nodes" do array = [CurrentRow.new, CurrentRow.new] assert_equal 1, array.uniq.size end - it 'is not equal with other nodes' do + it "is not equal with other nodes" do array = [CurrentRow.new, Node.new] assert_equal 2, array.uniq.size end |