diff options
Diffstat (limited to 'activemodel/lib/active_model/mass_assignment_security')
| -rw-r--r-- | activemodel/lib/active_model/mass_assignment_security/permission_set.rb | 8 | ||||
| -rw-r--r-- | activemodel/lib/active_model/mass_assignment_security/sanitizer.rb | 43 | 
2 files changed, 41 insertions, 10 deletions
diff --git a/activemodel/lib/active_model/mass_assignment_security/permission_set.rb b/activemodel/lib/active_model/mass_assignment_security/permission_set.rb index 9fcb94d48a..a1fcdf1a38 100644 --- a/activemodel/lib/active_model/mass_assignment_security/permission_set.rb +++ b/activemodel/lib/active_model/mass_assignment_security/permission_set.rb @@ -1,10 +1,8 @@  require 'set' -require 'active_model/mass_assignment_security/sanitizer'  module ActiveModel    module MassAssignmentSecurity      class PermissionSet < Set -      attr_accessor :logger        def +(values)          super(values.map(&:to_s)) @@ -14,6 +12,10 @@ module ActiveModel          super(remove_multiparameter_id(key))        end +      def deny?(key) +        raise NotImplementedError, "#deny?(key) suppose to be overwritten" +      end +      protected        def remove_multiparameter_id(key) @@ -22,7 +24,6 @@ module ActiveModel      end      class WhiteList < PermissionSet -      include Sanitizer        def deny?(key)          !include?(key) @@ -30,7 +31,6 @@ module ActiveModel      end      class BlackList < PermissionSet -      include Sanitizer        def deny?(key)          include?(key) diff --git a/activemodel/lib/active_model/mass_assignment_security/sanitizer.rb b/activemodel/lib/active_model/mass_assignment_security/sanitizer.rb index 150beb1ff2..bb0526adc3 100644 --- a/activemodel/lib/active_model/mass_assignment_security/sanitizer.rb +++ b/activemodel/lib/active_model/mass_assignment_security/sanitizer.rb @@ -1,9 +1,14 @@ +require 'active_support/core_ext/module/delegation' +  module ActiveModel    module MassAssignmentSecurity -    module Sanitizer +    class Sanitizer +      def initialize(target=nil) +      end +        # Returns all attributes not denied by the authorizer. -      def sanitize(attributes) -        sanitized_attributes = attributes.reject { |key, value| deny?(key) } +      def sanitize(attributes, authorizer) +        sanitized_attributes = attributes.reject { |key, value| authorizer.deny?(key) }          debug_protected_attribute_removal(attributes, sanitized_attributes)          sanitized_attributes        end @@ -12,12 +17,38 @@ module ActiveModel        def debug_protected_attribute_removal(attributes, sanitized_attributes)          removed_keys = attributes.keys - sanitized_attributes.keys -        warn!(removed_keys) if removed_keys.any? +        process_removed_attributes(removed_keys) if removed_keys.any? +      end + +      def process_removed_attributes(attrs) +        raise NotImplementedError, "#process_removed_attributes(attrs) suppose to be overwritten" +      end +    end + +    class LoggerSanitizer < Sanitizer +      delegate :logger, :to => :@target + +      def initialize(target) +        @target = target +        super +      end + +      def logger? +        @target.respond_to?(:logger) && @target.logger +      end + +      def process_removed_attributes(attrs) +        logger.debug "WARNING: Can't mass-assign protected attributes: #{attrs.join(', ')}" if logger?        end +    end -      def warn!(attrs) -        self.logger.debug "WARNING: Can't mass-assign protected attributes: #{attrs.join(', ')}" if self.logger +    class StrictSanitizer < Sanitizer +      def process_removed_attributes(attrs) +        raise ActiveModel::MassAssignmentSecurity::Error, "Can't mass-assign protected attributes: #{attrs.join(', ')}"        end      end + +    class Error < StandardError +    end    end  end  | 
