1 files changed, 79 insertions, 50 deletions

diff --git a/actionpack/test/dispatch/routing/inspector_test.rb b/actionpack/test/dispatch/routing/inspector_test.rb
index f72a87b994..a4babf8554 100644
--- a/actionpack/test/dispatch/routing/inspector_test.rb
+++ b/actionpack/test/dispatch/routing/inspector_test.rb
@@ -1,6 +1,6 @@
-require 'abstract_unit'
-require 'rails/engine'
-require 'action_dispatch/routing/inspector'
+require "abstract_unit"
+require "rails/engine"
+require "action_dispatch/routing/inspector"
 
 class MountedRackApp
   def self.call(env)
@@ -30,11 +30,11 @@ module ActionDispatch
           end
         end
         engine.routes.draw do
-          get '/cart', :to => 'cart#show'
+          get "/cart", to: "cart#show"
         end
 
         output = draw do
-          get '/custom/assets', :to => 'custom_assets#show'
+          get "/custom/assets", to: "custom_assets#show"
           mount engine => "/blog", :as => "blog"
         end
 
@@ -71,7 +71,7 @@ module ActionDispatch
 
       def test_cart_inspect
         output = draw do
-          get '/cart', :to => 'cart#show'
+          get "/cart", to: "cart#show"
         end
 
         assert_equal [
@@ -82,7 +82,7 @@ module ActionDispatch
 
       def test_articles_inspect_with_multiple_verbs
         output = draw do
-          match 'articles/:id', to: 'articles#update', via: [:put, :patch]
+          match "articles/:id", to: "articles#update", via: [:put, :patch]
         end
 
         assert_equal [
@@ -93,7 +93,7 @@ module ActionDispatch
 
       def test_inspect_shows_custom_assets
         output = draw do
-          get '/custom/assets', :to => 'custom_assets#show'
+          get "/custom/assets", to: "custom_assets#show"
         end
 
         assert_equal [
@@ -122,7 +122,7 @@ module ActionDispatch
 
       def test_inspect_routes_shows_root_route
         output = draw do
-          root :to => 'pages#main'
+          root to: "pages#main"
         end
 
         assert_equal [
@@ -133,7 +133,9 @@ module ActionDispatch
 
       def test_inspect_routes_shows_dynamic_action_route
         output = draw do
-          get 'api/:action' => 'api'
+          ActiveSupport::Deprecation.silence do
+            get "api/:action" => "api"
+          end
         end
 
         assert_equal [
@@ -144,7 +146,9 @@ module ActionDispatch
 
       def test_inspect_routes_shows_controller_and_action_only_route
         output = draw do
-          get ':controller/:action'
+          ActiveSupport::Deprecation.silence do
+            get ":controller/:action"
+          end
         end
 
         assert_equal [
@@ -155,7 +159,9 @@ module ActionDispatch
 
       def test_inspect_routes_shows_controller_and_action_route_with_constraints
         output = draw do
-          get ':controller(/:action(/:id))', :id => /\d+/
+          ActiveSupport::Deprecation.silence do
+            get ":controller(/:action(/:id))", id: /\d+/
+          end
         end
 
         assert_equal [
@@ -164,20 +170,20 @@ module ActionDispatch
         ], output
       end
 
-      def test_rake_routes_shows_route_with_defaults
+      def test_rails_routes_shows_route_with_defaults
         output = draw do
-          get 'photos/:id' => 'photos#show', :defaults => {:format => 'jpg'}
+          get "photos/:id" => "photos#show", :defaults => { format: "jpg" }
         end
 
         assert_equal [
           "Prefix Verb URI Pattern           Controller#Action",
-          %Q[       GET  /photos/:id(.:format) photos#show {:format=>"jpg"}]
+          '       GET  /photos/:id(.:format) photos#show {:format=>"jpg"}'
         ], output
       end
 
-      def test_rake_routes_shows_route_with_constraints
+      def test_rails_routes_shows_route_with_constraints
         output = draw do
-          get 'photos/:id' => 'photos#show', :id => /[A-Z]\d{5}/
+          get "photos/:id" => "photos#show", :id => /[A-Z]\d{5}/
         end
 
         assert_equal [
@@ -186,15 +192,15 @@ module ActionDispatch
         ], output
       end
 
-      def test_rake_routes_shows_routes_with_dashes
+      def test_rails_routes_shows_routes_with_dashes
         output = draw do
-          get 'about-us' => 'pages#about_us'
-          get 'our-work/latest'
+          get "about-us" => "pages#about_us"
+          get "our-work/latest"
 
           resources :photos, only: [:show] do
-            get 'user-favorites', on: :collection
-            get 'preview-photo', on: :member
-            get 'summary-text'
+            get "user-favorites", on: :collection
+            get "preview-photo", on: :member
+            get "summary-text"
           end
         end
 
@@ -209,9 +215,9 @@ module ActionDispatch
         ], output
       end
 
-      def test_rake_routes_shows_route_with_rack_app
+      def test_rails_routes_shows_route_with_rack_app
         output = draw do
-          get 'foo/:id' => MountedRackApp, :id => /[A-Z]\d{5}/
+          get "foo/:id" => MountedRackApp, :id => /[A-Z]\d{5}/
         end
 
         assert_equal [
@@ -220,9 +226,9 @@ module ActionDispatch
         ], output
       end
 
-      def test_rake_routes_shows_named_route_with_mounted_rack_app
+      def test_rails_routes_shows_named_route_with_mounted_rack_app
         output = draw do
-          mount MountedRackApp => '/foo'
+          mount MountedRackApp => "/foo"
         end
 
         assert_equal [
@@ -231,9 +237,9 @@ module ActionDispatch
         ], output
       end
 
-      def test_rake_routes_shows_overridden_named_route_with_mounted_rack_app_with_name
+      def test_rails_routes_shows_overridden_named_route_with_mounted_rack_app_with_name
         output = draw do
-          mount MountedRackApp => '/foo', as: 'blog'
+          mount MountedRackApp => "/foo", as: "blog"
         end
 
         assert_equal [
@@ -242,7 +248,7 @@ module ActionDispatch
         ], output
       end
 
-      def test_rake_routes_shows_route_with_rack_app_nested_with_dynamic_constraints
+      def test_rails_routes_shows_route_with_rack_app_nested_with_dynamic_constraints
         constraint = Class.new do
           def inspect
             "( my custom constraint )"
@@ -250,8 +256,8 @@ module ActionDispatch
         end
 
         output = draw do
-          scope :constraint => constraint.new do
-            mount MountedRackApp => '/foo'
+          scope constraint: constraint.new do
+            mount MountedRackApp => "/foo"
           end
         end
 
@@ -261,18 +267,18 @@ module ActionDispatch
         ], output
       end
 
-      def test_rake_routes_dont_show_app_mounted_in_assets_prefix
+      def test_rails_routes_dont_show_app_mounted_in_assets_prefix
         output = draw do
-          get '/sprockets' => MountedRackApp
+          get "/sprockets" => MountedRackApp
         end
         assert_no_match(/MountedRackApp/, output.first)
         assert_no_match(/\/sprockets/, output.first)
       end
 
-      def test_rake_routes_shows_route_defined_in_under_assets_prefix
+      def test_rails_routes_shows_route_defined_in_under_assets_prefix
         output = draw do
-          scope '/sprockets' do
-            get '/foo' => 'foo#bar'
+          scope "/sprockets" do
+            get "/foo" => "foo#bar"
           end
         end
         assert_equal [
@@ -283,9 +289,9 @@ module ActionDispatch
 
       def test_redirect
         output = draw do
-          get "/foo"    => redirect("/foo/bar"), :constraints => { :subdomain => "admin" }
+          get "/foo"    => redirect("/foo/bar"), :constraints => { subdomain: "admin" }
           get "/bar"    => redirect(path: "/foo/bar", status: 307)
-          get "/foobar" => redirect{ "/foo/bar" }
+          get "/foobar" => redirect { "/foo/bar" }
         end
 
         assert_equal [
@@ -297,7 +303,7 @@ module ActionDispatch
       end
 
       def test_routes_can_be_filtered
-        output = draw('posts') do
+        output = draw("posts") do
           resources :articles
           resources :posts
         end
@@ -314,7 +320,7 @@ module ActionDispatch
       end
 
       def test_routes_can_be_filtered_with_namespaced_controllers
-        output = draw('admin/posts') do
+        output = draw("admin/posts") do
           resources :articles
           namespace :admin do
             resources :posts
@@ -332,21 +338,22 @@ module ActionDispatch
                       "                DELETE /admin/posts/:id(.:format)      admin/posts#destroy"], output
       end
 
-
       def test_regression_route_with_controller_regexp
         output = draw do
-          get ':controller(/:action)', controller: /api\/[^\/]+/, format: false
+          ActiveSupport::Deprecation.silence do
+            get ":controller(/:action)", controller: /api\/[^\/]+/, format: false
+          end
         end
 
         assert_equal ["Prefix Verb URI Pattern            Controller#Action",
-                      "       GET  /:controller(/:action) (?-mix:api\\/[^\\/]+)#:action"], output
+                      "       GET  /:controller(/:action) :controller#:action"], output
       end
 
       def test_inspect_routes_shows_resources_route_when_assets_disabled
         @set = ActionDispatch::Routing::RouteSet.new
 
         output = draw do
-          get '/cart', to: 'cart#show'
+          get "/cart", to: "cart#show"
         end
 
         assert_equal [
@@ -356,8 +363,8 @@ module ActionDispatch
       end
 
       def test_routes_with_undefined_filter
-        output = draw(controller: 'Rails::MissingController') do
-          get 'photos/:id' => 'photos#show', :id => /[A-Z]\d{5}/
+        output = draw(controller: "Rails::MissingController") do
+          get "photos/:id" => "photos#show", :id => /[A-Z]\d{5}/
         end
 
         assert_equal [
@@ -367,8 +374,8 @@ module ActionDispatch
       end
 
       def test_no_routes_matched_filter
-        output = draw('rails/dummy') do
-          get 'photos/:id' => 'photos#show', :id => /[A-Z]\d{5}/
+        output = draw("rails/dummy") do
+          get "photos/:id" => "photos#show", :id => /[A-Z]\d{5}/
         end
 
         assert_equal [
@@ -378,7 +385,7 @@ module ActionDispatch
       end
 
       def test_no_routes_were_defined
-        output = draw('Rails::DummyController') {}
+        output = draw("Rails::DummyController") {}
 
         assert_equal [
           "You don't have any routes defined!",
@@ -389,6 +396,28 @@ module ActionDispatch
         ], output
       end
 
+      def test_displaying_routes_for_internal_engines
+        engine = Class.new(Rails::Engine) do
+          def self.inspect
+            "Blog::Engine"
+          end
+        end
+        engine.routes.draw do
+          get "/cart", to: "cart#show"
+          post "/cart", to: "cart#create"
+          patch "/cart", to: "cart#update"
+        end
+
+        output = draw do
+          get "/custom/assets", to: "custom_assets#show"
+          mount engine => "/blog", as: "blog", internal: true
+        end
+
+        assert_equal [
+          "       Prefix Verb URI Pattern              Controller#Action",
+          "custom_assets GET  /custom/assets(.:format) custom_assets#show",
+        ], output
+      end
     end
   end
 end