1 files changed, 28 insertions, 7 deletions
diff --git a/actionpack/test/controller/required_params_test.rb b/actionpack/test/controller/required_params_test.rb
index 661bcb3945..6803dbbb62 100644
--- a/actionpack/test/controller/required_params_test.rb
+++ b/actionpack/test/controller/required_params_test.rb
@@ -11,11 +11,13 @@ class ActionControllerRequiredParamsTest < ActionController::TestCase
   tests BooksController
 
   test "missing required parameters will raise exception" do
-    post :create, { magazine: { name: "Mjallo!" } }
-    assert_response :bad_request
+    assert_raise ActionController::ParameterMissing do
+      post :create, { magazine: { name: "Mjallo!" } }
+    end
 
-    post :create, { book: { title: "Mjallo!" } }
-    assert_response :bad_request
+    assert_raise ActionController::ParameterMissing do
+      post :create, { book: { title: "Mjallo!" } }
+    end
   end
 
   test "required parameters that are present will not raise" do
@@ -23,8 +25,27 @@ class ActionControllerRequiredParamsTest < ActionController::TestCase
     assert_response :ok
   end
 
-  test "missing parameters will be mentioned in the return" do
-    post :create, { magazine: { name: "Mjallo!" } }
-    assert_equal "Required parameter missing: book", response.body
+  test "required parameters with false value will not raise" do
+    post :create, { book: { name: false } }
+    assert_response :ok
+  end
+end
+
+class ParametersRequireTest < ActiveSupport::TestCase
+
+  test "required parameters should accept and return false value" do
+    assert_equal(false, ActionController::Parameters.new(person: false).require(:person))
+  end
+
+  test "required parameters must not be nil" do
+    assert_raises(ActionController::ParameterMissing) do
+      ActionController::Parameters.new(person: nil).require(:person)
+    end
+  end
+
+  test "required parameters must not be empty" do
+    assert_raises(ActionController::ParameterMissing) do
+      ActionController::Parameters.new(person: {}).require(:person)
+    end
   end
 end