1 files changed, 49 insertions, 35 deletions

diff --git a/actioncable/test/subscription_adapter/common.rb b/actioncable/test/subscription_adapter/common.rb
index 285c690df0..c533a9f3eb 100644
--- a/actioncable/test/subscription_adapter/common.rb
+++ b/actioncable/test/subscription_adapter/common.rb
@@ -1,8 +1,10 @@
-require 'test_helper'
-require 'concurrent'
+# frozen_string_literal: true
 
-require 'active_support/core_ext/hash/indifferent_access'
-require 'pathname'
+require "test_helper"
+require "concurrent"
+
+require "active_support/core_ext/hash/indifferent_access"
+require "pathname"
 
 module CommonSubscriptionAdapterTest
   WAIT_WHEN_EXPECTING_EVENT = 3
@@ -11,7 +13,7 @@ module CommonSubscriptionAdapterTest
   def setup
     server = ActionCable::Server::Base.new
     server.config.cable = cable_config.with_indifferent_access
-    server.config.use_faye = ENV['FAYE'].present?
+    server.config.logger = Logger.new(StringIO.new).tap { |l| l.level = Logger::UNKNOWN }
 
     adapter_klass = server.config.pubsub_adapter
 
@@ -20,10 +22,9 @@ module CommonSubscriptionAdapterTest
   end
 
   def teardown
-    [@rx_adapter, @tx_adapter].uniq.each(&:shutdown)
+    [@rx_adapter, @tx_adapter].uniq.compact.each(&:shutdown)
   end
 
-
   def subscribe_as_queue(channel, adapter = @rx_adapter)
     queue = Queue.new
 
@@ -41,77 +42,90 @@ module CommonSubscriptionAdapterTest
     adapter.unsubscribe(channel, callback) if subscribed.set?
   end
 
-
   def test_subscribe_and_unsubscribe
-    subscribe_as_queue('channel') do |queue|
+    subscribe_as_queue("channel") do |queue|
     end
   end
 
   def test_basic_broadcast
-    subscribe_as_queue('channel') do |queue|
-      @tx_adapter.broadcast('channel', 'hello world')
+    subscribe_as_queue("channel") do |queue|
+      @tx_adapter.broadcast("channel", "hello world")
 
-      assert_equal 'hello world', queue.pop
+      assert_equal "hello world", queue.pop
     end
   end
 
   def test_broadcast_after_unsubscribe
     keep_queue = nil
-    subscribe_as_queue('channel') do |queue|
+    subscribe_as_queue("channel") do |queue|
       keep_queue = queue
 
-      @tx_adapter.broadcast('channel', 'hello world')
+      @tx_adapter.broadcast("channel", "hello world")
 
-      assert_equal 'hello world', queue.pop
+      assert_equal "hello world", queue.pop
     end
 
-    @tx_adapter.broadcast('channel', 'hello void')
+    @tx_adapter.broadcast("channel", "hello void")
 
     sleep WAIT_WHEN_NOT_EXPECTING_EVENT
     assert_empty keep_queue
   end
 
   def test_multiple_broadcast
-    subscribe_as_queue('channel') do |queue|
-      @tx_adapter.broadcast('channel', 'bananas')
-      @tx_adapter.broadcast('channel', 'apples')
+    subscribe_as_queue("channel") do |queue|
+      @tx_adapter.broadcast("channel", "bananas")
+      @tx_adapter.broadcast("channel", "apples")
 
       received = []
       2.times { received << queue.pop }
-      assert_equal ['apples', 'bananas'], received.sort
+      assert_equal ["apples", "bananas"], received.sort
     end
   end
 
   def test_identical_subscriptions
-    subscribe_as_queue('channel') do |queue|
-      subscribe_as_queue('channel') do |queue_2|
-        @tx_adapter.broadcast('channel', 'hello')
+    subscribe_as_queue("channel") do |queue|
+      subscribe_as_queue("channel") do |queue_2|
+        @tx_adapter.broadcast("channel", "hello")
 
-        assert_equal 'hello', queue_2.pop
+        assert_equal "hello", queue_2.pop
       end
 
-      assert_equal 'hello', queue.pop
+      assert_equal "hello", queue.pop
     end
   end
 
   def test_simultaneous_subscriptions
-    subscribe_as_queue('channel') do |queue|
-      subscribe_as_queue('other channel') do |queue_2|
-        @tx_adapter.broadcast('channel', 'apples')
-        @tx_adapter.broadcast('other channel', 'oranges')
+    subscribe_as_queue("channel") do |queue|
+      subscribe_as_queue("other channel") do |queue_2|
+        @tx_adapter.broadcast("channel", "apples")
+        @tx_adapter.broadcast("other channel", "oranges")
 
-        assert_equal 'apples', queue.pop
-        assert_equal 'oranges', queue_2.pop
+        assert_equal "apples", queue.pop
+        assert_equal "oranges", queue_2.pop
       end
     end
   end
 
   def test_channel_filtered_broadcast
-    subscribe_as_queue('channel') do |queue|
-      @tx_adapter.broadcast('other channel', 'one')
-      @tx_adapter.broadcast('channel', 'two')
+    subscribe_as_queue("channel") do |queue|
+      @tx_adapter.broadcast("other channel", "one")
+      @tx_adapter.broadcast("channel", "two")
+
+      assert_equal "two", queue.pop
+    end
+  end
 
-      assert_equal 'two', queue.pop
+  def test_long_identifiers
+    channel_1 = "a" * 100 + "1"
+    channel_2 = "a" * 100 + "2"
+    subscribe_as_queue(channel_1) do |queue|
+      subscribe_as_queue(channel_2) do |queue_2|
+        @tx_adapter.broadcast(channel_1, "apples")
+        @tx_adapter.broadcast(channel_2, "oranges")
+
+        assert_equal "apples", queue.pop
+        assert_equal "oranges", queue_2.pop
+      end
     end
   end
 end