diff options
| -rw-r--r-- | actionpack/lib/action_controller/metal/rack_delegation.rb | 2 | ||||
| -rw-r--r-- | actionpack/lib/action_dispatch/http/response.rb | 3 | ||||
| -rw-r--r-- | activerecord/CHANGELOG.md | 7 | ||||
| -rw-r--r-- | activerecord/lib/active_record/errors.rb | 2 | ||||
| -rw-r--r-- | activerecord/lib/active_record/relation/merger.rb | 2 | ||||
| -rw-r--r-- | activerecord/test/cases/attribute_methods_test.rb | 6 | 
6 files changed, 13 insertions, 9 deletions
| diff --git a/actionpack/lib/action_controller/metal/rack_delegation.rb b/actionpack/lib/action_controller/metal/rack_delegation.rb index 6921834044..545d4a7e6e 100644 --- a/actionpack/lib/action_controller/metal/rack_delegation.rb +++ b/actionpack/lib/action_controller/metal/rack_delegation.rb @@ -6,7 +6,7 @@ module ActionController      extend ActiveSupport::Concern      delegate :headers, :status=, :location=, :content_type=, -             :status, :location, :content_type, :_status_code, :to => "@_response" +             :status, :location, :content_type, :response_code, :to => "@_response"      def dispatch(action, request)        set_response!(request) diff --git a/actionpack/lib/action_dispatch/http/response.rb b/actionpack/lib/action_dispatch/http/response.rb index d0580058c3..99d46af953 100644 --- a/actionpack/lib/action_dispatch/http/response.rb +++ b/actionpack/lib/action_dispatch/http/response.rb @@ -309,9 +309,6 @@ module ActionDispatch # :nodoc:        cookies      end -    def _status_code #:nodoc: -      @status -    end    private      def before_committed diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index b12d048169..e0e107e89d 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,10 @@ +*   `AR::UnknownAttributeError` now includes the class name of a record. + +        User.new(name: "Yuki Nishijima", project_attributes: {name: "kaminari"}) +        # => ActiveRecord::UnknownAttributeError: unknown attribute 'name' for User. + +    *Yuki Nishijima* +  *   Fix regression causing `after_create` callbacks to run before associated      records are autosaved. diff --git a/activerecord/lib/active_record/errors.rb b/activerecord/lib/active_record/errors.rb index 52c70977ef..5b3fdf16f5 100644 --- a/activerecord/lib/active_record/errors.rb +++ b/activerecord/lib/active_record/errors.rb @@ -167,7 +167,7 @@ module ActiveRecord      def initialize(record, attribute)        @record = record        @attribute = attribute.to_s -      super("unknown attribute: #{attribute}") +      super("unknown attribute '#{attribute}' for #{@record.class}.")      end    end diff --git a/activerecord/lib/active_record/relation/merger.rb b/activerecord/lib/active_record/relation/merger.rb index ac41d0aa80..545bf5debc 100644 --- a/activerecord/lib/active_record/relation/merger.rb +++ b/activerecord/lib/active_record/relation/merger.rb @@ -13,7 +13,7 @@ module ActiveRecord          @hash     = hash        end -      def merge +      def merge #:nodoc:          Merger.new(relation, other).merge        end diff --git a/activerecord/test/cases/attribute_methods_test.rb b/activerecord/test/cases/attribute_methods_test.rb index 7ca7349528..c3e8ceb0da 100644 --- a/activerecord/test/cases/attribute_methods_test.rb +++ b/activerecord/test/cases/attribute_methods_test.rb @@ -736,11 +736,11 @@ class AttributeMethodsTest < ActiveRecord::TestCase    def test_bulk_update_raise_unknown_attribute_error      error = assert_raises(ActiveRecord::UnknownAttributeError) { -      @target.new(:hello => "world") +      Topic.new(hello: "world")      } -    assert_instance_of @target, error.record +    assert_instance_of Topic, error.record      assert_equal "hello", error.attribute -    assert_equal "unknown attribute: hello", error.message +    assert_equal "unknown attribute 'hello' for Topic.", error.message    end    def test_methods_override_in_multi_level_subclass | 
