diff options
| -rw-r--r-- | actioncable/CHANGELOG.md | 4 | ||||
| -rw-r--r-- | actioncable/app/assets/javascripts/action_cable.js | 4 | ||||
| -rw-r--r-- | actioncable/app/javascript/action_cable/connection.js | 4 | ||||
| -rw-r--r-- | actioncable/test/javascript/src/test.js | 1 | ||||
| -rw-r--r-- | actioncable/test/javascript/src/unit/connection_test.js | 28 | 
5 files changed, 37 insertions, 4 deletions
diff --git a/actioncable/CHANGELOG.md b/actioncable/CHANGELOG.md index c0ab0485f3..e30e07d4a2 100644 --- a/actioncable/CHANGELOG.md +++ b/actioncable/CHANGELOG.md @@ -1,3 +1,7 @@ +*   `ActionCable.Connection#getState` now references the configurable +    `ActionCable.adapters.WebSocket` property rather than the `WebSocket` global +    variable, matching the behavior of `ActionCable.Connection#open`. +  *   The ActionCable javascript package has been converted from CoffeeScript      to ES2015, and we now publish the source code in the npm distribution. diff --git a/actioncable/app/assets/javascripts/action_cable.js b/actioncable/app/assets/javascripts/action_cable.js index 90e8e6b99b..ee11c62eb6 100644 --- a/actioncable/app/assets/javascripts/action_cable.js +++ b/actioncable/app/assets/javascripts/action_cable.js @@ -224,8 +224,8 @@      };      Connection.prototype.getState = function getState() {        if (this.webSocket) { -        for (var state in WebSocket) { -          if (WebSocket[state] === this.webSocket.readyState) { +        for (var state in adapters.WebSocket) { +          if (adapters.WebSocket[state] === this.webSocket.readyState) {              return state.toLowerCase();            }          } diff --git a/actioncable/app/javascript/action_cable/connection.js b/actioncable/app/javascript/action_cable/connection.js index e3ff8bde24..8aa4fe1266 100644 --- a/actioncable/app/javascript/action_cable/connection.js +++ b/actioncable/app/javascript/action_cable/connection.js @@ -88,8 +88,8 @@ class Connection {    getState() {      if (this.webSocket) { -      for (let state in WebSocket) { -        if (WebSocket[state] === this.webSocket.readyState) { +      for (let state in adapters.WebSocket) { +        if (adapters.WebSocket[state] === this.webSocket.readyState) {            return state.toLowerCase()          }        } diff --git a/actioncable/test/javascript/src/test.js b/actioncable/test/javascript/src/test.js index 1fca7ab4d3..eea1c0a408 100644 --- a/actioncable/test/javascript/src/test.js +++ b/actioncable/test/javascript/src/test.js @@ -1,5 +1,6 @@  import "./test_helpers/index"  import "./unit/action_cable_test" +import "./unit/connection_test"  import "./unit/consumer_test"  import "./unit/subscription_test"  import "./unit/subscriptions_test" diff --git a/actioncable/test/javascript/src/unit/connection_test.js b/actioncable/test/javascript/src/unit/connection_test.js new file mode 100644 index 0000000000..9b1a975bfb --- /dev/null +++ b/actioncable/test/javascript/src/unit/connection_test.js @@ -0,0 +1,28 @@ +import * as ActionCable from "../../../../app/javascript/action_cable/index" + +const {module, test} = QUnit + +module("ActionCable.Connection", () => { +  module("#getState", () => { +    test("uses the configured WebSocket adapter", assert => { +      ActionCable.adapters.WebSocket = { foo: 1, BAR: "42" } +      const connection = new ActionCable.Connection({}) +      connection.webSocket = {} +      connection.webSocket.readyState = 1 +      assert.equal(connection.getState(), "foo") +      connection.webSocket.readyState = "42" +      assert.equal(connection.getState(), "bar") +    }) +  }) + +  module("#open", () => { +    test("uses the configured WebSocket adapter", assert => { +      const FakeWebSocket = function() {} +      ActionCable.adapters.WebSocket = FakeWebSocket +      const connection = new ActionCable.Connection({}) +      connection.monitor = { start() {} } +      connection.open() +      assert.equal(connection.webSocket instanceof FakeWebSocket, true) +    }) +  }) +})  | 
