aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorArun Agrawal <arunagw@gmail.com>2013-03-08 15:50:34 +0100
committerArun Agrawal <arunagw@gmail.com>2013-03-08 16:08:43 +0100
commitc8918c6972d122531a5ae750ae1b22ff7d539f10 (patch)
tree304cfb274bea2617dc46afa80604682dd81badd6 /activerecord
parenta5013bb5af299db6bf97f67d4198220280717e80 (diff)
downloadrails-c8918c6972d122531a5ae750ae1b22ff7d539f10.tar.gz
rails-c8918c6972d122531a5ae750ae1b22ff7d539f10.tar.bz2
rails-c8918c6972d122531a5ae750ae1b22ff7d539f10.zip
Removing FIXME
As we did in master.
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/test/cases/bind_parameter_test.rb17
1 files changed, 8 insertions, 9 deletions
diff --git a/activerecord/test/cases/bind_parameter_test.rb b/activerecord/test/cases/bind_parameter_test.rb
index 3652255c38..e399345734 100644
--- a/activerecord/test/cases/bind_parameter_test.rb
+++ b/activerecord/test/cases/bind_parameter_test.rb
@@ -23,6 +23,8 @@ module ActiveRecord
@listener = LogListener.new
@pk = Topic.columns.find { |c| c.primary }
ActiveSupport::Notifications.subscribe('sql.active_record', @listener)
+
+ skip_if_prepared_statement_caching_is_not_supported
end
def teardown
@@ -30,9 +32,6 @@ module ActiveRecord
end
def test_binds_are_logged
- # FIXME: use skip with minitest
- return unless @connection.supports_statement_cache?
-
sub = @connection.substitute_at(@pk, 0)
binds = [[@pk, 1]]
sql = "select * from topics where id = #{sub}"
@@ -44,9 +43,6 @@ module ActiveRecord
end
def test_find_one_uses_binds
- # FIXME: use skip with minitest
- return unless @connection.supports_statement_cache?
-
Topic.find(1)
binds = [[@pk, 1]]
message = @listener.calls.find { |args| args[4][:binds] == binds }
@@ -54,9 +50,6 @@ module ActiveRecord
end
def test_logs_bind_vars
- # FIXME: use skip with minitest
- return unless @connection.supports_statement_cache?
-
pk = Topic.columns.find { |x| x.primary }
payload = {
@@ -86,5 +79,11 @@ module ActiveRecord
logger.sql event
assert_match([[pk.name, 10]].inspect, logger.debugs.first)
end
+
+ private
+
+ def skip_if_prepared_statement_caching_is_not_supported
+ return skip('prepared statement caching is not supported') unless @connection.supports_statement_cache?
+ end
end
end