Added add/remove_timestamps to the schema statements for adding the created_at/updated_at columns on existing tables (closes #11129) [jramirez]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9014 5ecf4fe2-1ee6-0310-87b1-e25e094e27de

3 files changed, 58 insertions, 0 deletions

diff --git a/activerecord/CHANGELOG b/activerecord/CHANGELOG
index 3f7eb54a21..f999877be8 100644
--- a/activerecord/CHANGELOG
+++ b/activerecord/CHANGELOG
@@ -1,5 +1,7 @@
 *SVN*
 
+* Added add/remove_timestamps to the schema statements for adding the created_at/updated_at columns on existing tables #11129 [jramirez]
+
 * Added ActiveRecord::Base.find(:last) #11338 [miloops]
 
 * test_native_types expects DateTime.local_offset instead of DateTime.now.offset; fixes test breakage due to dst transition [Geoff Buesing]
diff --git a/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb b/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
index 8bbadd67e7..b471b153de 100644
--- a/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
+++ b/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
@@ -298,6 +298,22 @@ module ActiveRecord
         sql << " ORDER BY #{options[:order]}"
       end
 
+      # Adds timestamps (created_at and updated_at) columns to the named table.
+      # ===== Examples
+      #  add_timestamps(:suppliers)
+      def add_timestamps(table_name)
+        add_column table_name, :created_at, :datetime
+        add_column table_name, :updated_at, :datetime    
+      end
+      
+      # Removes the timestamp columns (created_at and updated_at) from the table definition.
+      # ===== Examples
+      #  remove_timestamps(:suppliers)
+      def remove_timestamps(table_name)
+        remove_column table_name, :updated_at   
+        remove_column table_name, :created_at       
+      end
+      
       protected
         def options_include_default?(options)
           options.include?(:default) && !(options[:null] == false && options[:default].nil?)
diff --git a/activerecord/test/cases/active_schema_test_mysql.rb b/activerecord/test/cases/active_schema_test_mysql.rb
index cf2233eb33..ddf3e82162 100644
--- a/activerecord/test/cases/active_schema_test_mysql.rb
+++ b/activerecord/test/cases/active_schema_test_mysql.rb
@@ -39,6 +39,46 @@ class ActiveSchemaTest < ActiveRecord::TestCase
     assert_equal "DROP TABLE `otherdb`.`people`", drop_table('otherdb.people')
   end
 
+  def test_add_timestamps 
+    #we need to actually modify some data, so we make execute to point to the original method
+    ActiveRecord::ConnectionAdapters::MysqlAdapter.class_eval do      
+      alias_method :execute_with_stub, :execute
+      alias_method :execute, :execute_without_stub
+    end  
+    ActiveRecord::Base.connection.create_table :delete_me do |t|        
+    end
+    ActiveRecord::Base.connection.add_timestamps :delete_me
+    assert_equal ActiveRecord::Base.connection.execute("SHOW FIELDS FROM delete_me where FIELD='updated_at' AND TYPE='datetime'").num_rows, 1
+    assert_equal ActiveRecord::Base.connection.execute("SHOW FIELDS FROM delete_me where FIELD='created_at' AND TYPE='datetime'").num_rows, 1
+  ensure    
+    ActiveRecord::Base.connection.drop_table :delete_me rescue nil  
+    #before finishing, we restore the alias to the mock-up method
+    ActiveRecord::ConnectionAdapters::MysqlAdapter.class_eval do      
+      alias_method :execute, :execute_with_stub
+    end
+  end
+  
+  def test_remove_timestamps 
+    #we need to actually modify some data, so we make execute to point to the original method
+    ActiveRecord::ConnectionAdapters::MysqlAdapter.class_eval do      
+      alias_method :execute_with_stub, :execute
+      alias_method :execute, :execute_without_stub
+    end  
+    ActiveRecord::Base.connection.create_table :delete_me do |t|        
+      t.timestamps
+    end
+    ActiveRecord::Base.connection.remove_timestamps :delete_me
+    assert_equal ActiveRecord::Base.connection.execute("SHOW FIELDS FROM delete_me where FIELD='updated_at' AND TYPE='datetime'").num_rows, 0
+    assert_equal ActiveRecord::Base.connection.execute("SHOW FIELDS FROM delete_me where FIELD='created_at' AND TYPE='datetime'").num_rows, 0
+  ensure    
+    ActiveRecord::Base.connection.drop_table :delete_me rescue nil  
+    #before finishing, we restore the alias to the mock-up method
+    ActiveRecord::ConnectionAdapters::MysqlAdapter.class_eval do      
+      alias_method :execute, :execute_with_stub
+    end
+  end
+
+
   private
     def method_missing(method_symbol, *arguments)
       ActiveRecord::Base.connection.send(method_symbol, *arguments)