diff options
author | saksmlz <saksmlz@gmail.com> | 2012-10-31 12:59:11 +0300 |
---|---|---|
committer | saksmlz <saksmlz@gmail.com> | 2012-10-31 12:59:11 +0300 |
commit | 68307a1ae5fc9e454230629f5cbbbeaf79fd7cec (patch) | |
tree | 04391b5cf1b12eaad2ddb92aa9cbf49d1dc0b68c /activerecord | |
parent | d5b275db5c20669a7a9e598a70decf1316b39e03 (diff) | |
download | rails-68307a1ae5fc9e454230629f5cbbbeaf79fd7cec.tar.gz rails-68307a1ae5fc9e454230629f5cbbbeaf79fd7cec.tar.bz2 rails-68307a1ae5fc9e454230629f5cbbbeaf79fd7cec.zip |
Fix ActiveRecord#update_column return value
Diffstat (limited to 'activerecord')
-rw-r--r-- | activerecord/lib/active_record/persistence.rb | 2 | ||||
-rw-r--r-- | activerecord/test/cases/persistence_test.rb | 6 |
2 files changed, 7 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/persistence.rb b/activerecord/lib/active_record/persistence.rb index d492ac7f16..fd3380a53c 100644 --- a/activerecord/lib/active_record/persistence.rb +++ b/activerecord/lib/active_record/persistence.rb @@ -194,7 +194,7 @@ module ActiveRecord raise ActiveRecordError, "#{name} is marked as readonly" if self.class.readonly_attributes.include?(name) raise ActiveRecordError, "can not update on a new record object" unless persisted? - updated_count = self.class.update_all({ name => value }, self.class.primary_key => id) == 1 + updated_count = self.class.update_all({ name => value }, self.class.primary_key => id) raw_write_attribute(name, value) diff --git a/activerecord/test/cases/persistence_test.rb b/activerecord/test/cases/persistence_test.rb index 66f884287d..be164afe9f 100644 --- a/activerecord/test/cases/persistence_test.rb +++ b/activerecord/test/cases/persistence_test.rb @@ -513,6 +513,12 @@ class PersistencesTest < ActiveRecord::TestCase assert_equal 123, topic.id end + def test_update_column_should_return_correct_value + developer = Developer.find(1) + return_value = developer.update_column(:salary, 80001) + assert_equal return_value, true + end + def test_update_attributes topic = Topic.find(1) assert !topic.approved? |