Quote booleans according the rules defined by the adapter

* SQLite schema has been updated
* Postgresql schema needs to be fixed too
Simplify AR::Base#toggle to store the boolean, not the quoted value
* expand the tests


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2474 5ecf4fe2-1ee6-0310-87b1-e25e094e27de

5 files changed, 13 insertions, 8 deletions

diff --git a/activerecord/test/base_test.rb b/activerecord/test/base_test.rb
index 50d1673361..fd5e439ef4 100755
--- a/activerecord/test/base_test.rb
+++ b/activerecord/test/base_test.rb
@@ -380,7 +380,7 @@ class BasicsTest < Test::Unit::TestCase
   end
 
   def test_update_by_condition
-    Topic.update_all "content = 'bulk updated!'", "approved = 1"
+    Topic.update_all "content = 'bulk updated!'", ["approved = ?", true]
     assert_equal "Have a nice day", Topic.find(1).content
     assert_equal "bulk updated!", Topic.find(2).content
   end
@@ -812,6 +812,11 @@ class BasicsTest < Test::Unit::TestCase
     assert !topics(:first).approved?
     topics(:first).toggle!(:approved)
     assert topics(:first).approved?
+    topic = topics(:first)
+    topic.toggle(:approved)
+    assert !topic.approved?
+    topic.reload
+    assert topic.approved?
   end
 
   def test_reload
diff --git a/activerecord/test/deprecated_finder_test.rb b/activerecord/test/deprecated_finder_test.rb
index 0111cff3ac..348292870b 100755
--- a/activerecord/test/deprecated_finder_test.rb
+++ b/activerecord/test/deprecated_finder_test.rb
@@ -38,8 +38,8 @@ class FinderTest < Test::Unit::TestCase
   end
   
   def test_deprecated_find_on_conditions
-    assert Topic.find_on_conditions(1, "approved = 0")
-    assert_raises(ActiveRecord::RecordNotFound) { Topic.find_on_conditions(1, "approved = 1") }
+    assert Topic.find_on_conditions(1, ["approved = ?", false])
+    assert_raises(ActiveRecord::RecordNotFound) { Topic.find_on_conditions(1, ["approved = ?", true]) }
   end
   
   def test_condition_interpolation
diff --git a/activerecord/test/finder_test.rb b/activerecord/test/finder_test.rb
index 35c96288fe..c87fc7f2f2 100644
--- a/activerecord/test/finder_test.rb
+++ b/activerecord/test/finder_test.rb
@@ -100,8 +100,8 @@ class FinderTest < Test::Unit::TestCase
   end
 
   def test_find_on_conditions
-    assert Topic.find(1, :conditions => "approved = 0")
-    assert_raises(ActiveRecord::RecordNotFound) { Topic.find(1, :conditions => "approved = 1") }
+    assert Topic.find(1, :conditions => ["approved = ?", false])
+    assert_raises(ActiveRecord::RecordNotFound) { Topic.find(1, :conditions => ["approved = ?", true]) }
   end
   
   def test_condition_interpolation
diff --git a/activerecord/test/fixtures/db_definitions/sqlite.sql b/activerecord/test/fixtures/db_definitions/sqlite.sql
index d5879c31d8..1f8a2614dd 100644
--- a/activerecord/test/fixtures/db_definitions/sqlite.sql
+++ b/activerecord/test/fixtures/db_definitions/sqlite.sql
@@ -24,7 +24,7 @@ CREATE TABLE 'topics' (
   'bonus_time' TIME DEFAULT NULL,
   'last_read' DATE DEFAULT NULL,
   'content' TEXT,
-  'approved' INTEGER DEFAULT 1,
+  'approved' boolean DEFAULT 'f',
   'replies_count' INTEGER DEFAULT 0,
   'parent_id' INTEGER DEFAULT NULL,
   'type' VARCHAR(255) DEFAULT NULL
diff --git a/activerecord/test/fixtures/topics.yml b/activerecord/test/fixtures/topics.yml
index 313999b1ee..6d4f5d800b 100644
--- a/activerecord/test/fixtures/topics.yml
+++ b/activerecord/test/fixtures/topics.yml
@@ -7,7 +7,7 @@ first:
   last_read: 2004-04-15
   bonus_time: 2005-01-30t15:28:00.00+01:00
   content: Have a nice day
-  approved: '0'
+  approved: false
   replies_count: 0
 
 second:
@@ -16,6 +16,6 @@ second:
   author_name: Mary
   written_on: 2003-07-15t15:28:00.00+01:00
   content: Have a nice day
-  approved: '1'
+  approved: true
   replies_count: 2
   parent_id: 1