aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
diff options
context:
space:
mode:
authorJacob Dunphy <jacob.dunphy@gmail.com>2009-01-15 13:30:44 -0800
committerMichael Koziarski <michael@koziarski.com>2009-01-29 17:34:33 +1300
commite6493eb9b76de73afef2706493efd090dfff4ecc (patch)
treebd2fb28d979c63f3a87e79f7c319ef86cf236fb4 /activerecord/test/cases
parentfeed7b4cfd860bdc9f5b4efc2ca2af76cb01d55d (diff)
downloadrails-e6493eb9b76de73afef2706493efd090dfff4ecc.tar.gz
rails-e6493eb9b76de73afef2706493efd090dfff4ecc.tar.bz2
rails-e6493eb9b76de73afef2706493efd090dfff4ecc.zip
Sqlite adapter's copy_table incorrectly attempts to recreate a primary key id (:id => true in the create_table) if an :id column is present, even if it isn't a primary_key.
This fix sets :id => false if there is an :id column, but it's not the primary_key. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1766 state:committed]
Diffstat (limited to 'activerecord/test/cases')
-rw-r--r--activerecord/test/cases/copy_table_test_sqlite.rb11
1 files changed, 11 insertions, 0 deletions
diff --git a/activerecord/test/cases/copy_table_test_sqlite.rb b/activerecord/test/cases/copy_table_test_sqlite.rb
index f0cfb67866..72bd7e2dab 100644
--- a/activerecord/test/cases/copy_table_test_sqlite.rb
+++ b/activerecord/test/cases/copy_table_test_sqlite.rb
@@ -46,6 +46,17 @@ class CopyTableTest < ActiveRecord::TestCase
test_copy_table('developers_projects', 'programmers_projects')
end
+ def test_copy_table_with_id_col_that_is_not_primary_key
+ test_copy_table('goofy_string_id', 'goofy_string_id2') do |from, to, options|
+ original_id = @connection.columns('goofy_string_id').detect{|col| col.name == 'id' }
+ copied_id = @connection.columns('goofy_string_id2').detect{|col| col.name == 'id' }
+ assert_equal original_id.type, copied_id.type
+ assert_equal original_id.sql_type, copied_id.sql_type
+ assert_equal original_id.limit, copied_id.limit
+ assert_equal original_id.primary, copied_id.primary
+ end
+ end
+
protected
def copy_table(from, to, options = {})
@connection.copy_table(from, to, {:temporary => true}.merge(options))