aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/aggregations_test.rb
diff options
context:
space:
mode:
authorSteve Klabnik <steve@steveklabnik.com>2012-06-15 11:04:43 +0200
committerSteve Klabnik <steve@steveklabnik.com>2012-06-18 15:38:51 -0400
commit44b313bc4e3762da64dde7894548f81c595147de (patch)
treebf2485313247567c13f0a4e29eb7ab06cafe2d85 /activerecord/test/cases/aggregations_test.rb
parenta8e22aeadcf53a30893fbfbf6d446d504bd87b67 (diff)
downloadrails-44b313bc4e3762da64dde7894548f81c595147de.tar.gz
rails-44b313bc4e3762da64dde7894548f81c595147de.tar.bz2
rails-44b313bc4e3762da64dde7894548f81c595147de.zip
Deprecating composed_of in ActiveRecord
This feature adds a lot of complication to ActiveRecord for dubious value. Let's talk about what it does currently: class Customer < ActiveRecord::Base composed_of :balance, :class_name => "Money", :mapping => %w(balance amount) end Instead, you can do something like this: def balance @balance ||= Money.new(value, currency) end def balance=(balance) self[:value] = balance.value self[:currency] = balance.currency @balance = balance end Since that's fairly easy code to write, and doesn't need anything extra from the framework, if you use composed_of today, you'll have to add accessors/mutators like that. This feature will be removed in Rails 4.
Diffstat (limited to 'activerecord/test/cases/aggregations_test.rb')
-rw-r--r--activerecord/test/cases/aggregations_test.rb8
1 files changed, 6 insertions, 2 deletions
diff --git a/activerecord/test/cases/aggregations_test.rb b/activerecord/test/cases/aggregations_test.rb
index 3e0e6dce2c..7eb7ffdd2d 100644
--- a/activerecord/test/cases/aggregations_test.rb
+++ b/activerecord/test/cases/aggregations_test.rb
@@ -126,11 +126,15 @@ class OverridingAggregationsTest < ActiveRecord::TestCase
class DifferentName; end
class Person < ActiveRecord::Base
- composed_of :composed_of, :mapping => %w(person_first_name first_name)
+ ActiveSupport::Deprecation.silence do
+ composed_of :composed_of, :mapping => %w(person_first_name first_name)
+ end
end
class DifferentPerson < Person
- composed_of :composed_of, :class_name => 'DifferentName', :mapping => %w(different_person_first_name first_name)
+ ActiveSupport::Deprecation.silence do
+ composed_of :composed_of, :class_name => 'DifferentName', :mapping => %w(different_person_first_name first_name)
+ end
end
def test_composed_of_aggregation_redefinition_reflections_should_differ_and_not_inherited