aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
diff options
context:
space:
mode:
authorJon Leighton <j@jonathanleighton.com>2011-11-03 15:07:24 +0000
committerJon Leighton <j@jonathanleighton.com>2011-11-03 15:12:08 +0000
commitd486103570bf680307ba474915efc01862e99403 (patch)
tree8b7a7e64d442fcc73a0f772541ebb4ce5e6fa618 /activerecord/lib
parent567d454d99bd472ef342c047c0038504fa4f960c (diff)
downloadrails-d486103570bf680307ba474915efc01862e99403.tar.gz
rails-d486103570bf680307ba474915efc01862e99403.tar.bz2
rails-d486103570bf680307ba474915efc01862e99403.zip
Fix #3271.
Building the conditions of a nested through association could potentially modify the conditions of the through and/or source association. This is a Bad Thing.
Diffstat (limited to 'activerecord/lib')
-rw-r--r--activerecord/lib/active_record/reflection.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/reflection.rb b/activerecord/lib/active_record/reflection.rb
index 5285060288..98f0418d3f 100644
--- a/activerecord/lib/active_record/reflection.rb
+++ b/activerecord/lib/active_record/reflection.rb
@@ -433,7 +433,7 @@ module ActiveRecord
# of relevant reflections, plus any :source_type or polymorphic :as constraints.
def conditions
@conditions ||= begin
- conditions = source_reflection.conditions
+ conditions = source_reflection.conditions.map { |c| c.dup }
# Add to it the conditions from this reflection if necessary.
conditions.first << options[:conditions] if options[:conditions]