aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
diff options
context:
space:
mode:
authorJeremy Kemper <jeremy@bitsweat.net>2008-02-03 01:09:58 +0000
committerJeremy Kemper <jeremy@bitsweat.net>2008-02-03 01:09:58 +0000
commit78253acb599102528498d2257a37361a39f850f7 (patch)
tree594f87416a188763ab7eb29fc1df7efeb71d6cce /activerecord/lib/active_record
parent7fe2ad72790eeffcca382907ff63346981eb0f41 (diff)
downloadrails-78253acb599102528498d2257a37361a39f850f7.tar.gz
rails-78253acb599102528498d2257a37361a39f850f7.tar.bz2
rails-78253acb599102528498d2257a37361a39f850f7.zip
Revert r8742: remove has_many with :group option since it has sketchy sql support. Closes #10480.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8790 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
Diffstat (limited to 'activerecord/lib/active_record')
-rwxr-xr-xactiverecord/lib/active_record/associations.rb6
-rw-r--r--activerecord/lib/active_record/associations/has_many_through_association.rb9
2 files changed, 0 insertions, 15 deletions
diff --git a/activerecord/lib/active_record/associations.rb b/activerecord/lib/active_record/associations.rb
index a1c8bd6e50..cb17b6e483 100755
--- a/activerecord/lib/active_record/associations.rb
+++ b/activerecord/lib/active_record/associations.rb
@@ -55,12 +55,6 @@ module ActiveRecord
end
end
- class HasManyThroughCantCountOnColumnForGroupedAssociation < ActiveRecordError #:nodoc:
- def initialize(owner, reflection, column_name)
- super("Cannot count on column '#{column_name}' for association '#{owner.class.name}##{reflection.name}' grouped by '#{reflection.options[:group]}'.")
- end
- end
-
class EagerLoadPolymorphicError < ActiveRecordError #:nodoc:
def initialize(reflection)
super("Can not eagerly load the polymorphic association #{reflection.name.inspect}")
diff --git a/activerecord/lib/active_record/associations/has_many_through_association.rb b/activerecord/lib/active_record/associations/has_many_through_association.rb
index 06ea5d1d1c..94842f424d 100644
--- a/activerecord/lib/active_record/associations/has_many_through_association.rb
+++ b/activerecord/lib/active_record/associations/has_many_through_association.rb
@@ -124,15 +124,6 @@ module ActiveRecord
column_name = "#{@reflection.quoted_table_name}.#{@reflection.klass.primary_key}" if column_name == :all
options.merge!(:distinct => true)
end
-
- if @reflection.options[:group]
- unless column_name == :all
- raise HasManyThroughCantCountOnColumnForGroupedAssociation.new(@owner, @reflection, column_name)
- end
- column_name = @reflection.options[:group]
- options.merge!(:distinct => true)
- end
-
@reflection.klass.send(:with_scope, construct_scope) { @reflection.klass.count(column_name, options) }
end