aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/migration.rb
diff options
context:
space:
mode:
authorSteve Klabnik <steve@steveklabnik.com>2012-06-14 18:46:38 +0200
committerSteve Klabnik <steve@steveklabnik.com>2012-06-14 23:14:40 +0200
commitb081f6b59fb3f15d12043072ad9b331ffd2bc56e (patch)
treedebc1a9482be91e1fb8c15df482ee130ccb258e6 /activerecord/lib/active_record/migration.rb
parent7f937914576c65a01f3a9528d1728720c6c400c5 (diff)
downloadrails-b081f6b59fb3f15d12043072ad9b331ffd2bc56e.tar.gz
rails-b081f6b59fb3f15d12043072ad9b331ffd2bc56e.tar.bz2
rails-b081f6b59fb3f15d12043072ad9b331ffd2bc56e.zip
Deprecate update_attribute.
Historically, update_attribute and update_attributes are similar, but with one big difference: update_attribute does not run validations. These two methods are really easy to confuse given their similar names. Therefore, update_attribute is being deprecated in favor of update_column, and will be removed in Rails 4. See the discussion on rails-core here: https://groups.google.com/d/topic/rubyonrails-core/BWPUTK7WvYA/discussion
Diffstat (limited to 'activerecord/lib/active_record/migration.rb')
-rw-r--r--activerecord/lib/active_record/migration.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/migration.rb b/activerecord/lib/active_record/migration.rb
index e6686597b7..b4b4667ce0 100644
--- a/activerecord/lib/active_record/migration.rb
+++ b/activerecord/lib/active_record/migration.rb
@@ -232,7 +232,7 @@ module ActiveRecord
# add_column :people, :salary, :integer
# Person.reset_column_information
# Person.all.each do |p|
- # p.update_attribute :salary, SalaryCalculator.compute(p)
+ # p.update_column :salary, SalaryCalculator.compute(p)
# end
# end
# end
@@ -252,7 +252,7 @@ module ActiveRecord
# ...
# say_with_time "Updating salaries..." do
# Person.all.each do |p|
- # p.update_attribute :salary, SalaryCalculator.compute(p)
+ # p.update_column :salary, SalaryCalculator.compute(p)
# end
# end
# ...