diff options
| author | Pratik Naik <pratiknaik@gmail.com> | 2010-01-22 00:51:45 +0530 |
|---|---|---|
| committer | Pratik Naik <pratiknaik@gmail.com> | 2010-01-22 02:37:07 +0530 |
| commit | 6d30002a52133bd105adb29084f4cc72b1ee847f (patch) | |
| tree | e2c194d8b454b66daf4db58d770c1337d0c20399 /activerecord/lib/active_record/attribute_methods/write.rb | |
| parent | a68a3e9af6a02c9ce18d3eec87558241095ce8fb (diff) | |
| download | rails-6d30002a52133bd105adb29084f4cc72b1ee847f.tar.gz rails-6d30002a52133bd105adb29084f4cc72b1ee847f.tar.bz2 rails-6d30002a52133bd105adb29084f4cc72b1ee847f.zip | |
Revert "Refactoring attributes/types" [#3348 state:open]
This reverts commit f936a1f100e75082081e782e5cceb272885c2df7.
Conflicts:
activerecord/lib/active_record.rb
activerecord/lib/active_record/base.rb
Revert "Fixed: #without_typecast should only disable typecasting on the duplicated attributes" [#3387 state:open]
This reverts commit 2831996483c6a045f1f38d8030256eb58d9771c3.
Reason :
It's not generating attribute methods properly, making object.column 5x slower.
Diffstat (limited to 'activerecord/lib/active_record/attribute_methods/write.rb')
| -rw-r--r-- | activerecord/lib/active_record/attribute_methods/write.rb | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/attribute_methods/write.rb b/activerecord/lib/active_record/attribute_methods/write.rb index 37eadbe0a9..e31acac050 100644 --- a/activerecord/lib/active_record/attribute_methods/write.rb +++ b/activerecord/lib/active_record/attribute_methods/write.rb @@ -17,9 +17,14 @@ module ActiveRecord # Updates the attribute identified by <tt>attr_name</tt> with the specified +value+. Empty strings for fixnum and float # columns are turned into +nil+. def write_attribute(attr_name, value) - attr_name = _attributes.unalias(attr_name) + attr_name = attr_name.to_s + attr_name = self.class.primary_key if attr_name == 'id' @attributes_cache.delete(attr_name) - _attributes[attr_name] = value + if (column = column_for_attribute(attr_name)) && column.number? + @attributes[attr_name] = convert_number_column_value(value) + else + @attributes[attr_name] = value + end end private |