aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
diff options
context:
space:
mode:
authorFrederick Cheung <frederick.cheung@gmail.com>2008-12-11 10:20:33 -0600
committerJoshua Peek <josh@joshpeek.com>2008-12-11 10:20:33 -0600
commit5ede4ce188d29aef94af78f27d89169ac4ee54cd (patch)
treef634fe68c4c4ecc100ba094eccc6bacdbf7c9950 /actionpack
parent7cfa6c535bc54f16a3fc7fa39969d4410de3e483 (diff)
downloadrails-5ede4ce188d29aef94af78f27d89169ac4ee54cd.tar.gz
rails-5ede4ce188d29aef94af78f27d89169ac4ee54cd.tar.bz2
rails-5ede4ce188d29aef94af78f27d89169ac4ee54cd.zip
Fixed session related memory leak [#1558 state:resolved]
Signed-off-by: Joshua Peek <josh@joshpeek.com>
Diffstat (limited to 'actionpack')
-rw-r--r--actionpack/lib/action_controller/base.rb3
1 files changed, 3 insertions, 0 deletions
diff --git a/actionpack/lib/action_controller/base.rb b/actionpack/lib/action_controller/base.rb
index c2f0c1c4f6..13f2e9072e 100644
--- a/actionpack/lib/action_controller/base.rb
+++ b/actionpack/lib/action_controller/base.rb
@@ -1160,6 +1160,9 @@ module ActionController #:nodoc:
def reset_session #:doc:
request.reset_session
@_session = request.session
+ #http://rails.lighthouseapp.com/projects/8994/tickets/1558-memory-problem-on-reset_session-in-around_filter#ticket-1558-1
+ #MRI appears to have a GC related memory leak to do with the finalizer that is defined on CGI::Session
+ ObjectSpace.undefine_finalizer(@_session)
response.session = @_session
end