diff options
author | Johan Sörensen <johan@johansorensen.com> | 2009-05-28 09:30:49 -0500 |
---|---|---|
committer | Joshua Peek <josh@joshpeek.com> | 2009-05-28 09:30:49 -0500 |
commit | 72cb6f58be6590ac2590eea420a1b3ef175189b3 (patch) | |
tree | 5cd58771714d8faab77dff5c99c75c95389e39d2 /actionpack/test/controller/flash_test.rb | |
parent | 0349278f3da9f7f532330cf295eed35ede3bae66 (diff) | |
download | rails-72cb6f58be6590ac2590eea420a1b3ef175189b3.tar.gz rails-72cb6f58be6590ac2590eea420a1b3ef175189b3.tar.bz2 rails-72cb6f58be6590ac2590eea420a1b3ef175189b3.zip |
The FlashHash and friends causes a lot of needless session storing, when we know for a fact that there's no content in the flash. By not storing the empty hash in the session we save a lot of communication with the various session backends, while still keeping the same interface to the flash. [#2703 state:resolved]
Signed-off-by: Joshua Peek <josh@joshpeek.com>
Diffstat (limited to 'actionpack/test/controller/flash_test.rb')
-rw-r--r-- | actionpack/test/controller/flash_test.rb | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/actionpack/test/controller/flash_test.rb b/actionpack/test/controller/flash_test.rb index ee215bb19e..c448f36cb3 100644 --- a/actionpack/test/controller/flash_test.rb +++ b/actionpack/test/controller/flash_test.rb @@ -122,7 +122,7 @@ class FlashTest < ActionController::TestCase assert_nil assigns["flash_copy"]["that"], "On second flash" assert_equal "hello again", assigns["flash_copy"]["this"], "On second flash" end - + def test_flash_after_reset_session get :use_flash_after_reset_session assert_equal "hello", assigns["flashy_that"] @@ -130,6 +130,11 @@ class FlashTest < ActionController::TestCase assert_nil assigns["flashy_that_reset"] end + def test_does_not_set_the_session_if_the_flash_is_empty + get :std_action + assert_nil session["flash"] + end + def test_sweep_after_halted_filter_chain get :std_action assert_nil assigns["flash_copy"]["foo"] |