diff options
author | Emilio Tagua <miloops@gmail.com> | 2010-09-22 11:45:41 -0300 |
---|---|---|
committer | Santiago Pastorino <santiago@wyeworks.com> | 2010-09-22 18:08:03 -0300 |
commit | 8c97f49f2e63794514b563ba4078692c0be0c335 (patch) | |
tree | 0fa0821e78a5d08ebc2797575d103c41712527d2 /actionpack/lib | |
parent | 6d8a6700a76470b791f3e76fe4ca5d5f179daa1d (diff) | |
download | rails-8c97f49f2e63794514b563ba4078692c0be0c335.tar.gz rails-8c97f49f2e63794514b563ba4078692c0be0c335.tar.bz2 rails-8c97f49f2e63794514b563ba4078692c0be0c335.zip |
Refactor decode_credentials to avoid inject and use map instead.
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Diffstat (limited to 'actionpack/lib')
-rw-r--r-- | actionpack/lib/action_controller/metal/http_authentication.rb | 11 | ||||
-rw-r--r-- | actionpack/lib/action_view/test_case.rb | 2 |
2 files changed, 6 insertions, 7 deletions
diff --git a/actionpack/lib/action_controller/metal/http_authentication.rb b/actionpack/lib/action_controller/metal/http_authentication.rb index 1d74521e4f..251b1a8a8b 100644 --- a/actionpack/lib/action_controller/metal/http_authentication.rb +++ b/actionpack/lib/action_controller/metal/http_authentication.rb @@ -30,7 +30,7 @@ module ActionController # # # === Advanced \Basic example - # + # # Here is a more advanced \Basic example where only Atom feeds and the XML API is protected by HTTP authentication, # the regular HTML interface is protected by a session approach: # @@ -98,7 +98,7 @@ module ActionController # end # # === Notes - # + # # The +authenticate_or_request_with_http_digest+ block must return the user's password # or the ha1 digest hash so the framework can appropriately hash to check the user's # credentials. Returning +nil+ will cause authentication to fail. @@ -222,11 +222,10 @@ module ActionController end def decode_credentials(header) - header.to_s.gsub(/^Digest\s+/,'').split(',').inject({}) do |hash, pair| + Hash[header.to_s.gsub(/^Digest\s+/,'').split(',').map do |pair| key, value = pair.split('=', 2) - hash[key.strip.to_sym] = value.to_s.gsub(/^"|"$/,'').gsub(/'/, '') - hash - end + [key.strip.to_sym, value.to_s.gsub(/^"|"$/,'').gsub(/'/, '')] + end] end def authentication_header(controller, realm) diff --git a/actionpack/lib/action_view/test_case.rb b/actionpack/lib/action_view/test_case.rb index 34ed76707e..ff35fb7df4 100644 --- a/actionpack/lib/action_view/test_case.rb +++ b/actionpack/lib/action_view/test_case.rb @@ -189,7 +189,7 @@ module ActionView end def _assigns - _instance_variables.map { |var| [ var[1..-1].to_sym, instance_variable_get(var)] } + _instance_variables.map { |var| [var[1..-1].to_sym, instance_variable_get(var)] } end def _routes |