Mark bang instrumentations as something that you shuold not be listening to.

1 files changed, 3 insertions, 8 deletions

diff --git a/actionpack/lib/action_view/template.rb b/actionpack/lib/action_view/template.rb
index ad37eb4c4a..9145d007a8 100644
--- a/actionpack/lib/action_view/template.rb
+++ b/actionpack/lib/action_view/template.rb
@@ -23,7 +23,6 @@ module ActionView
       @identifier = identifier
       @handler    = handler
 
-      @partial      = details[:partial]
       @virtual_path = details[:virtual_path]
       @method_names = {}
 
@@ -36,9 +35,9 @@ module ActionView
     end
 
     def render(view, locals, &block)
-      # TODO: Revisit this name
-      # This is only slow if it's being listened to. Do not instrument this in production.
-      ActiveSupport::Notifications.instrument("action_view.slow_render_template", :virtual_path => @virtual_path) do
+      # Notice that we use a bang in this instrumentation because you don't want to
+      # consume this in production. This is only slow if it's being listened to.
+      ActiveSupport::Notifications.instrument("action_view.render_template!", :virtual_path => @virtual_path) do
         method_name = compile(locals, view)
         view.send(method_name, locals, &block)
       end
@@ -63,10 +62,6 @@ module ActionView
       @counter_name ||= "#{variable_name}_counter".to_sym
     end
 
-    def partial?
-      @partial
-    end
-
     def inspect
       if defined?(Rails.root)
         identifier.sub("#{Rails.root}/", '')