diff options
| author | Jeremy Kemper <jeremy@bitsweat.net> | 2010-03-31 19:49:29 -0700 |
|---|---|---|
| committer | Jeremy Kemper <jeremy@bitsweat.net> | 2010-03-31 19:51:54 -0700 |
| commit | 3859828d89d378986af0fc2390608b00aad5e912 (patch) | |
| tree | cc6fb043b3b28eef6386b226cea40e74c3948710 /actionpack/lib/action_view/helpers/form_tag_helper.rb | |
| parent | 8dfa27669bf75f616ecaaccb61b99ec177b3b854 (diff) | |
| download | rails-3859828d89d378986af0fc2390608b00aad5e912.tar.gz rails-3859828d89d378986af0fc2390608b00aad5e912.tar.bz2 rails-3859828d89d378986af0fc2390608b00aad5e912.zip | |
HTML safety: give a deprecation warning if an array of option tags is passed to select tag. Be sure to join the tag yourself and mark them .html_safe
Diffstat (limited to 'actionpack/lib/action_view/helpers/form_tag_helper.rb')
| -rw-r--r-- | actionpack/lib/action_view/helpers/form_tag_helper.rb | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/actionpack/lib/action_view/helpers/form_tag_helper.rb b/actionpack/lib/action_view/helpers/form_tag_helper.rb index ca100e102e..0d47c6eecb 100644 --- a/actionpack/lib/action_view/helpers/form_tag_helper.rb +++ b/actionpack/lib/action_view/helpers/form_tag_helper.rb @@ -93,6 +93,10 @@ module ActionView # # => <select disabled="disabled" id="destination" name="destination"><option>NYC</option> # # <option>Paris</option><option>Rome</option></select> def select_tag(name, option_tags = nil, options = {}) + if Array === option_tags + ActiveSupport::Deprecation.warn 'Passing an array of option_tags to select_tag implicitly joins them without marking them as HTML-safe. Pass option_tags.join.html_safe instead.', caller + end + html_name = (options[:multiple] == true && !name.to_s.ends_with?("[]")) ? "#{name}[]" : name if blank = options.delete(:include_blank) if blank.kind_of?(String) |