aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_view/helpers/form_options_helper.rb
diff options
context:
space:
mode:
authorDavid Heinemeier Hansson <david@loudthinking.com>2005-04-17 09:44:28 +0000
committerDavid Heinemeier Hansson <david@loudthinking.com>2005-04-17 09:44:28 +0000
commit8e8bf37aa9ff4a32838ac477f97b458e9b99da7e (patch)
tree5c5e7a0cc33cb01dd681a677454faa7bbfa4c833 /actionpack/lib/action_view/helpers/form_options_helper.rb
parentba96827b3d05396b11491e36590c52a407ddb8a2 (diff)
downloadrails-8e8bf37aa9ff4a32838ac477f97b458e9b99da7e.tar.gz
rails-8e8bf37aa9ff4a32838ac477f97b458e9b99da7e.tar.bz2
rails-8e8bf37aa9ff4a32838ac477f97b458e9b99da7e.zip
Fixed DateHelper to return values on the option tags such that they'll work properly in IE with form_remote_tag #1024 [rscottmace@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
Diffstat (limited to 'actionpack/lib/action_view/helpers/form_options_helper.rb')
-rw-r--r--actionpack/lib/action_view/helpers/form_options_helper.rb8
1 files changed, 4 insertions, 4 deletions
diff --git a/actionpack/lib/action_view/helpers/form_options_helper.rb b/actionpack/lib/action_view/helpers/form_options_helper.rb
index fd8a347cb0..fe86accf25 100644
--- a/actionpack/lib/action_view/helpers/form_options_helper.rb
+++ b/actionpack/lib/action_view/helpers/form_options_helper.rb
@@ -92,7 +92,7 @@ module ActionView
else
is_selected = ( (selected.respond_to?(:include?) ? selected.include?(element) : element == selected) )
is_selected = ( (selected.respond_to?(:include?) && !selected.is_a?(String) ? selected.include?(element) : element == selected) )
- options << ((is_selected) ? "<option selected=\"selected\">#{html_escape(element.to_s)}</option>" : "<option>#{html_escape(element.to_s)}</option>")
+ options << ((is_selected) ? "<option value=\"#{html_escape(element.to_s)}\" selected=\"selected\">#{html_escape(element.to_s)}</option>" : "<option value=\"#{html_escape(element.to_s)}\">#{html_escape(element.to_s)}</option>")
end
end
@@ -168,7 +168,7 @@ module ActionView
if priority_countries
country_options += options_for_select(priority_countries, selected)
- country_options += "<option>-------------</option>\n"
+ country_options += "<option value=\"\">-------------</option>\n"
end
if priority_countries && priority_countries.include?(selected)
@@ -205,7 +205,7 @@ module ActionView
if priority_zones
zone_options += options_for_select(convert_zones[priority_zones], selected)
- zone_options += "<option>-------------</option>\n"
+ zone_options += "<option value=\"\">-------------</option>\n"
zones = zones.reject { |z| priority_zones.include?( z ) }
end
@@ -298,7 +298,7 @@ module ActionView
private
def add_blank_option(option_tags, add_blank)
- add_blank ? "<option></option>\n" + option_tags : option_tags
+ add_blank ? "<option value=\"\"></option>\n" + option_tags : option_tags
end
end
end