aboutsummaryrefslogtreecommitdiffstats
path: root/actionmailer
diff options
context:
space:
mode:
authorJeremy Kemper <jeremy@bitsweat.net>2006-11-13 05:03:48 +0000
committerJeremy Kemper <jeremy@bitsweat.net>2006-11-13 05:03:48 +0000
commitc3ff04b05db1da913640481b79f75e51e804ed11 (patch)
tree5a9de9f2783b5186fab69eeaaeb44937f7a83ea8 /actionmailer
parentf0753992ab8cc9bbbf9b047fdc56f8899df5635e (diff)
downloadrails-c3ff04b05db1da913640481b79f75e51e804ed11.tar.gz
rails-c3ff04b05db1da913640481b79f75e51e804ed11.tar.bz2
rails-c3ff04b05db1da913640481b79f75e51e804ed11.zip
Allow mailer actions named send by using __send__ internally. Closes #6467.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5505 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
Diffstat (limited to 'actionmailer')
-rw-r--r--actionmailer/CHANGELOG2
-rw-r--r--actionmailer/lib/action_mailer/base.rb4
-rwxr-xr-xactionmailer/test/mail_service_test.rb22
3 files changed, 26 insertions, 2 deletions
diff --git a/actionmailer/CHANGELOG b/actionmailer/CHANGELOG
index c876c05333..2942a9c072 100644
--- a/actionmailer/CHANGELOG
+++ b/actionmailer/CHANGELOG
@@ -1,5 +1,7 @@
*SVN*
+* Allow mailer actions named send by using __send__ internally. #6467 [iGEL]
+
* Add assert_emails and assert_no_emails to test the number of emails delivered. #6479 [Jonathan Viney]
# Assert total number of emails delivered:
assert_emails 0
diff --git a/actionmailer/lib/action_mailer/base.rb b/actionmailer/lib/action_mailer/base.rb
index 444bea95e0..b256016d94 100644
--- a/actionmailer/lib/action_mailer/base.rb
+++ b/actionmailer/lib/action_mailer/base.rb
@@ -369,7 +369,7 @@ module ActionMailer #:nodoc:
# rendered and a new TMail::Mail object created.
def create!(method_name, *parameters) #:nodoc:
initialize_defaults(method_name)
- send(method_name, *parameters)
+ __send__(method_name, *parameters)
# If an explicit, textual body has not been set, we check assumptions.
unless String === @body
@@ -428,7 +428,7 @@ module ActionMailer #:nodoc:
logger.info "Sent mail:\n #{mail.encoded}" unless logger.nil?
begin
- send("perform_delivery_#{delivery_method}", mail) if perform_deliveries
+ __send__("perform_delivery_#{delivery_method}", mail) if perform_deliveries
rescue Exception => e # Net::SMTP errors or sendmail pipe errors
raise e if raise_delivery_errors
end
diff --git a/actionmailer/test/mail_service_test.rb b/actionmailer/test/mail_service_test.rb
index ccded61b7c..7b1ec68725 100755
--- a/actionmailer/test/mail_service_test.rb
+++ b/actionmailer/test/mail_service_test.rb
@@ -801,3 +801,25 @@ class InheritableTemplateRootTest < Test::Unit::TestCase
assert_equal expected, FunkyPathMailer.template_root
end
end
+
+class MethodNamingTest < Test::Unit::TestCase
+ class TestMailer < ActionMailer::Base
+ def send
+ body 'foo'
+ end
+ end
+
+ def setup
+ ActionMailer::Base.delivery_method = :test
+ ActionMailer::Base.perform_deliveries = true
+ ActionMailer::Base.deliveries = []
+ end
+
+ def test_send_method
+ assert_nothing_raised do
+ assert_emails 1 do
+ TestMailer.deliver_send
+ end
+ end
+ end
+end