diff options
author | Xavier Noria <fxn@hashref.com> | 2013-05-11 01:28:06 +0200 |
---|---|---|
committer | Xavier Noria <fxn@hashref.com> | 2013-05-11 01:28:06 +0200 |
commit | 0549ebea223beeb68c09ac9656579f02e893c0f7 (patch) | |
tree | 8182e9fd3554b08e40cab9d7f13259f62a12f6c3 | |
parent | 0be27b709bd62a2dc5c8998adbfd993ec06790ac (diff) | |
download | rails-0549ebea223beeb68c09ac9656579f02e893c0f7.tar.gz rails-0549ebea223beeb68c09ac9656579f02e893c0f7.tar.bz2 rails-0549ebea223beeb68c09ac9656579f02e893c0f7.zip |
Revert "Don't try to EXPLAIN select_db calls"
Reason: This was backported, but the test does not pass as is.
This reverts commit a33d320cf4b57fabd9c299b09c217ee3955ecc77.
-rw-r--r-- | activerecord/lib/active_record/explain_subscriber.rb | 2 | ||||
-rw-r--r-- | activerecord/test/cases/explain_subscriber_test.rb | 7 |
2 files changed, 1 insertions, 8 deletions
diff --git a/activerecord/lib/active_record/explain_subscriber.rb b/activerecord/lib/active_record/explain_subscriber.rb index 1d861a57db..859c8edfc5 100644 --- a/activerecord/lib/active_record/explain_subscriber.rb +++ b/activerecord/lib/active_record/explain_subscriber.rb @@ -15,7 +15,7 @@ module ActiveRecord # On the other hand, we want to monitor the performance of our real database # queries, not the performance of the access to the query cache. IGNORED_PAYLOADS = %w(SCHEMA EXPLAIN CACHE) - EXPLAINED_SQLS = /\A\s*(select|update|delete|insert)\b/i + EXPLAINED_SQLS = /\A\s*(select|update|delete|insert)/i def ignore_payload?(payload) payload[:exception] || IGNORED_PAYLOADS.include?(payload[:name]) || payload[:sql] !~ EXPLAINED_SQLS end diff --git a/activerecord/test/cases/explain_subscriber_test.rb b/activerecord/test/cases/explain_subscriber_test.rb index f929ddd79e..7b852a625d 100644 --- a/activerecord/test/cases/explain_subscriber_test.rb +++ b/activerecord/test/cases/explain_subscriber_test.rb @@ -38,13 +38,6 @@ if ActiveRecord::Base.connection.supports_explain? end end - def test_collects_nothing_if_the_statement_is_only_partially_matched - with_queries([]) do |queries| - SUBSCRIBER.finish(:name => 'SQL', :sql => 'select_db yo_mama') - assert queries.empty? - end - end - def test_collects_nothing_if_unexplained_sqls with_queries([]) do |queries| SUBSCRIBER.call(:name => 'SQL', :sql => 'SHOW max_identifier_length') |