| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| | * | | close the eventual open tool if the other opens | marijus | 2014-11-01 | 1 | -2/+2 | |
| | | | | ||||||
| * | | | PostgreSQL support initial commit | Habeas Codice | 2014-11-13 | 3 | -2/+4 | |
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres) | |||||
| * | | do not reload page for photo upload | marijus | 2014-10-31 | 8 | -31/+18 | |
| | | | ||||||
| * | | Smarty3 now lives in store | Thomas Willingham | 2014-10-31 | 1 | -4/+0 | |
| | | | ||||||
| * | | more work on photo upload | marijus | 2014-10-31 | 4 | -33/+36 | |
| | | | ||||||
| * | | removing this was not a good idea... | marijus | 2014-10-30 | 1 | -0/+4 | |
| | | | ||||||
| * | | some work on photo upload | marijus | 2014-10-30 | 6 | -61/+61 | |
| | | | ||||||
| * | | change the way tagrm works to allow tag removal on the fly | marijus | 2014-10-28 | 1 | -1/+1 | |
| | | | ||||||
| * | | several unrelated things - auto_follow wasn't working for new accounts, ↵ | friendica | 2014-10-27 | 2 | -8/+21 | |
| | | | | | | | | | error returned in private mention to a collection, and added auto-completion to photo tags; though it only matches people so the hover text is now wrong. Also made the photo edit form XHTML (XML) compliant. | |||||
| * | | do not reload page for edit album and some minor cleanup | marijus | 2014-10-27 | 6 | -30/+20 | |
| | | | ||||||
| * | | update nl + Terms of Service more prominent in the help files. | Jeroen | 2014-10-27 | 2 | -5927/+6130 | |
| | | | ||||||
| * | | put privacy role selector in settings page. Change visibility of various ↵ | friendica | 2014-10-26 | 3 | -28/+38 | |
| | | | | | | | | | permissions items accordingly. | |||||
| * | | wrong vars in template | marijus | 2014-10-26 | 1 | -2/+2 | |
| | | | ||||||
| * | | some work on photos like/dislike | marijus | 2014-10-25 | 2 | -11/+77 | |
| | | | ||||||
| * | | don't offer forum (@name+) completion in comments, since it won't do anything. | friendica | 2014-10-23 | 2 | -3/+3 | |
| | | | ||||||
| * | | upd nl 2 | Jeroen | 2014-10-23 | 2 | -19/+19 | |
| | | | ||||||
| * | | upd nl | Jeroen | 2014-10-23 | 2 | -6219/+6071 | |
| | | | ||||||
| * | | update to German strings | zottel | 2014-10-23 | 2 | -6299/+6107 | |
| | | | ||||||
| * | | Merge pull request #655 from pafcu/master | RedMatrix | 2014-10-22 | 1 | -0/+1 | |
| |\| | | | | | Better handling of incorrect info entered in event | |||||
| | * | If entered event info is not valid, let user try again with the old info ↵ | Stefan Parviainen | 2014-10-21 | 1 | -0/+1 | |
| | | | | | | | | | still there. Closes friendica/red#648 | |||||
| * | | fix nav double dropdown | marijus | 2014-10-21 | 1 | -4/+8 | |
| | | | ||||||
| * | | minor correction and typo | marijus | 2014-10-20 | 2 | -5/+5 | |
| |/ | ||||||
| * | not quite there yet but getting closer | marijus | 2014-10-20 | 3 | -114/+95 | |
| | | ||||||
| * | more work on photos | marijus | 2014-10-20 | 2 | -46/+43 | |
| | | ||||||
| * | link tag closed prematurely | friendica | 2014-10-19 | 2 | -3/+3 | |
| | | ||||||
| * | merge madness | friendica | 2014-10-19 | 3 | -93/+17 | |
| | | ||||||
| * | mark signature forgeries | friendica | 2014-10-16 | 3 | -2/+7 | |
| | | ||||||
| * | Merge branch 'master' of https://github.com/pafcu/red | Stefan Parviainen | 2014-10-16 | 4 | -21/+31 | |
| |\ | ||||||
| | * | missing event permissions | friendica | 2014-10-15 | 2 | -3/+4 | |
| | | | ||||||
| | * | some work on single photo view comments | marijus | 2014-10-15 | 2 | -18/+27 | |
| | | | ||||||
| * | | Login menu | Stefan Parviainen | 2014-10-16 | 1 | -7/+8 | |
| |/ | ||||||
| * | Merge branch 'master' of https://github.com/friendica/red | marijus | 2014-10-13 | 1 | -2/+2 | |
| |\ | ||||||
| | * | tinymce still seems to be referenced. Can't quite get rid of it. | friendica | 2014-10-13 | 1 | -1/+1 | |
| | | | ||||||
| | * | Merge https://github.com/friendica/red into pending_merge | friendica | 2014-10-13 | 1 | -0/+2 | |
| | |\ | ||||||
| | * | | bring back PM upload functionality and why oh why are we still loading tinymce? | friendica | 2014-10-13 | 2 | -3/+3 | |
| | | | | ||||||
| * | | | really fix connedit > collection > checkbox | marijus | 2014-10-13 | 3 | -13/+5 | |
| | |/ |/| | ||||||
| * | | fix connedit > collection > checkbox position also for webkit - this will ↵ | marijus | 2014-10-13 | 1 | -0/+2 | |
| |/ | | | | need a better solution though | |||||
| * | fix connedit > collection > checkbox position | marijus | 2014-10-12 | 2 | -7/+15 | |
| | | ||||||
| * | Show tag in siteinfo. Not useful for us, quite useful for admins. | Thomas Willingham | 2014-10-11 | 1 | -0/+3 | |
| | | ||||||
| * | Also that doesn't work anymore - prettyPhoto relic | Thomas Willingham | 2014-10-11 | 1 | -1/+1 | |
| | | ||||||
| * | Give Redbasic the -styled back | Thomas Willingham | 2014-10-11 | 1 | -1/+1 | |
| | | ||||||
| * | Merge branch 'master' of https://github.com/friendica/red | Thomas Willingham | 2014-10-11 | 1 | -1/+2 | |
| |\ | ||||||
| | * | +1 | Jeroen | 2014-10-11 | 1 | -1/+2 | |
| | | | ||||||
| * | | Unbreak webpages | Thomas Willingham | 2014-10-11 | 1 | -0/+1 | |
| |/ | ||||||
| * | and more missing wrappers | marijus | 2014-10-10 | 18 | -20/+28 | |
| | | ||||||
| * | found more missing wrappers | marijus | 2014-10-10 | 2 | -2/+3 | |
| | | ||||||
| * | one more oups... | marijus | 2014-10-10 | 1 | -2/+2 | |
| | | ||||||
| * | oups... that was weired... | marijus | 2014-10-10 | 1 | -2/+1 | |
| | | ||||||
| * | This is a fix to not interfere the ongoing adding of ↵ | marijus | 2014-10-10 | 15 | -15/+23 | |
| | | | | | | | | .generic-content-wrapper with the ongoing styling of redbasic theme. adding of .generic-content-wrapper is needed and useful for derivative themes but it should not contain any styling information for redbasic theme. therefor i added .generic-content-wrapper-styled as a quickfix for spots where redbasic is not finished yet. Sidenote: please avoid opening a div in one *.tpl and close it in another or (even worse) open a div in a *.tpl and close it in an already templatified mod/*.php. This will really make the code and templates very, very confusing. | |||||
| * | Merge branch 'master' of https://github.com/friendica/red | Jeroen | 2014-10-10 | 111 | -8184/+6868 | |
| |\ | ||||||
 |
index : volse-hubzilla.git | |
| Volse Hubzilla -- soft fork of main Hubzilla core for Volse | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |