aboutsummaryrefslogtreecommitdiffstats
path: root/mod/subthread.php
Commit message (Collapse)AuthorAgeFilesLines
* convert ITEM_WALL from bitfield to standaloneredmatrix2015-05-061-3/+1
|
* remote_user => remote_channelfriendica2015-01-281-1/+1
|
* local_user => local_channelfriendica2015-01-281-1/+1
|
* PostgreSQL support initial commitHabeas Codice2014-11-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres)
* ability to unset a layout and subthread is probably close to working again.friendica2014-04-231-44/+126
|
* subthread is still borked (~75% Friendica code which has never been ↵friendica2014-04-201-5/+5
| | | | translated)- but ported a bit more
* provide detailed error to remote site for the myriad of things that can go ↵friendica2013-09-101-1/+2
| | | | wrong inside item_store(), !! this changes the return of item_store !!
* turn all Red links into zrls (not the old zrls, the new bbcode zrl which ↵friendica2013-04-151-3/+3
| | | | means we can zidify them)
* rev updatefriendica2013-03-231-3/+3
|
* rename 'uri' (and parent_uri) to 'mid' (and parent_mid) since these no ↵friendica2013-03-211-6/+6
| | | | longer remotely resemble uri's and are actually message_id's. This change is potentially destabilising because it touches a lot of code and structure. But it has to get done and there's no better time than the present.
* start to whip the permissions into shape, also got rid of the mce drop ↵friendica2012-12-091-2/+4
| | | | shadow until we can figure out how to do it without the ugly black bars. I tend to prefer "outy" shadows over "inny" shadows anyway, but maybe that's just me.
* Can't see any posts currently - after the big shakeup, but we can now post ↵friendica2012-10-031-1/+1
| | | | top level activities and store them.
* here's where the heavy lifting begins - everything is likely to be broken ↵friendica2012-10-011-0/+160
for quite some time as we add location and db independence to items and conversations and work through the rest of the permissions and how to federate the buggers.