aboutsummaryrefslogtreecommitdiffstats
path: root/mod/profile_photo.php
Commit message (Collapse)AuthorAgeFilesLines
* local_user => local_channelfriendica2015-01-281-22/+22
|
* Fix unescaped image dataHabeas Codice2015-01-101-0/+1
|
* implicit type conversionHabeas Codice2014-11-211-1/+1
|
* PostgreSQL support initial commitHabeas Codice2014-11-131-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres)
* Allows extra content to be inserted at end of profile_photo page. Needed for ↵habeascodice2014-09-281-1/+3
| | | | openclipatar addon.
* Now we also refresh permissions after the user posted connedit.sirius2014-04-201-1/+29
|
* Added permission handling of profile-photossirius2014-04-201-15/+29
| | | | Now we automatically set the appropiate viewing-permissions on profile edit and revert photos chosen as default profile picture bacl to public access.
* Merging in conflictsirius2014-04-161-9/+19
|\
* | Added hackish support for permissions-sync between profile and profile-picturessirius2014-04-141-0/+33
|/
* comanchify all the simple cases - those that only load a profile. Rework ↵friendica2013-12-111-10/+0
| | | | permission checks for the profile sidebar so that it is all done internally. Remove crepair which we aren't using.
* couple of errant SQL queriesfriendica2013-12-051-2/+2
|
* issue #225friendica2013-12-051-1/+1
|
* big changes to photo->store() which is now photo->save() and takes an array ↵friendica2013-08-071-9/+35
| | | | instead of a list of args. Also the beginning of the migration to using photo_flags to indicate special purpose photos such as profile photos and contact photos and "thing" photos.
* photo driver abstractionfriendica2013-04-251-4/+4
|
* we don't need to quote or rename 'default' in mySQL if we just use the ↵friendica2013-02-151-1/+1
| | | | original column name 'is_default'
* Whinging whining stupid fucks.friendica2013-02-121-8/+6
|
* fix profile selector on profile_photo page (unquoted mysql reserved word ↵friendica2013-02-101-3/+3
| | | | 'default')
* partial cleanup of mod/profile_photo - needs a LOT morefriendica2013-02-051-52/+65
|
* clean up the photo storage backend, revamp mod/wall_uploadfriendica2013-01-221-5/+6
|
* more work on notification system, fix a couple of minor issues from smarty ↵friendica2013-01-071-2/+2
| | | | conversion
* implement Smarty3Zach Prezkuta2013-01-061-1/+11
|
* "profile url" e.g. the wall/stream is now "channel url". "Profile URL" goes ↵friendica2012-10-291-1/+1
| | | | to the profile details.
* restore profile_photo functionality after structural changesfriendica2012-10-241-11/+18
|
* here's where the heavy lifting begins - everything is likely to be broken ↵friendica2012-10-011-10/+10
| | | | for quite some time as we add location and db independence to items and conversations and work through the rest of the permissions and how to federate the buggers.
* moving a lot of structure around. 'entity' is now 'channel'friendica2012-09-251-1/+2
|
* unbreak some more stufffriendica2012-09-041-2/+2
|
* more DB cleanupfriendica2012-08-301-2/+2
|
* start on contacts/profilesfriendica2012-08-301-3/+3
|
* stufffriendica2012-08-271-1/+1
|
* Removing connectors we won't be needing - this is probably going to break ↵friendica2012-07-181-2/+0
| | | | some shit.
* front end for alternate profile photosfriendica2012-07-171-1/+9
|
* backend support for alternate profile photos for private profilesfriendica2012-07-171-9/+36
|
* upstream fixes and a lot of taxonomy stufffriendica2012-07-101-1/+7
|
* png support: update database.sql, fix some typos, fix tinymce image browserFabio Comuni2012-06-071-1/+2
|
* Add support for PNG images with alphaFabio Comuni2012-06-071-4/+6
|
* Merge branch 'master' of https://github.com/friendica/friendicaAlexander Kampmann2012-04-051-1/+1
|\ | | | | | | | | | | Conflicts: include/config.php update.php
| * form security error when using existing photofriendica2012-03-271-1/+1
|/
* Some security against XSRF-attacksTobias Hößl2012-03-121-6/+12
|
* add remove_user hook (it looks like dreamhost changed all my file ↵friendica2012-01-181-0/+0
| | | | permissions, this will make a nasty commit)
* warn about photo caching when updating profile picfriendica2011-11-121-0/+1
|
* bug in diaspora_reshareFriendika2011-10-201-0/+3
|
* if photo is uploaded to "profile photos" album it could not be made into ↵Friendika2011-09-151-1/+7
| | | | profile photo.
* add info() function. Works like notice() but show messages in a div with ↵Fabio Comuni2011-05-231-1/+1
| | | | | | | class info-message. update code to use info() instead of notice() when appropriate (non-error message) add info-message class style in themes
* deprecate load_view_fileFriendika2011-05-111-3/+3
|
* don't use load_view_file() except in email templates and install of htconfig ↵Friendika2011-05-101-3/+3
| | | | - to avoid getting wrong file when package is updated by copying over an older version.
* redirect to profile photo upload on very first loginFriendika2011-04-231-1/+6
|
* the rest of the english html templates except for htconfigFriendika2011-04-071-1/+5
|
* more templates goneFriendika2011-03-291-3/+5
|
* Merge branch 'gettext' of https://github.com/fabrixxm/friendika into ↵Friendika2011-03-181-5/+5
|\ | | | | | | fabrixxm-gettext
| * update source stringsfabrixxm2011-03-111-5/+5
| |