aboutsummaryrefslogtreecommitdiffstats
path: root/mod/post.php
Commit message (Collapse)AuthorAgeFilesLines
* PostgreSQL support initial commitHabeas Codice2014-11-131-8/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres)
* check that we have valid datafriendica2014-11-011-10/+16
|
* What this checkin does is catch the case where a comment arrived and there's ↵friendica2014-10-301-1/+15
| | | | a missing top-level post to match it with. So we'll send a request back to the sender that you've never seen this thread and please send a fresh copy of the entire conversation to date. We could soon have posts in the matrix from different platforms from days gone by, which have been migrated into the modern world. We'll be polite and not deliver these to everybody. However, if someone comments on one of these antique threads we wouldn't be able to see it in our own matrix because we won't have a copy of the parent post. So this rectifies that situation. Be aware that item deletion may need to change to keep "hard deleted" items indefinitely so that they don't keep coming back. We'll have to null out the important data of the former item to accomplish the deletion aspect.
* some backend work for the remaining missing bits of mod_hubman - this is ↵friendica2014-09-131-2/+2
| | | | still a fair ways from being complete and is not ready for prime time. Basically we'll let a channel send out a public message saying "these are my currently approved locations" and anything that isn't in the list will be marked deleted. We'll send out this message when locations change somehow - either through direct personal involvement (hub revoke, change primary, channel import) or during a system rename or "find bad/obsolete hublocs" activity. This way we won't have clones sending back location info we just got rid of and re-importing the bad entries.
* clean up more code duplicationfriendica2014-07-141-4/+6
|
* visage tracking opt-in/opt-outfriendica2014-07-031-0/+8
|
* session DNT - if you want it use it.friendica2014-07-031-0/+4
|
* cleanup dead directory entries. This was a real b#tch, so keep your eye out ↵friendica2014-05-281-0/+22
| | | | for issues - which you shouldn't see until next weekend when this is scheduled to run. We're only setting flags, so if anything goes wrong we should be able to recover without too much pain.
* log pickupsfriendica2014-05-051-0/+2
|
* Include the entire original item when notifying other channels of deletions ↵friendica2014-04-101-1/+1
| | | | as it contains important routing and scope information. Previously we were only sending a couple of critical fields like the message-id, flags, and creation date. The thinking was that it is deleted, let's not resend the deleted contents anywhere. But in order to route this through the same path the original post took we really need the entire original post with all of its baggage attached.
* json_return_and_dir isn't a thingThomas Willingham2014-03-131-1/+1
|
* json_return_and_dir is a typofriendica2014-03-121-1/+1
|
* fix third-party zid'sfriendica2014-03-041-0/+1
|
* rev update and a minor fix (missing param) to force_refreshfriendica2014-02-141-1/+1
|
* implement a forced directory update mode where we unconditionally create a ↵friendica2014-02-111-4/+7
| | | | directory sync packet. This is needed to ensure that monthly directory pings are propagated to other directory servers so they can each prove for themselves whether or not an account is alive or dead. We do not trust other directories to provide us information beyond "look at this entry and decide for yourself" as doing otherwise would invite rogue directory manipulations. As this scheduled update occurs on all channels across all servers, we should also pick up refresh messages from all existing channel clones and these should also propagate out to all directory servers using the same mechanism (though perhaps not at the same time).
* started analysis of ping response and clean up more loggerMichael Meer2014-01-301-5/+5
|
* to make visible what I try, ping still won't work, but I'm confused about ↵Michael Meer2014-01-281-0/+2
| | | | get_channel
* add a temporary logger command at remote server sideMichael Meer2014-01-271-0/+1
|
* add account_level, is_foreigner and is_member functions; convert all e2ee ↵friendica2013-12-231-0/+5
| | | | user input and prompts to hex to avoid javascipt's lame handling of quotes. !!This breaks all prior encrypted posts.!!
* authtest: do a better job of success/failure indicationfriendica2013-12-171-1/+1
|
* couple of additional checksfriendica2013-12-051-1/+12
|
* mod_authtest --- magic-auth diagnostic for those that are too freaking ↵friendica2013-12-051-2/+62
| | | | important to read logs or code and expect others to be able to debug complex authentication transactions with no information beyond "it didn't work". This will provide a transaction report including both sides of the exchange that you can paste into a bug report and that a developer can actually figure out where in the transaction that things went wrong and maybe even be able to then figure out why.
* generate a small amount of entropy to avoid duplicate notifications from ↵friendica2013-12-041-2/+4
| | | | essentially simultaneous deliveries.
* include re-organisation and more doco, post_to_red fix ampersands in categoriesfriendica2013-12-041-2/+2
|
* on successful magic-auth, put remote_service_class and remote_hub into the ↵friendica2013-12-031-4/+21
| | | | session
* more work on magic-authfriendica2013-12-021-2/+15
|
* magic-auth re-factorfriendica2013-12-021-112/+105
|
* refactor magic-authfriendica2013-12-021-17/+5
|
* file corruptionfriendica2013-12-011-122/+0
|
* document the ping packet - and remove the ancient rusty brown square default ↵friendica2013-12-011-10/+165
| | | | profile photos.
* don't magic-auth against a deleted channelfriendica2013-12-011-9/+14
|
* magic auth fix plus docofriendica2013-12-011-2/+75
|
* zot documentation inline in the code where we need it most.friendica2013-12-011-0/+120
|
* mark hublocs with incorrect sitekeys deletedfriendica2013-11-211-0/+14
|
* Protocol: now set data['alg'] on all encapsulated encrypted packets, so that ↵friendica2013-11-201-2/+2
| | | | we can more easily retire 'aes256cbc' once it is no longer viable.
* set a default value for $webbie - it's the right thing to do.friendica2013-11-181-0/+2
|
* to clarify the fact, we'll remove the line we no longer need instead of ↵friendica2013-11-181-1/+0
| | | | commenting it
* change the way magic-auth works - we rarely need a destination channel and ↵friendica2013-11-181-106/+105
| | | | | | if that channel has problems it shouldn't mess up authentication to the hub.
* magic auth issuesfriendica2013-11-171-3/+3
|
* document extra featuresfriendica2013-11-171-2/+2
|
* Fix name of BleichenbacherOlaf Conradi2013-09-241-2/+2
|
* reduce susceptibility to bleichenberger attackfriendica2013-09-241-6/+18
|
* more remote error reporting for zotfriendica2013-09-121-0/+11
|
* implement tip from Mike, corrected the sql statementMichael Meer2013-09-111-1/+1
|
* flag failed auth attempts in DB table hublocMichael Meer2013-09-111-0/+6
|
* implement a 'ping' message type to respond if we're still here and whether ↵friendica2013-08-291-0/+13
| | | | our URL or keys have changed.
* start timestamping hubloc connections so we can eventually remove dead onesfriendica2013-08-241-1/+11
|
* progress on unfriendingfriendica2013-08-041-6/+15
|
* fix for multiple hublocs and incoming magic authfriendica2013-05-291-2/+2
|
* we don't need every hubloc for the site, only those that have different keysfriendica2013-05-161-1/+1
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-20 12:49:57 +0000