aboutsummaryrefslogtreecommitdiffstats
path: root/mod/openid.php
Commit message (Collapse)AuthorAgeFilesLines
* PostgreSQL support initial commitHabeas Codice2014-11-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres)
* try and guess mimetype for openid profile photofriendica2014-10-051-1/+3
|
* fix third-party zid'sfriendica2014-03-041-0/+2
|
* minor stuff, some doco, auth cleanup, and make "unknown" more translateable ↵friendica2014-02-221-0/+1
| | | | by context.
* introduce a new privacy level "PERMS_AUTHED" to indicate somebody that is ↵friendica2014-02-181-8/+60
| | | | able to successfully authenticate (but is not necessarily in this network).
* some more snakebite and fix up include/account - forgot about that inline ↵friendica2014-02-181-14/+37
| | | | array stuff
* edit bookmarksfriendica2014-02-181-1/+1
|
* remove the exit clausefriendica2014-02-171-6/+0
|
* snakebite, cont. magic-auth via openid is now possible, with the caveat that ↵friendica2014-02-171-2/+20
| | | | one needs a hand-crafted xchan at the moment to make use of it and if you wish to do so, there will be no assistance or help provided. The risk of system instability and mangled DBs now and going forward is significant if you try this.
* operation snakebite continued. openid now works for local accounts using the ↵friendica2014-02-171-0/+101
| | | | rmagic module and after storing your openid in pconfig. This is just an interesting but trivial (in the bigger scheme of things) side effect of snakebite. The snake hasn't even waken up yet.
* trim a bit of fatfriendica2012-08-291-96/+0
|
* Merge branch 'master' of https://github.com/friendica/friendicaAlexander Kampmann2012-04-051-0/+0
| | | | | | Conflicts: include/config.php update.php
* cleanup after openid refactoringfriendica2012-03-191-1/+6
|
* refactor openid logins/registrationsfriendica2012-03-191-51/+55
|
* some openid fixes, use identity url from openid server and normalise it.friendica2012-03-191-1/+8
|
* add remove_user hook (it looks like dreamhost changed all my file ↵friendica2012-01-181-0/+0
| | | | permissions, this will make a nasty commit)
* modularise successful authenticationfriendica2012-01-121-51/+5
|
* account expiration structuresFriendika2011-09-181-1/+1
|
* missing salmon key? report it.Friendika2011-08-241-1/+2
|
* some more zot changes migrating back to f9a mainlineFriendika2011-08-011-5/+5
|
* Merge branch 'fabrixxm-master'Friendika2011-05-231-4/+4
|\ | | | | | | | | Conflicts: boot.php
| * add info() function. Works like notice() but show messages in a div with ↵Fabio Comuni2011-05-231-4/+4
| | | | | | | | | | | | | | class info-message. update code to use info() instead of notice() when appropriate (non-error message) add info-message class style in themes
* | improved browser language detect, set user language on loginFriendika2011-05-231-1/+5
|/
* redirect to profile photo upload on very first loginFriendika2011-04-231-1/+10
|
* update source stringsfabrixxm2011-03-111-1/+1
|
* switch identities to manage pagesFriendika2011-03-011-2/+10
|
* birthday notifications workingFriendika2011-01-131-1/+4
|
* register/login timestampsFriendika2010-12-161-0/+5
|
* localise login template, allow openid to be disabledFriendika2010-11-281-0/+4
|
* use optional openid photo for registration - if suppliedFriendika2010-11-231-0/+9
|
* openid registrationFriendika2010-11-171-0/+31
|
* openid logins workingFriendika2010-11-171-0/+52