aboutsummaryrefslogtreecommitdiffstats
path: root/mod/network.php
Commit message (Collapse)AuthorAgeFilesLines
* PostgreSQL support initial commitHabeas Codice2014-11-131-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres)
* better way to deal with effective_uidfriendica2014-09-221-2/+2
|
* make discover items interactivefriendica2014-09-221-1/+1
|
* sql string unquotedfriendica2014-07-221-1/+1
|
* the "page 2 shows up on top of page 1 when you wake up in the morning" bug. ↵friendica2014-07-211-0/+17
| | | | See the comments.
* get rid of some old crapfriendica2014-06-171-57/+4
|
* change the way jot tools are displayed/hiddenmarijus2014-04-081-1/+1
|
* Missed oneThomas Willingham2014-03-301-1/+1
|
* Default discover to on.Thomas Willingham2014-03-301-1/+1
|
* Let the site admin choose whether to display the Discover tab.Alexandre Hannud Abdo2014-03-301-1/+1
|
* firehose fixes and optimisations. In particular get rid of the unresponsive ↵friendica2014-03-271-14/+16
| | | | script warning when trying to load updates (sine they aren't our posts, we can't check for unseen, hence we can't really load updates). Also make the url selection pluggable.
* superfluous commafriendica2014-03-271-2/+1
|
* catch the "new" view as wellfriendica2014-03-261-3/+3
|
* firehose testing (network?f=&fh=1) - some possible security bugs so testing ↵friendica2014-03-261-9/+19
| | | | purposes only
* preparatory work for supporting a "list view" mode for conversations. This ↵friendica2014-01-081-0/+1
| | | | would be useful for forum-like channels and/or block-oriented themes.
* remove a couple of mysql reserved words from being used as table or row ↵friendica2013-12-221-1/+1
| | | | names. For this round we're getting 'group' and 'desc'. Warning: potentially destabilising as this touches a lot of code.
* check that every invocation of htmlspecialchars has the right arg listfriendica2013-12-121-1/+1
|
* The affinity tool is not a "traditional" widget. But it is nevertheless a ↵friendica2013-12-111-25/+0
| | | | widget. It just makes fewer page layout decisions which are hard-coded. If you want to shrink it down and put it on the sidebar in your theme, go for it.
* mod_network is now running under Comanche. Yay.friendica2013-12-101-9/+0
|
* we're almost ready to turn on comanche for mod_network. All the widgets are ↵friendica2013-12-101-107/+24
| | | | done.
* comanchify the savedsearch widgetfriendica2013-12-091-3/+3
|
* notes widgetfriendica2013-12-091-1/+1
|
* suggestion widget tweaked to make it comanche capable. Remove old versions ↵friendica2013-12-081-2/+2
| | | | of specs that are so obsolete it isn't funny. Zot protocol reference is in red's github wiki, and in the code. We should move the github copy to /doc once it is updated to match the code. There's no point in documenting dfrn in the red code base.
* transition to $a->set_widget in /network on the short term - long term this ↵friendica2013-12-081-5/+5
| | | | will be in view/pdl files
* starting on the journey to comanche everywhere - beginning with widget ↵friendica2013-12-081-2/+2
| | | | conversions. There are approximately 20 which need to be wrapped for accessibility to comanche.
* suggestion widgetfriendica2013-12-061-0/+1
|
* move profile tabs and network/matrix tabs to include/conversationfriendica2013-12-051-125/+2
|
* remove some cruftfriendica2013-12-051-69/+5
|
* make some "selection-is-selected" classes work againfriendica2013-12-051-1/+1
|
* issue #224friendica2013-12-051-0/+6
|
* quite a bit of work on default acl permissions and various acl quirksfriendica2013-11-291-17/+23
|
* pull in some posts when we first connect with a new channel (if allowed to) ↵friendica2013-11-171-2/+2
| | | | - if not allowed to, do it if that condition changes
* Saved searches on the matrix/network page just got a lot more interesting. ↵friendica2013-10-011-3/+26
| | | | Hint: it's all about autocomplete
* Issue #158friendica2013-09-291-3/+3
|
* hopefully this will go over a bit better - check post owner permissions as ↵friendica2013-09-201-1/+1
| | | | well as local owner permissions for comments during submission, since the comment was being blindly accepted on the local system due to only checking the profile owner. Also change collections query to include only top-level posts by a member of the collection.
* make collections work againfriendica2013-09-181-4/+9
|
* fix network search - except it can't search private posts. That may be a ↵friendica2013-09-051-1/+2
| | | | problem.
* silence some warnings at php E_ALL levelsfriendica2013-08-281-5/+7
|
* bring back mail list and cleanup some issues which popped out with full PHP ↵friendica2013-08-271-1/+1
| | | | warnings
* move js from matrix pagefriendica2013-08-151-17/+0
|
* add logging to matrix page load because I don't want to spend a week telling ↵friendica2013-07-221-0/+2
| | | | somebody how to determine if it found anything. Now it will just take a week to tell them how to turn on LOGGER_ALL and read the logfile.
* configurable theme precedence rules, and passing the page owner to the pcss ↵friendica2013-07-171-0/+1
| | | | theme settings.
* use current channel photo for favicon where applicable - might be browser ↵friendica2013-07-071-0/+3
| | | | dependent but seems to work on FF
* fix cid queryfriendica2013-06-271-1/+1
|
* fix location setting stufffriendica2013-05-281-1/+1
|
* didn't realise that collections (search by group) and search by contact ↵friendica2013-05-221-26/+26
| | | | weren't working on the matrix/network page and had never been properly ported. They're now ported - whether or not they work is another matter.
* uri to midfriendica2013-03-251-1/+1
|
* main_slider hookfriendica2013-03-211-1/+4
|
* progress on tag deliveryfriendica2013-02-111-2/+2
|
* reduce itemspage for better interactive performancefriendica2013-02-101-1/+1
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-21 02:56:10 +0000