aboutsummaryrefslogtreecommitdiffstats
path: root/mod/like.php
Commit message (Collapse)AuthorAgeFilesLines
* PostgreSQL support initial commitHabeas Codice2014-11-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres)
* use intval rather than dbesc since these are ints. Should work regardless, ↵friendica2014-10-261-2/+2
| | | | but this makes it consistent with the way we do most other queries.
* allow photos without comments to be likedfriendica2014-10-261-2/+15
|
* provide a specific permission for liking profiles (reuse the obsolete ↵friendica2014-07-171-1/+1
| | | | bookmark permission), also remove the unused 'unconnected contacts' view for now.
* better handling of interactive likesfriendica2014-07-171-13/+14
|
* confirm that something was done.friendica2014-07-171-0/+8
|
* make mod_like interactive if requestedfriendica2014-07-171-6/+43
|
* ability to like thingsfriendica2014-06-231-3/+8
|
* profile likesfriendica2014-06-221-60/+172
|
* honour the admin censored flag in the directory, and some slow progress on ↵friendica2014-06-221-57/+124
| | | | extended likes
* possible fix for issue #398friendica2014-04-071-3/+11
|
* some minor cleanup on plinks for some very subtle permissions issuesfriendica2014-01-091-0/+1
|
* provide detailed error to remote site for the myriad of things that can go ↵friendica2013-09-101-1/+2
| | | | wrong inside item_store(), !! this changes the return of item_store !!
* issue #106friendica2013-08-281-1/+1
|
* localize_item() thinks all likes on posts are likes on comments because we ↵friendica2013-08-191-0/+1
| | | | didn't pass any info in the activity object to distinguish them from each other.
* infrastructure for future stufffriendica2013-06-191-2/+1
|
* wrong attribution on likes of comments in email notifications. Let's also ↵friendica2013-05-281-1/+4
| | | | call the thing they liked a comment instead of a status
* turn all Red links into zrls (not the old zrls, the new bbcode zrl which ↵friendica2013-04-151-3/+3
| | | | means we can zidify them)
* magic auth docofriendica2013-04-101-1/+1
|
* wrapper function to create arbitrary activities (e.g. for plugins and apps) ↵friendica2013-04-041-0/+2
| | | | with a minimal amount of fuss, though the amount of fuss could increase significantly depending on the nature of the activity. For a simple wall post, just set the $arr['body'] to the desired text and we'll do the rest. If the activity requires special verbs, objects or targets, these will all need to be constructed.
* liking comments were reverted to liking the parent after sending item to ↵friendica2013-04-031-0/+2
| | | | another channel
* rename 'uri' (and parent_uri) to 'mid' (and parent_mid) since these no ↵friendica2013-03-211-8/+8
| | | | longer remotely resemble uri's and are actually message_id's. This change is potentially destabilising because it touches a lot of code and structure. But it has to get done and there's no better time than the present.
* likes were somewhat confused. Unconfuse them.friendica2013-03-111-2/+2
|
* owner's like reversed instead of observer's.friendica2013-02-051-56/+4
|
* finish off like/dislike localisation except for zrl/magic_linkfriendica2012-11-061-1/+1
|
* add author info to like activity object for localisationfriendica2012-11-061-21/+39
|
* likes working a bit better - not translateable yetfriendica2012-11-061-7/+12
|
* likes are quasi working again - at least an activity item is stored and it ↵friendica2012-11-051-45/+36
| | | | mostly has correct data, but displaying it needs improvement.
* start on the like/dislike activitiesfriendica2012-11-051-69/+75
|
* Can't see any posts currently - after the big shakeup, but we can now post ↵friendica2012-10-031-1/+1
| | | | top level activities and store them.
* here's where the heavy lifting begins - everything is likely to be broken ↵friendica2012-10-011-4/+4
| | | | for quite some time as we add location and db independence to items and conversations and work through the rest of the permissions and how to federate the buggers.
* item table rename parent-uri, target-type, object-type (more to come later)friendica2012-08-151-3/+3
|
* eliminate the obsolete "last-child" indicatorfriendica2012-07-181-1/+0
|
* Removing connectors we won't be needing - this is probably going to break ↵friendica2012-07-181-137/+1
| | | | some shit.
* updatesfriendica2012-07-141-1/+1
|
* merge upstream, slider work, refactor ping module, language selection workfriendica2012-07-131-2/+3
|
* catchupfriendica2012-07-101-8/+0
|
* remove possibly unnecessary checks for likes or comments created by Diaspora ↵Zach Prezkuta2012-06-251-42/+42
| | | | users
* store signature info for remote users tooZach Prezkuta2012-06-251-2/+4
|
* was passing the wrong arguments to the signature storage functionZach Prezkuta2012-06-251-1/+1
|
* add some debug loggingZach Prezkuta2012-06-251-2/+6
|
* Clean up the Diaspora connectivity:Zach Prezkuta2012-06-251-55/+83
| | | | | - Move Diaspora code into separate functions to make it more modular - Create more checks for whether Diaspora connectivity has been enabled
* like commentsfriendica2012-06-231-1/+2
|
* Debugged implementation of Diaspora relayable_retractionsZach Prezkuta2012-06-031-27/+35
| | | | | | | | | | | | | | | | | | | | | | | | Diaspora "relayable_retraction" is now supported by Friendica. The following should now work: Friendica top-level post: Diaspora comment deleted, disappears in Friendica Friendica comment deleted, disappears in Diaspora Diaspora like retracted, disappears in Friendica Friendica like retracted, disappears in Diaspora Diaspora top-level post: Same There are still exceptions, however. First, Friendica and Diaspora seem to frequently reject comments with an "invalid signature" error. This can probably be fixed. Also, some comments/likes/retractions seem to just disappear on the Diaspora side. In the Diaspora log these seem to be accompanied by a "not a valid object" error, often preceeded by a "received a comment but no corresponding post" error. These seem to be purely internal, since sometimes it works for some Diaspora contacts but not others.
* first shot at getting like/unlike functions to work consistentlyZach Prezkuta2012-06-031-2/+111
|
* Merge branch 'master' of https://github.com/friendica/friendicaAlexander Kampmann2012-04-051-0/+0
| | | | | | Conflicts: include/config.php update.php
* add remove_user hook (it looks like dreamhost changed all my file ↵friendica2012-01-181-0/+0
| | | | permissions, this will make a nasty commit)
* social tag - add UIFriendika2011-10-241-1/+2
|
* origin flag handling, and bug #137 - provide timezone conversion for events ↵Friendika2011-10-171-1/+2
| | | | posted across to Diaspora
* w3c compliance fixes, owner attribution on likes defaulting to local owner, ↵Friendika2011-09-231-3/+24
| | | | not item creator
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-15 14:23:28 +0000