aboutsummaryrefslogtreecommitdiffstats
path: root/mod/item.php
Commit message (Collapse)AuthorAgeFilesLines
* Merge remote-tracking branch 'upstream/master'Habeas Codice2014-11-131-14/+24
|\ | | | | | | | | | | | | | | | | | | | | | | Conflicts: boot.php include/dba/dba_driver.php include/diaspora.php include/follow.php include/session.php include/zot.php mod/photos.php mod/ping.php
| * some more work on sys publishingfriendica2014-11-111-11/+10
| |
| * a couple of places where we need to look for a sys channel euid.friendica2014-11-111-10/+18
| |
| * wall posted comment to a top-level wall post which arrived via a route (e.g. ↵friendica2014-11-031-0/+3
| | | | | | | | was posted to a forum) had no route, hence downstream recipients report route mismatch
* | PostgreSQL support initial commitHabeas Codice2014-11-131-3/+3
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres)
* if any privacy tags are created on a top level post, restrict the post; ↵friendica2014-10-281-1/+14
| | | | since it could have been quite sensitive. If there were errors processing the actual tag restrict the post to the profile owner. Also make the "privacy tag over-rides ACL" behaviour configurable. Default is that privacy tags over-ride the ACL.
* several unrelated things - auto_follow wasn't working for new accounts, ↵friendica2014-10-271-1/+2
| | | | error returned in private mention to a collection, and added auto-completion to photo tags; though it only matches people so the hover text is now wrong. Also made the photo edit form XHTML (XML) compliant.
* Issue #661Thomas Willingham2014-10-241-1/+1
|
* improved wall-to-wall detection for comments so we can handle Diaspora ↵friendica2014-10-221-6/+16
| | | | | | | signing and wall-to-wall attribution correctly. Do it at the point of submission. This also fixes a potential bug in yesterday's wall-to-wall permission setting, if it was a local comment to a remote post.
* private forum issuesfriendica2014-10-211-0/+15
|
* fix diaspora reshare tagsfriendica2014-10-101-1/+1
|
* add 'nopush' option to the post API so somebody could bulk load a bunch of ↵friendica2014-10-051-9/+16
| | | | existing content via the API without invoking the notifier and sending each out as a fresh post.
* try to sort out walltowall translation for diaspora recipientsfriendica2014-09-191-1/+3
|
* This is long overdue - use a symblic constant NULL_DATE instead of the ↵friendica2014-09-081-2/+2
| | | | easily mis-typed sequence '0000-00-00 00:00:00'
* provide a config option to prevent wall uploads (photos and files) from ↵friendica2014-09-021-0/+9
| | | | being set to the same ACL as the containing post, and instead are uploaded with public visibility (no ACL). This is to prevent folks on other networks from seeing prohibited signs for things uploaded into a private conversation. It is primarily useful when posting to collections that have mixed folks from red and other networks and an otherwise public (typical) profile. Consequently, these uploads will match your chosen default visibility for photos and storage and not that of the containing conversation item (and is only useful if the default visibility is public). This choice must be explained adequately because it represents a complex series of tradeoffs and side effects. It will reduce complaints from other networks about blocked content, but essentially forces you to use another method (dav or the photos page) if you wish to upload protected files/media.
* various diaspora issuesfriendica2014-08-291-0/+6
|
* switch everything over to crypto_encapsulate()friendica2014-08-231-2/+2
|
* profile edit - missing visibility and drop link on non-default profiles, ↵friendica2014-08-211-1/+0
| | | | re-arrange order of replacing red#matrix smilie so it works correctly, accept a post with body content of '0' which was interpreted by x() as nothing (was treated as integer).
* escape tags when using markdown. Strange things happen if you put HTML ↵friendica2014-08-141-2/+2
| | | | entities in the text.
* make mention tagging by webbie do the right thing.friendica2014-08-101-1/+1
|
* a couple of "not quite public" fixesfriendica2014-08-081-12/+10
|
* public scope delivery issuesfriendica2014-08-061-2/+2
|
* basic 'notpublic' bits workingfriendica2014-08-061-2/+12
|
* issues #542 #543 - mentions not linked on editing a post if they contained a ↵friendica2014-07-241-0/+9
| | | | forum indicator.
* turn that into a featurefriendica2014-07-021-2/+1
|
* optionally allow zrl usage from specific markdown sourcesfriendica2014-07-011-1/+1
|
* easter eggfriendica2014-07-011-1/+8
|
* rule of snakes #1, kill the snake.friendica2014-06-281-4/+8
| | | | | | tinymce is gone. if you want a visual editor, figure out what you want and make it happen. If you don't want a visual editor, do nothing. This is in the community's hands. I don't need a visual editor.
* notification being sent for comments from blocked connections on same site.friendica2014-06-261-1/+5
|
* fix space around brackets changing.friendica2014-06-191-3/+5
|
* issues with editing webpage permissionsfriendica2014-06-151-2/+8
|
* ensure item_private tracks acl fields on editfriendica2014-06-151-1/+10
|
* webpage permissions weirdnessfriendica2014-06-141-9/+14
|
* fix author delete (non-owner)friendica2014-05-141-3/+3
|
* zrlify (turn into zmg) any relevant img tags in a post.friendica2014-05-131-0/+5
|
* core fixes to allow statusnet connector to workfriendica2014-05-061-4/+4
|
* issue #432 permission changes lost editing webpage (and other non-post items)friendica2014-05-041-4/+11
|
* tag anyonefriendica2014-04-151-4/+17
|
* let normal hashtags be quoted strings alsofriendica2014-04-121-1/+9
|
* major cleanup of handle_tag()friendica2014-04-121-10/+48
|
* handle new tag declarationsfriendica2014-04-121-1/+1
|
* add forum mode to tag handlingfriendica2014-04-121-2/+9
|
* mod/item - get rid of some failed experiments, duplicated code and unused code.friendica2014-04-061-89/+10
|
* this makes rpost to another channel work somewhat - but there are issues, ↵friendica2014-04-051-1/+8
| | | | since the ACL will belong to the wrong channel. Leaving disabled for now. I don't know that we can solve all the issues without a different design so this may end up in a plugin for those who are willing to put up with the shortcomings.
* provide the ability for rpost to post as another of your channels. This does ↵friendica2014-04-051-17/+24
| | | | not yet work, so the functionality has not been enabled.
* doc updates, plus back-end work for rpost to let you post to a different ↵friendica2014-04-041-6/+20
| | | | channel than your current logged-in channel. Need the same for rbmark back-end. Then we "just" need a selector widget on the editor forms.
* save notes every ten seconds while focused, then save them once more on focusoutfriendica2014-04-011-3/+2
|
* another complication to deletionfriendica2014-03-281-3/+10
|
* fix delete missing permission checkfriendica2014-03-281-2/+7
|
* a few more delete fixesfriendica2014-03-271-3/+12
|