Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | working through the xchan table to remove bitfields, mostly complete except ↵ | friendica | 2015-01-20 | 1 | -4/+2 |
| | | | | for updating the updater | ||||
* | PostgreSQL support initial commit | Habeas Codice | 2014-11-13 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres) | ||||
* | fix group membership management for non-red connections | friendica | 2014-09-03 | 1 | -4/+4 |
| | |||||
* | subdue archived connections in group editor and don't show at all in ↵ | friendica | 2014-07-16 | 1 | -0/+2 |
| | | | | contact_block() | ||||
* | sql error | friendica | 2014-06-25 | 1 | -1/+1 |
| | |||||
* | let oneself be added to a collection in exchange for deleted contacts | marijus | 2014-02-07 | 1 | -4/+4 |
| | |||||
* | remove a couple of mysql reserved words from being used as table or row ↵ | friendica | 2013-12-22 | 1 | -4/+4 |
| | | | | names. For this round we're getting 'group' and 'desc'. Warning: potentially destabilising as this touches a lot of code. | ||||
* | comanchify connedit, group | friendica | 2013-12-19 | 1 | -6/+0 |
| | |||||
* | Make it possible to change visibility without changing name. | zottel | 2013-12-05 | 1 | -2/+2 |
| | |||||
* | Add public visibility setting to privacy groups (collections). This doesn't ↵ | friendica | 2013-08-07 | 1 | -3/+9 |
| | | | | yet make them visible, but allows them to be visible (like a Cc: instead of a Bcc:) | ||||
* | members_of_group() output not entirely correct | friendica | 2013-05-02 | 1 | -1/+3 |
| | |||||
* | change collections to connections | Michael Johnston | 2013-02-17 | 1 | -1/+1 |
| | |||||
* | fix con"n"nections | Oliver | 2013-02-02 | 1 | -1/+1 |
| | |||||
* | fix the visual group editor | friendica | 2013-01-20 | 1 | -2/+2 |
| | |||||
* | more logging, some debugging of group membership page | friendica | 2012-12-30 | 1 | -1/+5 |
| | |||||
* | add pending check on group queries | friendica | 2012-11-29 | 1 | -4/+6 |
| | |||||
* | cleanup | friendica | 2012-11-14 | 1 | -26/+15 |
| | |||||
* | make the visual group editor work again in the new world | friendica | 2012-11-14 | 1 | -15/+28 |
| | |||||
* | a lot more changes of terminology | friendica | 2012-11-03 | 1 | -17/+17 |
| | |||||
* | contact group is now 'channel group' | friendica | 2012-10-27 | 1 | -9/+9 |
| | |||||
* | merge upstream, slider work, refactor ping module, language selection work | friendica | 2012-07-13 | 1 | -8/+8 |
| | |||||
* | Merge branch 'master' of https://github.com/friendica/friendica | Alexander Kampmann | 2012-04-05 | 1 | -0/+0 |
| | | | | | | Conflicts: include/config.php update.php | ||||
* | CSRF-Protection in the group-related form (creating, renaming and dropping a ↵ | Tobias Hößl | 2012-03-18 | 1 | -7/+19 |
| | | | | group, adding/removing members from it) | ||||
* | group: fix create new group form | Fabio Comuni | 2012-03-02 | 1 | -0/+1 |
| | |||||
* | less html in mod/group.php, template for group members editor, quattro theme ↵ | Fabio Comuni | 2012-02-23 | 1 | -41/+39 |
| | | | | for group edit. | ||||
* | mark all notifications read | friendica | 2012-02-21 | 1 | -1/+1 |
| | |||||
* | add remove_user hook (it looks like dreamhost changed all my file ↵ | friendica | 2012-01-18 | 1 | -0/+0 |
| | | | | permissions, this will make a nasty commit) | ||||
* | moved contact group header out of scrolling div so it doens't vanish whenlot | Devlon Duthie | 2011-09-25 | 1 | -2/+3 |
| | | | | more css tweaks | ||||
* | add group highlight to other pages | Friendika | 2011-07-01 | 1 | -1/+1 |
| | |||||
* | switch to text mode group editor after 'n' contacts | Friendika | 2011-06-29 | 1 | -2/+12 |
| | |||||
* | add info() function. Works like notice() but show messages in a div with ↵ | Fabio Comuni | 2011-05-23 | 1 | -3/+3 |
| | | | | | | | class info-message. update code to use info() instead of notice() when appropriate (non-error message) add info-message class style in themes | ||||
* | bug #70 - error messages on group deletion, warning cleanup | Friendika | 2011-05-15 | 1 | -2/+5 |
| | |||||
* | deprecate load_view_file | Friendika | 2011-05-11 | 1 | -3/+3 |
| | |||||
* | don't use load_view_file() except in email templates and install of htconfig ↵ | Friendika | 2011-05-10 | 1 | -3/+3 |
| | | | | - to avoid getting wrong file when package is updated by copying over an older version. | ||||
* | cleanup | Friendika | 2011-04-12 | 1 | -31/+51 |
| | |||||
* | first cut at group chooser UI | Friendika | 2011-04-12 | 1 | -0/+19 |
| | |||||
* | visual display of group members | Friendika | 2011-04-11 | 1 | -4/+11 |
| | |||||
* | more templates converted to string files | Friendika | 2011-04-06 | 1 | -2/+10 |
| | |||||
* | don't process empty or non-existent group array | Friendika | 2011-01-02 | 1 | -2/+3 |
| | |||||
* | view directory cleanup | Friendika | 2010-11-15 | 1 | -1/+1 |
| | |||||
* | eradicate redundant get_uid function | Mike Macgirvin | 2010-10-18 | 1 | -9/+9 |
| | |||||
* | group/community/celebrity pages | Mike Macgirvin | 2010-10-18 | 1 | -1/+3 |
| | |||||
* | stronger type checking on comparisons | Mike Macgirvin | 2010-09-26 | 1 | -3/+3 |
| | |||||
* | localisation path for all view templates | Mike Macgirvin | 2010-09-22 | 1 | -3/+3 |
| | |||||
* | mistpark 2.0 infrasturcture lands | Mike Macgirvin | 2010-09-08 | 1 | -24/+19 |
| | |||||
* | group removal | Mike Macgirvin | 2010-08-11 | 1 | -3/+3 |
| | |||||
* | group drop | Mike Macgirvin | 2010-08-11 | 1 | -9/+31 |
| | |||||
* | . | Mike Macgirvin | 2010-07-13 | 1 | -2/+10 |
| | |||||
* | group editor cleanup | Mike Macgirvin | 2010-07-13 | 1 | -2/+39 |
| | |||||
* | more group editor | Mike Macgirvin | 2010-07-13 | 1 | -4/+13 |
| |