aboutsummaryrefslogtreecommitdiffstats
path: root/mod/group.php
Commit message (Collapse)AuthorAgeFilesLines
* PostgreSQL support initial commitHabeas Codice2014-11-131-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres)
* fix group membership management for non-red connectionsfriendica2014-09-031-4/+4
|
* subdue archived connections in group editor and don't show at all in ↵friendica2014-07-161-0/+2
| | | | contact_block()
* sql errorfriendica2014-06-251-1/+1
|
* let oneself be added to a collection in exchange for deleted contactsmarijus2014-02-071-4/+4
|
* remove a couple of mysql reserved words from being used as table or row ↵friendica2013-12-221-4/+4
| | | | names. For this round we're getting 'group' and 'desc'. Warning: potentially destabilising as this touches a lot of code.
* comanchify connedit, groupfriendica2013-12-191-6/+0
|
* Make it possible to change visibility without changing name.zottel2013-12-051-2/+2
|
* Add public visibility setting to privacy groups (collections). This doesn't ↵friendica2013-08-071-3/+9
| | | | yet make them visible, but allows them to be visible (like a Cc: instead of a Bcc:)
* members_of_group() output not entirely correctfriendica2013-05-021-1/+3
|
* change collections to connectionsMichael Johnston2013-02-171-1/+1
|
* fix con"n"nectionsOliver2013-02-021-1/+1
|
* fix the visual group editorfriendica2013-01-201-2/+2
|
* more logging, some debugging of group membership pagefriendica2012-12-301-1/+5
|
* add pending check on group queriesfriendica2012-11-291-4/+6
|
* cleanupfriendica2012-11-141-26/+15
|
* make the visual group editor work again in the new worldfriendica2012-11-141-15/+28
|
* a lot more changes of terminologyfriendica2012-11-031-17/+17
|
* contact group is now 'channel group'friendica2012-10-271-9/+9
|
* merge upstream, slider work, refactor ping module, language selection workfriendica2012-07-131-8/+8
|
* Merge branch 'master' of https://github.com/friendica/friendicaAlexander Kampmann2012-04-051-0/+0
| | | | | | Conflicts: include/config.php update.php
* CSRF-Protection in the group-related form (creating, renaming and dropping a ↵Tobias Hößl2012-03-181-7/+19
| | | | group, adding/removing members from it)
* group: fix create new group formFabio Comuni2012-03-021-0/+1
|
* less html in mod/group.php, template for group members editor, quattro theme ↵Fabio Comuni2012-02-231-41/+39
| | | | for group edit.
* mark all notifications readfriendica2012-02-211-1/+1
|
* add remove_user hook (it looks like dreamhost changed all my file ↵friendica2012-01-181-0/+0
| | | | permissions, this will make a nasty commit)
* moved contact group header out of scrolling div so it doens't vanish whenlotDevlon Duthie2011-09-251-2/+3
| | | | more css tweaks
* add group highlight to other pagesFriendika2011-07-011-1/+1
|
* switch to text mode group editor after 'n' contactsFriendika2011-06-291-2/+12
|
* add info() function. Works like notice() but show messages in a div with ↵Fabio Comuni2011-05-231-3/+3
| | | | | | | class info-message. update code to use info() instead of notice() when appropriate (non-error message) add info-message class style in themes
* bug #70 - error messages on group deletion, warning cleanupFriendika2011-05-151-2/+5
|
* deprecate load_view_fileFriendika2011-05-111-3/+3
|
* don't use load_view_file() except in email templates and install of htconfig ↵Friendika2011-05-101-3/+3
| | | | - to avoid getting wrong file when package is updated by copying over an older version.
* cleanupFriendika2011-04-121-31/+51
|
* first cut at group chooser UIFriendika2011-04-121-0/+19
|
* visual display of group membersFriendika2011-04-111-4/+11
|
* more templates converted to string filesFriendika2011-04-061-2/+10
|
* don't process empty or non-existent group arrayFriendika2011-01-021-2/+3
|
* view directory cleanupFriendika2010-11-151-1/+1
|
* eradicate redundant get_uid functionMike Macgirvin2010-10-181-9/+9
|
* group/community/celebrity pagesMike Macgirvin2010-10-181-1/+3
|
* stronger type checking on comparisonsMike Macgirvin2010-09-261-3/+3
|
* localisation path for all view templatesMike Macgirvin2010-09-221-3/+3
|
* mistpark 2.0 infrasturcture landsMike Macgirvin2010-09-081-24/+19
|
* group removalMike Macgirvin2010-08-111-3/+3
|
* group dropMike Macgirvin2010-08-111-9/+31
|
* .Mike Macgirvin2010-07-131-2/+10
|
* group editor cleanupMike Macgirvin2010-07-131-2/+39
|
* more group editorMike Macgirvin2010-07-131-4/+13
|
* groups and aclsMike Macgirvin2010-07-121-2/+25
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 17:24:37 +0000