aboutsummaryrefslogtreecommitdiffstats
path: root/include/security.php
Commit message (Collapse)AuthorAgeFilesLines
* PostgreSQL support initial commitHabeas Codice2014-11-131-14/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres)
* Very, very cautiously let a developer switch to the sys chan ifThomas Willingham2014-09-151-0/+13
| | | | they're also an administrator.
* Bugger, revert - not only a dodgy cut and paste between terminals, butThomas Willingham2014-09-151-14/+0
| | | | also pushed to the wrong repo
* Very, very cautiously, let a developer switch to the sys chan, ifThomas Willingham2014-09-151-0/+14
| | | | they're also an admin.
* bad redirectsfriendica2014-09-111-0/+6
|
* provide os_mkdir to workaround permission issues with php mkdirfriendica2014-07-161-1/+1
|
* Implements a new permission level PERMS_PENDINGAlexandre Hannud Abdo2014-06-191-8/+13
| | | | | | | | | | | | | | | | With this a user can allow some action to any user which connects to them, even before they've connected back. Ref. https://mobiliza.org.br/display/478d9e71eaf55748dc646d3990651d6d34cfb7db5c38360538ec730ca3ccf908@zothub.com Also some code cleanup and an alternative logic for handling notifications of permission changes in zot.php. This assumes that private posts are still restricted to people in your addressbook. Regardless of your global permissions, a pending channel won't get private posts, even if the post only has a deny clause not matching the pending channel.
* access control modification functions (item specific - we may need these for ↵friendica2014-06-171-0/+1
| | | | several data types)
* more easter eggsfriendica2014-05-031-0/+6
|
* improve zotfeed for discover channel so it will send updates to posts you've ↵friendica2014-04-171-8/+6
| | | | already received. Incidentally I discovered why we had the meltdown replying to discover channel items the other day - but can't fix it easily.
* Don't count deleted channels when figuring out where to send a user on login.Thomas Willingham2014-04-111-2/+3
|
* more work on firehosefriendica2014-03-261-4/+6
|
* add admin/channelsfriendica2014-03-261-3/+3
|
* allow zotfeed to create a firehose of a site.friendica2014-03-261-6/+8
|
* This should resolve the dav authentication loop (correctly)friendica2014-02-221-2/+5
|
* fix login weirdness for accounts that need to be approvedfriendica2014-02-201-0/+11
|
* don't prompt guests for a password if they're accessing an embedded public file.friendica2014-01-261-1/+1
|
* Typoroot2014-01-251-2/+3
|
* set session['my_address'] to current site in change channel, not primary hub ↵friendica2014-01-251-85/+1
| | | | location. Also remove all the old Friendica-style authentication code.
* added buttons to perform later hubloc actionsMichael Meer2014-01-201-1/+1
|
* mod_attach: output stream wasn't workingfriendica2014-01-111-0/+3
|
* remove a couple of mysql reserved words from being used as table or row ↵friendica2013-12-221-1/+1
| | | | names. For this round we're getting 'group' and 'desc'. Warning: potentially destabilising as this touches a lot of code.
* init_groups_visitor() was still using old array of id output (not the newer ↵friendica2013-11-221-2/+2
| | | | array of hash which we need for permission queries)
* one more edge case in the public perms - don't match perms = 0 which is ↵friendica2013-09-221-2/+3
| | | | private, this and prior checkin are for issue #114
* fixes for display and search privacy enforcementfriendica2013-09-221-10/+36
|
* get rid of more variables with dashes in the names - use underscore *except* ↵friendica2013-08-151-2/+2
| | | | in CSS. These were probably already here, but if you see any - please keep them out of PHP and MySQL where they sometimes get interpreted as a subtraction operation and are a bugger to find.
* Fix Load mobile themeChristian Vogeley2013-08-161-0/+2
|
* attachment permissions not rightfriendica2013-07-301-38/+44
|
* start formatting for Doxygenfriendica2013-02-251-1/+1
|
* start on channel_remove(), add some generic channel queries to the API layersfriendica2013-02-161-2/+3
|
* mod_display - no fun. Not working at all. But a bit of progress.friendica2013-02-101-8/+32
|
* further baby steps on the photos APIfriendica2013-01-251-0/+2
|
* now we're into the minor nitty fixesfriendica2013-01-211-1/+1
|
* more heavy lifting on API - though need to re-visit events and give them all ↵friendica2013-01-191-1/+34
| | | | message_ids from the origination site.
* begin the hard slog on the apifriendica2013-01-161-5/+3
|
* port "remember me" from Friendicafriendica2013-01-041-2/+2
|
* fixing permissions_sql - may need more tweaksfriendica2012-12-161-85/+46
|
* start to whip the permissions into shape, also got rid of the mce drop ↵friendica2012-12-091-66/+0
| | | | shadow until we can figure out how to do it without the ugly black bars. I tend to prefer "outy" shadows over "inny" shadows anyway, but maybe that's just me.
* a bit of e_all cleanupfriendica2012-12-081-1/+1
|
* start implementing zot-idfriendica2012-11-081-0/+3
|
* "profile url" e.g. the wall/stream is now "channel url". "Profile URL" goes ↵friendica2012-10-291-1/+1
| | | | to the profile details.
* Now have a solid permissions model. Create a few functions to enumerate them ↵friendica2012-10-281-2/+4
| | | | and then we're off to the races.
* upstream fixesfriendica2012-10-211-0/+21
|
* more work on profile changes - the notify activity is still stuffed as we ↵friendica2012-10-191-1/+1
| | | | finalise the json structure for activitystream meta-data
* provide auto admin registration as before, but allow the current admin to ↵friendica2012-10-041-2/+2
| | | | create other admins
* Can't see any posts currently - after the big shakeup, but we can now post ↵friendica2012-10-031-26/+14
| | | | top level activities and store them.
* use hash for channel idfriendica2012-10-011-0/+21
|
* here's where the heavy lifting begins - everything is likely to be broken ↵friendica2012-10-011-1/+11
| | | | for quite some time as we add location and db independence to items and conversations and work through the rest of the permissions and how to federate the buggers.
* moving a lot of structure around. 'entity' is now 'channel'friendica2012-09-251-11/+11
|
* updatesfriendica2012-09-091-1/+15
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-12 23:12:11 +0000