aboutsummaryrefslogtreecommitdiffstats
path: root/include/reddav.php
Commit message (Collapse)AuthorAgeFilesLines
* DB changes for some channel flagsredmatrix2015-06-151-2/+1
|
* make cloud work againredmatrix2015-06-111-1/+1
|
* first pass name changeredmatrix2015-05-051-2/+2
|
* PostgreSQL support initial commitHabeas Codice2014-11-131-8/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres)
* backtrack on attribution for wall-to-wall comments - triggered too often and ↵friendica2014-10-221-2/+2
| | | | unnecessarily.
* When you delete something in /cloud stay in the right folder.Klaus Weidenbach2014-10-141-15/+19
| | | | | | | When you deleted a file in /cloud you was always jumped back to /cloud/[channel], now you will stay in the parent folder. Some more doxygen documentation. Removed duplicate data from logging output and reduced logging in RedDAV in general.
* Moved classes from reddav.php into own files.Klaus Weidenbach2014-10-121-917/+27
| | | | | | Finished moving classes out from include/reddav.php into own files. Also continued with namespace for RedDAV. Improved some docs and added some todos and fixmes.
* Moved RedBrowser class from reddav.php to it's own file.Klaus Weidenbach2014-10-061-324/+5
| | | | | | | | | First step on cleaning up ReadDAV classes and restructuring it bit in preparation for adding some more DAV features, photo access, CalDAV, etc. and hopefully also some PHPunits. Add a PHP5.3 namespace for RedDAV classes. Any objections against this or the vendor namespace? Add some more documentation for RedBrowser.
* Some documentation for include/reddav.php and a bit code cleanup.Klaus Weidenbach2014-10-051-42/+153
| | | | | Removed some duplicate code in RedBasicAuth and restructured a bit. Still work in progress.
* move code out of templates - not sure how this even worked.friendica2014-07-031-1/+9
|
* Add rename support for DAV directories.Klaus Weidenbach2014-06-301-12/+60
| | | | This works only over DAV right now, no GUI yet.
* Return a correct timestamp when a folder is empty.Klaus Weidenbach2014-06-291-9/+23
| | | | | If a folder was empty a zero timestamp was returned. Now it will return the timestamp of the folder itself.
* Fixed some more timestamp bugs in RedDAV.Klaus Weidenbach2014-06-291-5/+7
| | | | Fixed an SQL-query in RedFile::put(), where parameters where in wrong order.
* Fixed a wrong timestamp update when adding a file.Klaus Weidenbach2014-06-291-3/+9
| | | | | | | When a file was uploaded the timestamp of the containing folder should get updated, but the timestamp of the first file in the folder was mistakenly updated. There are some more wrong timestamps, but still looking for the bug.
* Some documentation for include/reddav.php and a new tpl-file.Klaus Weidenbach2014-06-291-433/+586
| | | | | | | | | | | Documented include/reddav.php a bit more to understand what it is about to try to clean up some parts. Still a lot to be done here. I put serveral @todo markers that need to be checked. Moved some more HTML to template file. Changed getETag() return format according to documentation. (ETag MUST be surrounded by double-quotes)
* bring back profile_tabs for unauthenticated visitors to /cloud pagefriendica2014-06-251-1/+1
|
* Templified cloud's directory listing.Klaus Weidenbach2014-06-261-190/+170
| | | | | | Moved HTML for the directory listing from include/reddav.php to it's own template file. Still need to clean it up bit more, but should be useable already.
* Delete confirmation is translatablePaolo Tacconi2014-06-251-1/+1
|
* Display quota and translatable stringsPaolo Tacconi2014-06-251-37/+66
|
* Fixes to links and forward URLs in filestoragetuscanhobbit2014-06-241-17/+21
|
* block edit/delete ability for everybody but the ownerfriendica2014-06-231-7/+16
|
* Dav file browser on a single pagetuscanhobbit2014-06-241-27/+78
|
* give the cloud file list a bit of paddingfriendica2014-05-271-1/+1
|
* Fixed some wrapping problems when the user has set a larger font size. And ↵jeroenpraat2014-05-051-8/+8
| | | | some UI love for the file permissions page (as requested by Mike ;) and changed the position of the file properties link on the cloud page.
* some fixes to #395friendica2014-04-071-1/+1
|
* issue #395, item 2friendica2014-04-061-1/+5
|
* cleanupfriendica2014-03-181-1/+2
|
* oopsThomas Willingham2014-03-181-1/+1
|
* Missed oneThomas Willingham2014-03-181-2/+3
|
* sprintf errorfriendica2014-03-171-1/+1
|
* little fixes of hopefully nil significancefriendica2014-03-161-2/+2
|
* This should resolve the dav authentication loop (correctly)friendica2014-02-221-0/+2
|
* Make asset icons work in subdir installs as well.Klaus2014-02-151-1/+1
| | | This should be the right way I guess, especially if red# is installed in a subdirectory. (untested)
* Fix call to asset icons in RedBrowser.Klaus2014-02-151-0/+10
| | | RedBrowser was not displaying asset icons correctly, because the URL was wrong.
* more debugging dav in windows, windows never forgets your dav credentials ↵friendica2014-02-131-0/+1
| | | | even if you get them wrong and even if you remove them from the credential vault. This makes it very difficult to manage two or more channels with file resources.
* reddav - disable assetsfriendica2014-02-131-1/+1
|
* dav issue when listing protected contents from OS interfacefriendica2014-02-121-7/+26
|
* better auth logging in davfriendica2014-02-111-0/+12
|
* don't allow the browser to open uploaded html/css/jsfriendica2014-02-091-1/+12
|
* fix basic auth with account (not channel) loginfriendica2014-01-301-1/+1
|
* more testing of chatroom interfaces, also corrected a function call that ↵friendica2014-01-291-1/+1
| | | | should have been a class instantiation in reddav
* seems you can't easily have a blank password for DAV guests, so the guest ↵friendica2014-01-211-0/+6
| | | | password is now +++
* add the quota and volume size codefriendica2014-01-211-1/+29
|
* revert 26dfcecf054e1friendica2014-01-191-6/+2
|
* Prevent zids messing up davThomas Willingham2014-01-201-3/+5
|
* Fix dav directory creation.Thomas Willingham2014-01-201-2/+3
|
* Un-break dav auth.Thomas Willingham2014-01-171-3/+4
|
* fix folder timestamps and change them when a child DAV file is written tofriendica2014-01-151-5/+31
|
* dav: throw exception if channel for requested DAV directory is deletedfriendica2014-01-151-12/+18
|
* mod_attach: output stream wasn't workingfriendica2014-01-111-0/+2
|