aboutsummaryrefslogtreecommitdiffstats
path: root/include/items.php
Commit message (Collapse)AuthorAgeFilesLines
* some tabs title statuseditor restructuringMario Vavti2015-03-211-1/+1
|
* The random bad signatures are because something somewhere is trimming the ↵friendica2015-03-171-2/+2
| | | | body text. It could be any one of hundreds of functions that touch the message body. We really want to trim the body text, so I'm putting back all the trim statements - in mod/item and item_store and item_store_update. The last fix for random bad sigs noted that one of the trims wasn't there, so the others were removed. The correct fix is for all the trims to be there. We will probably have a few (quite a few) bad sigs during the transition back to trimmed text but this should nail it for anybody on recent code and with new content.
* The never ending saga of parent = 0 bugs on Dreamhost.friendica2015-03-011-0/+10
|
* this may actually fix the deliver loop when deleting existing items. It's ↵friendica2015-02-251-0/+15
| | | | hackish but I don't see any other way out.
* Found the cause of the delete looping, and I can prevent it going forward. ↵friendica2015-02-251-1/+10
| | | | The issue remains what to do about comments which are already in the DB and have ITEM_ORIGIN incorrectly set. We can't exactly reset them because the "original" context has been lost. (Sorry but couldn't resist an insider pun that none of you will be able to follow anyway). Read the comments.
* call post_local hooks prior to storing a post that is going to be sourced. ↵friendica2015-02-251-0/+2
| | | | There are some fields in the actual stored item that may change when we start the second delivery chain so a few plugins may not deal with these items correctly. Since we only source public items these effects will be slight.
* Fixes tag delivery regex for when multiple tags are presentAlexandre Hannud Abdo2015-02-131-2/+2
| | | | | Previous regex would cause matches to span several tags when present, thus never recognizing the mention.
* provide relief to sites that are severely impacted by the slow ITEM_UNSEEN ↵friendica2015-02-121-5/+4
| | | | searches. This does not incorporate any other flag optimisations as that will require a major DB update and possibly involve significant downtime. This is just to bite off a little chunk now and provide some much needed relief.
* Dot not trim body in order to avoid issues with signature checksAlexandre Hannud Abdo2015-02-121-2/+2
|
* issue #843friendica2015-02-111-0/+3
|
* more efficient processing of response activities, plus a proof of concept ↵friendica2015-02-111-2/+9
| | | | fix for the problem of receiving a delete notification before we actually get the item which we're supposed to delete.
* item voting toolsfriendica2015-02-101-2/+2
|
* issue #889 private tags for forums no longer recognised after tag refactor a ↵friendica2015-02-021-0/+1
| | | | few weeks back. This solution is not optimal as it also leaves you in the privacy ACL in some cases and not in others but it restores the previous functionality
* remote_user => remote_channelfriendica2015-01-281-1/+1
|
* local_user => local_channelfriendica2015-01-281-5/+5
|
* limit the number of forums that can be tagged in a single post - default is ↵friendica2015-01-281-8/+46
| | | | 2. The reason is simple - count how many posts would be in transit simultaneously if this was unlimited and somebody tagged 40-50 forums. In practice when used legitimately - we've rarely seen more than two, in fact I don't recall seeing more than two ever. Typically it is one and occasionally two. Changing the default is tricky - a client system cannot do it, but the site hosting a forum can choose to. Since not all sites that host forums will choose to do so, the ordering of the mentions would then be important.
* improved route mismatch detection. We will be less strict about the absolute ↵friendica2015-01-271-33/+20
| | | | route matching and only look at the last hop before it got to us - which is ultimately all we should care about (since that sender controls the thread permissions). Route mismatches seem to occur somewhat frequently from yamkote (for unknown reasons), and the logging has been improved a bit so it should provide some slightly more useful debugging info in case it still happens going forward. Oh, also we'll set the parent on comments when we store the initial post (item_store()) and only go back and set the parent for top-level posts. This should reduce the number of comments with missing parents on shared hosts, but may increase the number of missing threads. Probably worthwhile to do a query occasionally for parent = 0 and see how we're doing and how many have shared host related delivery issues.
* correct some activity object types (for comments), also fix a foreach ↵friendica2015-01-141-2/+7
| | | | warning resulting from recent tag work
* federate consensus items (in network only). Work in progress.friendica2015-01-141-0/+7
|
* check mentions against the appropriate xchan_url and not a hard-coded ↵friendica2015-01-131-4/+4
| | | | /channel/ string
* don't wipe out the item body of a linked item to a photo when doing a normal ↵friendica2015-01-121-7/+18
| | | | delete and not forced
* change deletion behaviour of linked photo items. Previously deleting the ↵friendica2015-01-121-28/+12
| | | | visible item in the conversation deleted the photo as well. Now photos must be deleted in the photos module. Deleting the linked item removes any attached conversation elements (likes, etc.) and sets the conversation item to hidden. This may create an issue in the future if we move the photo tags, title, or other photo elements to the linked item rather than the photo. Noting here so this can potentially be discovered and remembered at that time.
* Refactor mention code to make it more reusableStefan Parviainen2015-01-121-0/+31
|
* basic changes for file activitymarijus2015-01-091-1/+5
|
* include channel clones in PM deliveries (also some whitespace edits)friendica2015-01-081-1/+1
|
* prevent database hackery from leaking over the wireHabeas Codice2014-11-221-1/+2
|
* more logging for zot_feed anomaliesfriendica2014-11-201-0/+2
|
* change logging of some troublesome or noisy bits so we can figure out what ↵friendica2014-11-191-1/+1
| | | | is really going on
* place holderfriendica2014-11-171-0/+5
|
* Merge remote-tracking branch 'upstream/master'Habeas Codice2014-11-131-3/+14
|\ | | | | | | | | | | | | | | | | | | | | | | Conflicts: boot.php include/dba/dba_driver.php include/diaspora.php include/follow.php include/session.php include/zot.php mod/photos.php mod/ping.php
| * tgroup_check - decrypt if obscured before checking body text for resharesfriendica2014-11-071-1/+9
| |
| * various UI issues related to having an enormous number of entries in the ↵friendica2014-11-031-2/+5
| | | | | | | | posted_date selector including years/months that had no posts
* | PostgreSQL support initial commitHabeas Codice2014-11-131-47/+47
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres)
* What this checkin does is catch the case where a comment arrived and there's ↵friendica2014-10-301-3/+18
| | | | a missing top-level post to match it with. So we'll send a request back to the sender that you've never seen this thread and please send a fresh copy of the entire conversation to date. We could soon have posts in the matrix from different platforms from days gone by, which have been migrated into the modern world. We'll be polite and not deliver these to everybody. However, if someone comments on one of these antique threads we wouldn't be able to see it in our own matrix because we won't have a copy of the parent post. So this rectifies that situation. Be aware that item deletion may need to change to keep "hard deleted" items indefinitely so that they don't keep coming back. We'll have to null out the important data of the former item to accomplish the deletion aspect.
* doh - this needs to be markdown, not bbcodefriendica2014-10-241-2/+2
|
* diaspora walltowall comment signature, force update.friendica2014-10-231-1/+1
|
* Provide comment box for PERMS_AUTHED items. Presently only commentable from ↵Thomas Willingham2014-10-231-0/+1
| | | | owners wall.
* improved wall-to-wall detection for comments so we can handle Diaspora ↵friendica2014-10-221-2/+11
| | | | | | | signing and wall-to-wall attribution correctly. Do it at the point of submission. This also fixes a potential bug in yesterday's wall-to-wall permission setting, if it was a local comment to a remote post.
* you've gotta' be on your toes to catch this bug... though it's been here for ↵friendica2014-10-221-2/+2
| | | | about 2 1/2 years and even survived a rewrite. Symptoms are that the archive widget only lists one month (the month when you first posted), and only if your first post was written between the 28th and 31st of whatever month that was.
* private forum issuesfriendica2014-10-211-0/+1
|
* content deletion issuefriendica2014-10-121-1/+6
|
* missing source route after editfriendica2014-10-101-1/+1
|
* allow (our own) ajax urls to pass through bbcode intact.friendica2014-10-091-0/+1
|
* return of the missing diaspora wall-to-wall attributionfriendica2014-10-091-12/+0
|
* Merge pull request #626 from habeascodice/masterRedMatrix2014-10-081-1/+1
|\ | | | | regex missing terminator char
| * regex missing terminator charhabeascodice2014-09-291-1/+1
| |
* | issues with diaspora comment signatures on relayed comments that are relayed ↵friendica2014-10-021-4/+6
|/ | | | through a redmatrix site (parent post is redmatrix) and involve a private post.
* optionally include wall items (posts) in import/exportfriendica2014-09-251-1/+23
|
* TypoThomas Willingham2014-09-251-1/+1
|
* if no rss/atom element author, use feed level contactfriendica2014-09-241-7/+11
|