aboutsummaryrefslogtreecommitdiffstats
path: root/include/chat.php
Commit message (Collapse)AuthorAgeFilesLines
* PostgreSQL support initial commitHabeas Codice2014-11-131-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were 11 main types of changes: - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just copied from Friendica. All of these instances, the LIMIT 1 was simply removed. - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice to boot). Proper explicit boolean conversions were added. New queries should use proper conventions. - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_ func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There were no true toggles (XOR). New queries should refrain from using XOR when not necessary. - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify them. The reason this works is because mysql totally ignores the constraint and adds an empty text default automatically. Again, non-compliant, obviously. In these cases a default of empty text was added. - Several statements rely on a non-standard MySQL feature (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run a zillion times faster, even on MySQL. - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG, UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_ - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes around the value -- assist functions added in the dba_ - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are handled in Zot/item packets automagically by quoting all dates with dbescdate(). - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype for all text fields in the postgres schema. varchar was used in a couple of places where it actually seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code actually validates data, new bugs might come out from under the rug. - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted. bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function was added to handle this transparently. - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax. Statements were updated to be standard. These changes require corresponding changes in the coding standards. Please review those before adding any code going forward. Still on my TODO list: - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting - Rewrite search queries for better results (both MySQL and Postgres)
* aalso change the way we check for number of chatroomsmarijus2014-09-201-0/+11
|
* verified that chatroom expire is working, so doing away with the second ↵friendica2014-08-201-19/+4
| | | | | | function to do the same thing. If you have a problem with chatroom expiration, check that it was created with cr_expire set to 120 (minutes). Chatrooms created during the first couple of days of the chat feature didn't have this. You can set the DB value manually.
* sql errorfriendica2014-07-291-2/+4
|
* deleted a command with debug codePaolo Tacconi2014-07-291-0/+1
|
* Chatroom lines are deleted after MAX_CHATROOM_HOURS or the chat becomes slow ↵Paolo Tacconi2014-07-291-0/+15
| | | | to load
* UI for deleting chatroomsfriendica2014-05-041-0/+3
|
* basic chatterbot support - though these would still require additional ↵friendica2014-04-261-0/+41
| | | | functionality in the API to maintain presence as they'll get kicked out of the room if they don't ping it regularly.
* make chatrooms in /chat/channel visible to observers aswellmarijus2014-02-121-2/+4
|
* apply service class restriction to the number of channels allowed in a ↵friendica2014-02-061-0/+11
| | | | chatroom at a time ('chatters_inroom'). If you've got a public site you probably want to restrict this.
* add links to change chat status and leave roomfriendica2014-02-021-3/+5
|
* chat expiration (default 2 hours) - but can be set on a per-chatroom basisfriendica2014-01-301-2/+8
|
* a bit more ajax work on chat and chatsvc and some fiddling with layoutsfriendica2014-01-301-1/+1
|
* apply service class limits (at the account level) to chatroom creation as ↵friendica2014-01-291-0/+12
| | | | chat has the potential to adversely affect system performance. In the future we may also want to service_class restrict the number of participants in a room.
* more chat infrastructurefriendica2014-01-291-6/+9
|
* more testing of chatroom interfaces, also corrected a function call that ↵friendica2014-01-291-2/+2
| | | | should have been a class instantiation in reddav
* chatroom permissions enforcementfriendica2014-01-291-0/+19
|
* debug chatroom_list widgetfriendica2014-01-291-1/+2
|
* issues uncovered whilst testing the chatroom APIfriendica2014-01-291-8/+10
|
* chatroom list widget backendfriendica2014-01-291-0/+9
|
* basic chatroom management backendfriendica2014-01-291-0/+117