| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
| |
hamburger menu on small screens
|
| |
|
|
|
|
| |
instance in mod_removeme)
|
|
|
|
| |
delegated channel. This fixes the known issue of being forced to log back in after leaving the delegated channel.
|
| |
|
|
|
|
| |
creation but prior to successful verification. This presents the link to resend the verification email and/or allows you to enter it.
|
|
|
|
| |
to check their email.
|
|
|
|
| |
elegant way to "popup" the modal login form already on the page. We still may need this fix for the actual login module which should always be callable and present a login form even if the nav is completely borked.
|
|
|
|
| |
(they should be able to post content if allowed to). It also removes the strict linkage between permissions and connections so any individual permission can be set for any xchan; even those for which you have no connections.
|
| |
|
|
|
|
| |
auth issue which I simply could not duplicate or find a reason for.
|
| |
|
|
|
|
| |
firefox which suggested deeper issues
|
|
|
|
| |
changes) into the session object and extend remember_me cookies once a day so that they will never expire (theoretically). The DB session driver will extend its expiration on every session write (in the case of persistent sessions).
|
|
|
|
| |
file sync operation, fix_system_urls not catching cached contact photos, extend sessionhandler expiration when remember_me is enabled as the stored session is expiring long before the browser session.
|
| |
|
| |
|
| |
|
|
|
|
| |
session the session was not completely cleared.
|
|
|
|
| |
allow them to expose their own programmatic API.
|
| |
|
| |
|
| |
|
|
|
|
| |
Some smaller clean ups whitepsaces and tabs, use PHP_EOL, Doxygen, etc.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were 11 main types of changes:
- UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but
it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just
copied from Friendica. All of these instances, the LIMIT 1 was simply removed.
- Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit
integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice
to boot). Proper explicit boolean conversions were added. New queries should use proper conventions.
- MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_
func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There
were no true toggles (XOR). New queries should refrain from using XOR when not necessary.
- There are several fields which the schema has marked as NOT NULL, but the inserts don't specify
them. The reason this works is because mysql totally ignores the constraint and adds an empty text
default automatically. Again, non-compliant, obviously. In these cases a default of empty text was
added.
- Several statements rely on a non-standard MySQL feature
(http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten
to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run
a zillion times faster, even on MySQL.
- A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG,
UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_
- INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes
around the value -- assist functions added in the dba_
- NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such
thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are
handled in Zot/item packets automagically by quoting all dates with dbescdate().
- char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the
code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works
better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype
for all text fields in the postgres schema. varchar was used in a couple of places where it actually
seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code
actually validates data, new bugs might come out from under the rug.
- postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted.
bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function
was added to handle this transparently.
- postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax.
Statements were updated to be standard.
These changes require corresponding changes in the coding standards. Please review those before
adding any code going forward.
Still on my TODO list:
- remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting
- Rewrite search queries for better results (both MySQL and Postgres)
|
| |
|
| |
|
|
|
|
| |
something in the logs to show what's happening.
|
| |
|
| |
|
| |
|
|
|
|
| |
REGISTER_OPEN is in effect.
|
| |
|
| |
|
|
|
|
| |
able to successfully authenticate (but is not necessarily in this network).
|
|
|
|
| |
array stuff
|
|
|
|
| |
rmagic module and after storing your openid in pconfig. This is just an interesting but trivial (in the bigger scheme of things) side effect of snakebite. The snake hasn't even waken up yet.
|
| |
|
| |
|
|
|
|
| |
session
|
|
|
|
| |
parameters and examples for each
|
|
|
|
|
|
| |
If user is logged in personal settings are used else use admin
settings.
Only show toggle link if there is something to switch between.
|
|
|
|
| |
in CSS. These were probably already here, but if you see any - please keep them out of PHP and MySQL where they sometimes get interpreted as a subtraction operation and are a bugger to find.
|
|
|
|
| |
(array), become superuser. Literally. Full control. Untested.
|
|
|
|
| |
besides "normal" web login (for instance magic auth)
|
| |
|
|
|
|
| |
exists
|
|
|
|
| |
Michael J's dead contacts and not poll them every ten minutes forever
|