| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Just a basic test to ensure that the module `get()` method behaves
somewhat reasonable when no query params are given.
Had to make a small change to the Rpost module itself. Since the
`$_SESSION` superglobal may not always be set (and is not in the test),
use `isset` instead of `array_key_exists` to check if we have saved
query params in the session.
In general, isset is safer than array_key_exists if there's a chance
that the array itself may not exist.
|
| | |
|
| |\
| |
| |
| |
| | |
Add config file and rules for PHP Code Sniffer.
See merge request hubzilla/core!2135
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The rules are based on the "Generic" ruleset included by PHP Code
Sniffer, with a significant portion of the rules disabled. This is a
tradeoff between getting some useful feedback, and not being overloaded
by noise.
I've tried to encode a coe style that resembles the existing code as
much as possible, but have included some sniffs that requires code
changes to satisfy the style. This is meant as a starting point, and we
can disable or enable more sniffs as we see fit.
PHPCS also has ready rule sets for other common coding standards we may
want to gravitate towards, e.g. PSR-12. Others are available from the
community.
The best way to run PHPCS is to integrate it with your editor, so that
it will display diacnostics inline when saving or modifying the code. It
can also be run from the command line like this:
./vendor/bin/phpcs -n [<path-to-file-to-check>]
If no file is specified it will try to check the entire project.
The `-n` means don't bother with warnings (I recommend that to begin
with. Enable the warnings when the errors are taken care of.)
|
| |\ \
| | |
| | |
| | |
| | | |
Fix test warnings
See merge request hubzilla/core!2134
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Introduce an intermediate variable when extracting the file type from
the file name. Otherwise we would try to pass a returned value as a
reference.
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
The `field_select` sub template wants five elements in the `field`
array.
|
| | | |
| | |
| | |
| | |
| | | |
Referencing undefined array keys are not allowed anymore, so we need to
check whether they exist first.
|
| | |/
| |
| |
| |
| |
| | |
Non-existing keys in the array passed to the template causes a warning.
Also make optional parts of the template actually optional by skipping
them if the value is empty.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
because timezone is attached
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
Correct type annotation in comment for Config::Get.
See merge request hubzilla/core!2127
|
| | |/ |
|
| |\ \
| | |
| | |
| | |
| | | |
Skip checking MFA status for WebDAV and CardDAV requests.
See merge request hubzilla/core!2131
|
| | |/ |
|
| |\ \
| | |
| | |
| | |
| | | |
Fix default timeouts for z_(fetch|post)_url.
See merge request hubzilla/core!2132
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When fetching the default timouts from config, the result is converted
to an int via `intval()`, the result of that again is compared strictly
to `false`. Since 0 !== false, the default values will never be used,
and 0 (no timeout) is passed to curl.
This cause requests to hang indefinitely (or until they are killed) when
receiving actions that require a lookup or fetch to another site as part
of the request processing. (E.g webfinger, or fetching objects that we
received an announce action for.) This again cause the request never to
return a useful status to the site sending the action, and could cause
them to think the Hubzilla site is dead.
This patch fixes this by comparing the fetched value from config to 0
instead of false, making the defaults work again if the config is not
set (or set to 0).
|
| |/ |
|
| |\
| |
| |
| |
| | |
Member docs: Update docs on tags and mentions.
See merge request hubzilla/core!2130
|
| | |
| |
| |
| |
| |
| | |
It was hardcoded to a blindingly white, which did not work too well with
the white text in dark mode. Use a proper bootstrap var, so it follows
the prefered color scheme instead.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Rewrote it and corrected some outdated information about how to tag
forums etc. Also cleaned up the markup a bit.
Added information and links about which apps and admin addons are
required for given functionality.
Also added some images to help illustrate some subjects.
Uncertain about whether the information on how the autocomplete popup is
populated is correct anymore. Underlined it and added a question mark to
make sure it annoys someone (possibly me) to figure it out.
|
