aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Module\Rpost: Add return type and visibilty for `get`.Harald Eilertsen2024-06-131-1/+1
|
* tests: More tests for Module\Rpost.Harald Eilertsen2024-06-131-14/+44
| | | | Also refactor the tests a bit to avoid duplicatng code.
* Module\Rpost: Refactor handling of attachments.Harald Eilertsen2024-06-131-68/+79
| | | | Move to private function for now.
* Module\Rpost: Reuse value of local_chanel.Harald Eilertsen2024-06-131-2/+4
| | | | We don't need to call it twice (actually trice in the original code).
* Module\Rpost: Refactor redirect or login logic.Harald Eilertsen2024-06-131-26/+37
|
* tests: Module\Rpost shows login form if not authenticated.Harald Eilertsen2024-06-131-0/+13
|
* tests: Add comment to Tests\Unit\Module\RpostTest.Harald Eilertsen2024-06-131-0/+4
|
* tests: Set query string in Module\TestCase::get method.Harald Eilertsen2024-06-131-0/+1
|
* tests: Configure system.baseurl for tests.Harald Eilertsen2024-06-132-7/+5
|
* Module\Rpost: Remove obsolete local variable $o.Harald Eilertsen2024-06-131-10/+1
|
* Module\Rpost: Remove unused local variables.Harald Eilertsen2024-06-131-4/+1
|
* Module\Rpost: Add basic test and fix session access.Harald Eilertsen2024-06-132-1/+32
| | | | | | | | | | | | | Just a basic test to ensure that the module `get()` method behaves somewhat reasonable when no query params are given. Had to make a small change to the Rpost module itself. Since the `$_SESSION` superglobal may not always be set (and is not in the test), use `isset` instead of `array_key_exists` to check if we have saved query params in the session. In general, isset is safer than array_key_exists if there's a chance that the array itself may not exist.
* docu and remove superfluous break statement after return statementMario2024-06-131-3/+1
|
* Merge branch 'add-config-for-phpcs' into 'dev'Mario2024-06-131-0/+78
|\ | | | | | | | | Add config file and rules for PHP Code Sniffer. See merge request hubzilla/core!2135
| * Add config file and rules for PHP Code Sniffer.Harald Eilertsen2024-06-121-0/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The rules are based on the "Generic" ruleset included by PHP Code Sniffer, with a significant portion of the rules disabled. This is a tradeoff between getting some useful feedback, and not being overloaded by noise. I've tried to encode a coe style that resembles the existing code as much as possible, but have included some sniffs that requires code changes to satisfy the style. This is meant as a starting point, and we can disable or enable more sniffs as we see fit. PHPCS also has ready rule sets for other common coding standards we may want to gravitate towards, e.g. PSR-12. Others are available from the community. The best way to run PHPCS is to integrate it with your editor, so that it will display diacnostics inline when saving or modifying the code. It can also be run from the command line like this: ./vendor/bin/phpcs -n [<path-to-file-to-check>] If no file is specified it will try to check the entire project. The `-n` means don't bother with warnings (I recommend that to begin with. Enable the warnings when the errors are taken care of.)
* | Merge branch 'fix-test-warnings' into 'dev'Mario2024-06-136-14/+21
|\ \ | | | | | | | | | | | | Fix test warnings See merge request hubzilla/core!2134
| * | Module\Setup: Don't access static variable as non static.Harald Eilertsen2024-06-121-3/+3
| | |
| * | Module\Help: Only variables can be passed by reference.Harald Eilertsen2024-06-121-1/+2
| | | | | | | | | | | | | | | | | | Introduce an intermediate variable when extracting the file type from the file name. Otherwise we would try to pass a returned value as a reference.
| * | Module\Rbmark: Pass all fields to input field templates.Harald Eilertsen2024-06-121-3/+3
| | |
| * | boot/login: Pass all expected args to sub templates.Harald Eilertsen2024-06-121-3/+3
| | |
| * | Module\Rbmark: Specify all fields in the template.Harald Eilertsen2024-06-121-0/+1
| | | | | | | | | | | | | | | The `field_select` sub template wants five elements in the `field` array.
| * | includes/menu: Fix timestamp handling in menu_create.Harald Eilertsen2024-06-121-3/+4
| | | | | | | | | | | | | | | Referencing undefined array keys are not allowed anymore, so we need to check whether they exist first.
| * | Module\Setup: Pass all required params for the template.Harald Eilertsen2024-06-122-1/+5
| |/ | | | | | | | | | | Non-existing keys in the array passed to the template causes a warning. Also make optional parts of the template actually optional by skipping them if the value is empty.
* | remove not needed namespaceMario2024-06-111-2/+2
| |
* | remove not required includes and include security.php in boot.phpMario2024-06-112-8/+2
| |
* | cleanup unused codeMario2024-06-111-11/+0
| |
* | pass the force argument to the xchan_photo daemonMario2024-06-112-4/+7
| |
* | duplicate array keyMario2024-06-101-1/+0
| |
* | too many argsMario2024-06-101-2/+2
| |
* | fix wrong variableMario2024-06-101-1/+1
| |
* | remove superfluous backslashMario2024-06-102-4/+4
| |
* | Ãfix undefined variableMario2024-06-101-1/+1
| |
* | remove duplicate array keyMario2024-06-101-1/+0
| |
* | docuMario2024-06-101-2/+2
| |
* | docuMario2024-06-101-2/+2
| |
* | fix updated not supported in wrapper functionMario2024-06-102-3/+3
| |
* | docu and declare return type for t()Mario2024-06-101-2/+2
| |
* | remove superfluous param, fix wrong var and declare types for unparse_url()Mario2024-06-102-5/+5
| |
* | remove unused variable and superfluous backslashMario2024-06-101-3/+1
| |
* | update changelogMario2024-06-071-0/+2
| |
* | update changelogMario2024-06-071-0/+9
| |
* | move button class to the right domMario2024-06-072-4/+4
| |
* | adjusting to the wrong direction when exporting ical and do not use Z ↵Mario2024-06-051-2/+2
| | | | | | | | because timezone is attached
* | bump versionMario2024-06-051-1/+1
| |
* | Merge branch 'correct-type-annotation-for-config-get' into 'dev'Mario2024-06-051-1/+1
|\ \ | | | | | | | | | | | | Correct type annotation in comment for Config::Get. See merge request hubzilla/core!2127
| * | Correct type annotation in comment for Config::Get.Harald Eilertsen2024-06-051-1/+1
| |/
* | Merge branch 'disable-mfa-for-dav-and-cdav' into 'dev'Mario2024-06-054-2/+119
|\ \ | | | | | | | | | | | | Skip checking MFA status for WebDAV and CardDAV requests. See merge request hubzilla/core!2131
| * | Skip checking MFA status for WebDAV and CardDAV requests.Harald Eilertsen2024-06-054-2/+119
| |/
* | Merge branch 'fetch-url-default-timeout' into 'dev'Mario2024-06-051-3/+3
|\ \ | | | | | | | | | | | | Fix default timeouts for z_(fetch|post)_url. See merge request hubzilla/core!2132
| * | Fix default timeouts for z_(fetch|post)_url.Harald Eilertsen2024-05-291-3/+3
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When fetching the default timouts from config, the result is converted to an int via `intval()`, the result of that again is compared strictly to `false`. Since 0 !== false, the default values will never be used, and 0 (no timeout) is passed to curl. This cause requests to hang indefinitely (or until they are killed) when receiving actions that require a lookup or fetch to another site as part of the request processing. (E.g webfinger, or fetching objects that we received an announce action for.) This again cause the request never to return a useful status to the site sending the action, and could cause them to think the Hubzilla site is dead. This patch fixes this by comparing the fetched value from config to 0 instead of false, making the defaults work again if the config is not set (or set to 0).
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-25 12:38:59 +0000